ci: add migration drift check

[FSM1]

Summary

• Adds a migration-check CI job that detects entity/migration drift by running typeorm migration:generate against a freshly-migrated Postgres database
• If any entity changes lack a corresponding migration file, the job fails with the generated migration contents and a fix command
• Added as a dependency of the build job (parallel with api-spec and test)

Prevents the class of bug from Phase 14 (PR #186) where a missing CREATE TABLE migration was invisible locally due to synchronize:true.

Test plan

• migration-check job appears in CI and passes on current codebase (no drift)
• To verify failure mode: locally add a dummy column to an entity, confirm migration:generate detects the drift

🤖 Generated with Claude Code

Summary by CodeRabbit

• Chores
  • Added an automated migration drift check to CI that validates database migrations on push and gates the build if structural drift is detected.
  • Updated project scripts for migration tooling to ensure consistent TypeScript configuration when running migration commands.

[coderabbitai]

Warning

Rate limit exceeded

@FSM1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 12 minutes and 39 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 5a8f70d and a79de59.

📒 Files selected for processing (1)

• .github/workflows/ci.yml

Walkthrough

Adds a Migration Drift Check job to CI that runs on pushes affecting src, boots PostgreSQL 16-alpine, runs migrations, and generates a drift-check migration; the Build job now depends on this check. Also adjusts the API package TypeORM CLI invocation to include --project tsconfig.json.

Changes

Cohort / File(s)	Summary
CI Pipeline Configuration .github/workflows/ci.yml	Added a new "Migration Drift Check" job that spins up PostgreSQL 16-alpine, installs deps, runs existing migrations, generates a drift-check migration, fails on structural drift (CREATE/DROP TABLE, ADD/DROP COLUMN, ALTER TYPE, RENAME COLUMN), and gates Build to depend on this job.
API package scripts apps/api/package.json	Updated the typeorm npm script to invoke ts-node with an explicit project: changed to ts-node --project tsconfig.json -r tsconfig-paths/register ./node_modules/typeorm/cli.js.

Sequence Diagram(s)

sequenceDiagram
    participant GH as GitHub Actions Runner
    participant DB as Postgres 16-alpine (service)
    participant NPM as npm / scripts
    participant ORM as TypeORM CLI
    participant Repo as Repository (migrations/entities)

    GH->>DB: spin up Postgres service
    GH->>NPM: install dependencies
    GH->>NPM: run migration scripts (apply existing migrations)
    NPM->>ORM: invoke TypeORM CLI (uses updated ts-node project)
    ORM->>Repo: generate drift-check migration
    ORM->>GH: return generated migration (diff)
    GH->>GH: evaluate migration contents for structural changes
    alt structural drift detected
        GH->>GH: fail job and print migration contents
    else only cosmetic/no drift
        GH->>GH: report success
    end

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• ci: enforce full pipeline as required checks for PR merge #134: Modifies .github/workflows/ci.yml and updates the Build job's dependency chain by adding prerequisite jobs, similar to this PR's approach of adding migration-check as a dependency.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'ci: add migration drift check' accurately describes the main change—adding a new CI job for migration drift detection, which is the primary focus of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/ci-migration-drift-check

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 213-223: The drift-check currently silences all failures with "||
true" after running "pnpm typeorm migration:generate ...", which masks
datasource/config errors; change the step to capture the command's exit code and
its stdout/stderr (run "pnpm typeorm migration:generate
src/migrations/DriftCheck -d src/data-source.ts" without "|| true"), then
inspect the output and exit code: if the output contains the exact success
string "No changes in database schema were found" treat it as success, but if
the exit code is non-zero and the output does not include that success message,
print the full command output (and the generated files under
src/migrations/*DriftCheck*.ts if any) and exit non‑zero to fail the job so
datasource/config errors are surfaced.

---

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 453f0f7 and 0a8dd66.

📒 Files selected for processing (2)

• .github/workflows/ci.yml
• .planning/todos/done/2026-02-27-ci-migration-drift-check.md

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/ci.yml:
- Around line 233-247: The early "exit 0" in the else branch after detecting "No
entity/migration drift detected." causes the subsequent STATUS/OUTPUT checks for
the `migration:generate` command to never run; remove or relocate that early
exit so the script always evaluates STATUS and OUTPUT after running
`migration:generate` (use the existing STATUS variable and the grep check on
OUTPUT to short-circuit only when the known "No changes in database schema were
found" message appears, otherwise let the code reach the block that logs
"::error::migration:generate failed unexpectedly." and exits 1). Ensure you only
short-circuit to success when the grep condition matches, and otherwise allow
the STATUS-based failure handling to execute.

---

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a8dd66 and 5a8f70d.

📒 Files selected for processing (2)

• .github/workflows/ci.yml
• apps/api/package.json