chore(ci): exclude version-bump files from change detection#209
Conversation
Release Please PRs only update version fields in package.json, Cargo.toml, tauri.conf.json, and .release-please-manifest.json. These changes don't affect build output, so exclude them from the paths-filter to avoid triggering expensive CI jobs (Windows/macOS desktop builds, tests, etc.) on every release PR. Real dependency changes are still detected via lockfile modifications (pnpm-lock.yaml, Cargo.lock) which continue to match the filters. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: da239724c4b4
WalkthroughThe CI workflow configuration adds path-filter exclusions to prevent unnecessary job triggers when specific dependency and configuration files change, including package.json, Cargo.toml, and tauri.conf.json files across multiple directories. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)
34-37: Consider the scope oftauri.conf.jsonexclusion.The
tauri.conf.jsonfile contains configuration beyond version fields—window settings, security policies, plugins, bundle identifiers, etc. Unlikepackage.json/Cargo.tomlchanges (which update lockfiles when dependencies change),tauri.conf.jsonconfig changes have no lockfile proxy.If a PR modifies non-version fields in
tauri.conf.json, thesrcfilter won't detect it. This may be acceptable if such changes are rare and typically accompanied by code changes, but worth documenting.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/ci.yml around lines 34 - 37, Remove or narrow the exclusion for tauri.conf.json in the CI changeset filter: either delete the '!**/tauri.conf.json' exclusion in the ci.yml changeset/file-filter or add an explicit check that triggers workflows when tauri.conf.json changes (e.g., separate path filter or dedicated job). Locate the ci.yml entry referencing 'tauri.conf.json' and update it so non-version edits to tauri.conf.json are detected (or document the exception in the workflow if you intentionally keep the exclusion).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 34-37: Remove or narrow the exclusion for tauri.conf.json in the
CI changeset filter: either delete the '!**/tauri.conf.json' exclusion in the
ci.yml changeset/file-filter or add an explicit check that triggers workflows
when tauri.conf.json changes (e.g., separate path filter or dedicated job).
Locate the ci.yml entry referencing 'tauri.conf.json' and update it so
non-version edits to tauri.conf.json are detected (or document the exception in
the workflow if you intentionally keep the exclusion).
Summary
package.json,Cargo.toml,tauri.conf.json, and.release-please-manifest.jsonfrom the CI change detection filterspnpm-lock.yaml,Cargo.lock) which continue to match the filtersTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit