Skip to content

chore(ci): exclude version-bump files from change detection#209

Merged
FSM1 merged 1 commit into
mainfrom
chore/ci-exclude-version-bumps
Feb 26, 2026
Merged

chore(ci): exclude version-bump files from change detection#209
FSM1 merged 1 commit into
mainfrom
chore/ci-exclude-version-bumps

Conversation

@FSM1

@FSM1 FSM1 commented Feb 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • Excludes package.json, Cargo.toml, tauri.conf.json, and .release-please-manifest.json from the CI change detection filters
  • Prevents Release Please PRs (which only bump version fields) from triggering expensive CI jobs like Windows/macOS desktop builds, tests, and API spec verification
  • Real dependency changes are still caught via lockfile modifications (pnpm-lock.yaml, Cargo.lock) which continue to match the filters

Test plan

  • Verify normal feature PRs still trigger full CI as expected
  • Verify the next Release Please PR skips expensive jobs (test, build, cargo-check, desktop builds)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Optimized CI workflow to reduce unnecessary job triggers by excluding configuration and dependency manifest files from change-based job activation.

Release Please PRs only update version fields in package.json,
Cargo.toml, tauri.conf.json, and .release-please-manifest.json.
These changes don't affect build output, so exclude them from
the paths-filter to avoid triggering expensive CI jobs (Windows/macOS
desktop builds, tests, etc.) on every release PR.

Real dependency changes are still detected via lockfile modifications
(pnpm-lock.yaml, Cargo.lock) which continue to match the filters.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Entire-Checkpoint: da239724c4b4
@coderabbitai

coderabbitai Bot commented Feb 26, 2026

Copy link
Copy Markdown

Walkthrough

The CI workflow configuration adds path-filter exclusions to prevent unnecessary job triggers when specific dependency and configuration files change, including package.json, Cargo.toml, and tauri.conf.json files across multiple directories.

Changes

Cohort / File(s) Summary
CI Workflow Configuration
.github/workflows/ci.yml
Added path-filter exclusions for package.json, Cargo.toml, tauri.conf.json, and release manifest files at top-level and nested locations (apps/desktop, packages/crypto) to reduce spurious CI job triggers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: excluding version-bump files from CI change detection in the workflow. It directly reflects the core objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/ci-exclude-version-bumps

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@FSM1 FSM1 enabled auto-merge (squash) February 26, 2026 22:31

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/ci.yml (1)

34-37: Consider the scope of tauri.conf.json exclusion.

The tauri.conf.json file contains configuration beyond version fields—window settings, security policies, plugins, bundle identifiers, etc. Unlike package.json/Cargo.toml changes (which update lockfiles when dependencies change), tauri.conf.json config changes have no lockfile proxy.

If a PR modifies non-version fields in tauri.conf.json, the src filter won't detect it. This may be acceptable if such changes are rare and typically accompanied by code changes, but worth documenting.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 34 - 37, Remove or narrow the
exclusion for tauri.conf.json in the CI changeset filter: either delete the
'!**/tauri.conf.json' exclusion in the ci.yml changeset/file-filter or add an
explicit check that triggers workflows when tauri.conf.json changes (e.g.,
separate path filter or dedicated job). Locate the ci.yml entry referencing
'tauri.conf.json' and update it so non-version edits to tauri.conf.json are
detected (or document the exception in the workflow if you intentionally keep
the exclusion).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/ci.yml:
- Around line 34-37: Remove or narrow the exclusion for tauri.conf.json in the
CI changeset filter: either delete the '!**/tauri.conf.json' exclusion in the
ci.yml changeset/file-filter or add an explicit check that triggers workflows
when tauri.conf.json changes (e.g., separate path filter or dedicated job).
Locate the ci.yml entry referencing 'tauri.conf.json' and update it so
non-version edits to tauri.conf.json are detected (or document the exception in
the workflow if you intentionally keep the exclusion).

ℹ️ Review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5f6192 and 0e5f4b3.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

@FSM1 FSM1 merged commit ee2e01f into main Feb 26, 2026
16 checks passed
@FSM1 FSM1 deleted the chore/ci-exclude-version-bumps branch March 4, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant