325 add angular wrappers by dafn · Pull Request #355 · FHIDev/Fhi.Designsystem

dafn · 2026-01-23T14:49:49Z

These are some guidelines for web component development that generates the best wrappers:

Do not use @type in JSdocs since the manifest type is now generated from the ts types
Remember to use ! to declare a property/attribute mandatory
Do not use set/get for properties as they obscure the inital value
- Do any extra processing in the update, updated or similar life cycle functions

dafn · 2026-01-23T14:56:45Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.598
View on GitHub Packages

dafn · 2026-01-23T14:57:51Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

dafn · 2026-01-25T21:46:45Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.600
View on GitHub Packages

dafn · 2026-01-25T21:47:50Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

dafn · 2026-02-02T10:12:43Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.609
View on GitHub Packages

dafn · 2026-02-02T10:13:49Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

dafn · 2026-02-03T10:06:37Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.610
View on GitHub Packages

dafn · 2026-02-03T10:07:32Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

dafn · 2026-08-14T20:06:11Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.974
View on GitHub Packages

dafn · 2026-08-14T20:07:22Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

…o 325-add-angular-wrappers

dafn · 2026-09-02T12:55:27Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.1006
View on GitHub Packages

dafn · 2026-09-02T12:56:46Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

dafn · 2026-09-03T09:53:28Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.1007
View on GitHub Packages

dafn · 2026-09-03T09:54:51Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

dafn · 2026-09-03T11:00:47Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.1010
View on GitHub Packages

dafn · 2026-09-03T11:02:03Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

dafn · 2026-09-03T12:06:56Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.1011
View on GitHub Packages

dafn · 2026-09-03T12:08:05Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

dafn · 2026-09-06T21:11:22Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.1012
View on GitHub Packages

dafn · 2026-09-06T21:12:40Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

dafn · 2026-09-14T11:12:36Z

Staging NPM Package published: @fhidev/pull-request-designsystem-355@0.0.1023
View on GitHub Packages

dafn · 2026-09-14T11:13:50Z

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-054beb503-355.westeurope.5.azurestaticapps.net

Co-authored-by: Trygve Bernhardt Moen Haaland <51702336+trybern@users.noreply.github.com>

HenrikFalla · 2026-09-30T12:04:24Z

+  switch (webComponentTagName) {
+    case 'fhi-text-input':
+    case 'fhi-date-input':
+    case 'fhi-select':
+      stateProperty = 'value';
+      valueProperty = 'value';
+      break;
+    case 'fhi-checkbox':
+    case 'fhi-radio':
+      stateProperty = 'checked';
+      valueProperty = 'value';
+      break;
+    case 'fhi-button':
+      return '';
+    default:
+      throw new Error(
+        `No value location defined for web component ${webComponentTagName}`,
+      );


Kunne det vært en ide å bruke manifestet her for å sjekke om et komponent er form associated, istedenfor å ha hardkodede tag navn man sjekker. Hvis det kommer et nytt komponent som er for skjema så må switchen oppdateres. F.eks. legge med komponent metadata i input og sjekke etter checked eller value?

Jeg er litt usikker på hva du tenker her. Kan du utdype?

Tenkte man kan bruke metadata i manifestet for å sjekke properties for value og checked.

const getFormAccessorConfig = (componentClass) => { const properties = componentClass.members.filter(member => member.kind === 'field'); const propertyNames = new Set(properties.map(property => property.name)); if (propertyNames.has('checked') && propertyNames.has('value')) { return { stateProperty: 'checked', valueProperty: 'value', }; } if (propertyNames.has('value')) { return { stateProperty: 'value', valueProperty: 'value', }; } return null; };

Så kan den brukes i starten av generateFormAccessor.

if (!formConfig) { return; } const { stateProperty, valueProperty } = formConfig;

ah, nå skjønner jeg hva du mener.

Det ser bra ut og jeg legger det til.

Det er to det kan være vært å notere seg:

Jeg kan ikke garantere at om en komponent har en property med navn checked så vil det alltid være state-en.

Jeg kan ikke garantere at om en komponent mangler en checked property så vil alltid value være state-en.

Så det er mulig dette kan brekke på et tidspunkt og må oppdateres, men det skal nok gå greit.

dafn and others added 3 commits January 22, 2026 17:14

wip angular wrapper generator

15d9086

add fhi-button to form elements

a544a21

wip: first test using suffix

4742ad1

dafn linked an issue Jan 23, 2026 that may be closed by this pull request

Add Angular wrappers #325

Open

dafn had a problem deploying to development January 23, 2026 14:49 — with GitHub Actions Failure

fix path

f579f4e

dafn temporarily deployed to development January 23, 2026 14:54 — with GitHub Actions Inactive

dafn temporarily deployed to development January 23, 2026 14:56 — with GitHub Actions Inactive

use -ng

196a874

dafn temporarily deployed to development January 25, 2026 21:44 — with GitHub Actions Inactive

dafn temporarily deployed to development January 25, 2026 21:46 — with GitHub Actions Inactive

Merge branch 'main' into 325-add-angular-wrappers

4123f54

dafn temporarily deployed to development February 2, 2026 10:10 — with GitHub Actions Inactive

dafn temporarily deployed to development February 2, 2026 10:12 — with GitHub Actions Inactive

add log for angular wrapper

5d6d856

dafn temporarily deployed to development February 3, 2026 10:04 — with GitHub Actions Inactive

dafn temporarily deployed to development February 3, 2026 10:06 — with GitHub Actions Inactive

put the wrappers in .temp and move them to npm and github dist locations

20e4494

dafn added 2 commits September 2, 2026 13:57

Merge branch 'main' of https://github.com/FHIDev/Fhi.Designsystem int…

b83bd17

…o 325-add-angular-wrappers

add analyse to generate:angular-wrappers

af90533

fix issue with generation order

c13fc31

change how the generator gets its paths

33f2d15

downgrade cem type-parser because of bug

bdf1788

dafn added 2 commits September 5, 2026 10:39

fix issue with components using checked state

50369ef

clean

3859260

Merge branch 'main' into 325-add-angular-wrappers

24e1e16

fhi-designsystem-bot and others added 5 commits September 15, 2026 15:45

remove help-text types from docs

8bb774a

Apply batched suggestions from code review

ee421ef

Co-authored-by: Trygve Bernhardt Moen Haaland <51702336+trybern@users.noreply.github.com>

Apply batched suggestions from code review

befe54e

Co-authored-by: Trygve Bernhardt Moen Haaland <51702336+trybern@users.noreply.github.com>

Merge branch 'main' into 325-add-angular-wrappers

b8d97c9

adapt text-area to wrappers

6723bd6

HenrikFalla approved these changes Oct 6, 2026

View reviewed changes

dafn added 2 commits October 7, 2026 10:20

Merge branch 'main' into 325-add-angular-wrappers

91baa5b

Merge branch 'main' into 325-add-angular-wrappers

22268e3

Conversation

dafn commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dafn commented Jan 23, 2026

Uh oh!

dafn commented Jan 23, 2026

Uh oh!

dafn commented Jan 25, 2026

Uh oh!

dafn commented Jan 25, 2026

Uh oh!

dafn commented Feb 2, 2026

Uh oh!

dafn commented Feb 2, 2026

Uh oh!

dafn commented Feb 3, 2026

Uh oh!

dafn commented Feb 3, 2026

Uh oh!

dafn commented Aug 14, 2026

Uh oh!

dafn commented Aug 14, 2026

Uh oh!

dafn commented Sep 2, 2026

Uh oh!

dafn commented Sep 2, 2026

Uh oh!

dafn commented Sep 3, 2026

Uh oh!

dafn commented Sep 3, 2026

Uh oh!

dafn commented Sep 3, 2026

Uh oh!

dafn commented Sep 3, 2026

Uh oh!

dafn commented Sep 3, 2026

Uh oh!

dafn commented Sep 3, 2026

Uh oh!

dafn commented Sep 6, 2026

Uh oh!

dafn commented Sep 6, 2026

Uh oh!

dafn commented Sep 14, 2026

Uh oh!

dafn commented Sep 14, 2026

Uh oh!

HenrikFalla Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

dafn Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

HenrikFalla Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dafn Oct 13, 2026

Choose a reason for hiding this comment

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dafn commented Jan 23, 2026 •

edited

Loading

HenrikFalla Oct 12, 2026 •

edited

Loading