[CP Staging] Revert #98603: Copilot list search inputs - #99983
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f9b40a2b99
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const backdropStyle: ViewStyle = useMemo(() => { | ||
| return {width: windowWidth, height: windowHeight, backgroundColor: backdropColor}; | ||
| }, [windowWidth, windowHeight, backdropColor]); |
There was a problem hiding this comment.
On mobile Safari when the reported useWindowDimensions() viewport is smaller than the modal host—particularly during browser chrome or keyboard viewport changes—these explicit pixel dimensions constrain the shared ReanimatedModal backdrop, leaving part of the page undimmed and outside the backdrop press target. This also removes the full-screen wrapper in Backdrop/index.web.tsx, rolling back the generic small-web-screen fix from 8102a6b8c23 even though the search inputs are the feature being reverted; retain the platform-specific web sizing so all BaseModal usages still cover the viewport.
Useful? React with 👍 / 👎.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 youssef-lr has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.65-2 🚀
|
|
No help site changes are required for this PR, so I did not create a docs PR. This is a pure revert of the Copilot list search inputs. The feature it removes (Expensify/App#98603) and its follow-up padding fix (Expensify/App#99970) never touched What I checked
UI verificationI ran the docs' own steps against the app on this branch. Result: partial — the documented steps work, but one label in the docs does not match the UI. That mismatch is pre-existing and unrelated to this revert.
Evidence (2)Account > Copilot page showing no search input after the revert
Account sidebar; switcher trigger not rendered for an account with no copilots
One separate thing worth fixingThe docs write the section heading as Copilot: Delegated Access, but the UI says Copilot: Delegated access. This appears 11 times across 4 articles ( @francoisl — there's no linked help site PR to review or mark |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.65-3 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.66-0 🚀
|
|
No help site changes are required for this PR, so I did not open a docs PR. This PR reverts the search inputs that #98603 added to the Copilot list and the account switcher's copilot list. No article in What I checked
I also drove the web build on this branch to confirm the Copilot page has no list search field: 
Two things worth a look, both outside this PR's scope:
There's no help site PR to link or mark |
|
🚀 Cherry-picked to staging by https://github.com/roryabraham in version: 9.4.68-0 🚀
|
|
No help site changes are required for this PR, so I did not open a docs PR. This revert removes the search input from the Copilot list and the account switcher. The help site never documented that input, so nothing on the help site is now inaccurate. How I verified itThe reverted PRs never touched docs. Neither #98603 nor #99970 changed any file under No article describes a search field in either list. The only search mention in the Copilot articles is step 3 of "How to add a Copilot" — The documented steps still match the live UI. I checked NewDot web on this branch's code. Account > Copilot shows the Copilot: Delegated access section with the Add a copilot button and no search input above the list — which is what the articles already describe. One unrelated inaccuracy I noticed while checking labels — flagging it rather than folding it into a revert-scoped PR: The articles write the section heading as Copilot: Delegated Access, but the live label is Copilot: Delegated access with a lowercase "access" ( @francoisl, since no docs PR was needed here, there is nothing to review or mark |
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀
Bundle Size Analysis (Sentry): |
4 participants
Explanation of Change
Reverts #98603, which added search inputs to the Copilot list and the account switcher copilot list. That feature produced four deploy blockers on the 9.4.65-1 checklist, so it is being pulled from staging rather than patched under deploy pressure.
This also reverts #99970, which fixed the padding on the search field that #98603 introduced. It only exists to patch the reverted feature, so it goes with it.
Fixed Issues
$ #99961
$ #99964
$ #99972
$ #99974
Tests
Same as QA
QA Steps
Verify that all the blockers linked in "Fixed issues" are no longer reproducible
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari