Update conciergeChat to remove Onyx.connect - 39 by cretadn22 · Pull Request #99816 · Expensify/App

cretadn22 · 2026-08-29T06:55:03Z

Explanation of Change

Fixed Issues

$ #66411
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to the Concierge chat
Try replying to any message in a thread
Verify that the app navigates to the child report
Go to any other chat
Repeat steps 2 and 3, and verify that it works correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-08-29.at.14.15.01.mov

melvin-bot · 2026-08-29T06:55:10Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-08-29T06:58:18Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/actions/Report/index.ts	`71.95% <100.00%> (+0.48%)`	⬆️
...report/ContextMenu/BaseReportActionContextMenu.tsx	`87.50% <100.00%> (+0.07%)`	⬆️
...nbox/report/ReportActionItemMessageWithExplain.tsx	`91.30% <100.00%> (+0.82%)`	⬆️
src/pages/Share/ShareDetailsPage.tsx	`0.00% <0.00%> (ø)`
src/pages/inbox/report/ReportActionItemThread.tsx	`0.00% <0.00%> (ø)`
...es/inbox/report/ContextMenu/ContextMenuActions.tsx	`40.34% <0.00%> (ø)`
... and 12 files with indirect coverage changes

JmillsExpensify

No product review required.

DylanDylann · 2026-09-01T15:11:12Z

@codex review

DylanDylann · 2026-09-01T15:12:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-09-01.at.22.30.06.mov

chatgpt-codex-connector · 2026-09-01T15:16:35Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 5c1dc5f567

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann · 2026-09-01T15:19:16Z

@cretadn22 Please resolve conflict

…n ReportTest

cretadn22 · 2026-09-01T17:23:48Z

@rlinoz The failing test is coming from main and is also happening in other PRs (#98391 is an example)

github-actions · 2026-09-01T18:10:33Z

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-01T18:14:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-01T18:14:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99816.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-66153c7-b66008c-d074b73588aaa129038dd9f45cdf331beb9176b7/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-66153c7-b66008c-4b8f0b291eb720eaf7231b96ba8593f6c2737d1a/index.html

Web 🕸️
https://99816.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-02T00:37:21Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-02T00:40:25Z

🤖 No help site changes are required for this PR — no docs PR was created.

This is a pure internal refactor with no user-facing change. It removes the Onyx.connect() subscription for ONYXKEYS.CONCIERGE_REPORT_ID and passes the conciergeChat report down as a parameter instead (Expensify/App#66411).

What I checked

Changes in the diff:

src/libs/actions/Report/index.ts — adds a conciergeChat parameter to navigateToAndOpenChildReport, createChildReport, and toggleSubscribeToChildReport, and converts explain() from positional arguments to an object parameter.
src/pages/inbox/report/ContextMenu/ContextMenuActions.tsx, BaseReportActionContextMenu.tsx, ReportActionItemThread.tsx, ReportActionItemMessageWithExplain.tsx, ShareDetailsPage.tsx — read conciergeChat via useOnyx and pass it through.
tests/actions/ReportTest.ts — updates tests for the new signatures.

Why no docs update:

No new or renamed feature, tab, setting, button, or menu item.
No copy changes — nothing added or edited in src/languages/*.
No change to any documented workflow. The QA steps (reply in a thread from Concierge or any chat, land on the child report) describe existing behavior that this PR preserves, not new behavior.
Nothing in App/docs/articles describes the internal Onyx data layer, so there is no article to correct.

cretadn22, there is no help site PR to review for this one. If you believe a specific article is out of date for a reason outside this diff, reply with the article and what changed and I'll draft the update.

view run

OSBotify · 2026-09-02T21:12:49Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.68-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-09-02T21:17:17Z

🤖 No help site changes are required for this PR. I did not create a docs draft PR.

Why: this PR is an internal refactor with no user-facing change. It removes the Onyx.connect() subscription for ONYXKEYS.CONCIERGE_REPORT_ID and threads the conciergeChat report through as a parameter instead. Every changed file is plumbing or tests:

File	Change
`src/libs/actions/Report/index.ts`	Adds a `conciergeChat` param to `navigateToAndOpenChildReport`, `createChildReport`, `toggleSubscribeToChildReport`; converts `explain` to an object-param signature
`src/pages/Share/ShareDetailsPage.tsx`	New `useOnyx` read for the Concierge report
`src/pages/inbox/report/ContextMenu/BaseReportActionContextMenu.tsx`	Passes `conciergeChat` into the context-menu payload
`src/pages/inbox/report/ContextMenu/ContextMenuActions.tsx`	Forwards `conciergeChat` from the payload to the action handlers
`src/pages/inbox/report/ReportActionItemMessageWithExplain.tsx`	Updated to the new `explain` signature
`src/pages/inbox/report/ReportActionItemThread.tsx`	New `useOnyx` read for the Concierge report
`tests/actions/ReportTest.ts`	Test updates for the new signatures

There are no changes to src/languages/*, no new or renamed pages, no new settings, and no changed button or tab labels. The QA steps confirm the goal is that existing behavior stays identical: replying in a thread from Concierge and from any other chat still navigates to the child report.

The one article that documents this flow already matches the current UI, so it needs no edit:

docs/articles/new-expensify/chat/Chat-Features-and-Moderation-Tools.md:72 — "Right-click the message and select Reply in thread."

@cretadn22, there is no linked help site PR to mark Ready for review, because this refactor changes no documented behavior. Please confirm you agree. If you believe some user-facing behavior did change, reply with the specific behavior and I'll open the docs draft PR.

view run

OSBotify · 2026-09-02T21:50:05Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

ntegrating conciergeChat parameter across multiple components

5c1dc5f

cretadn22 requested review from a team as code owners August 29, 2026 06:55

melvin-bot Bot assigned cretadn22 Aug 29, 2026

melvin-bot Bot requested review from DylanDylann and JmillsExpensify and removed request for a team August 29, 2026 06:55

melvin-bot Bot requested review from a team and removed request for a team August 29, 2026 06:55

JmillsExpensify reviewed Aug 29, 2026

View reviewed changes

DylanDylann approved these changes Sep 1, 2026

View reviewed changes

melvin-bot Bot requested a review from rlinoz September 1, 2026 15:30

cretadn22 added 3 commits September 1, 2026 22:37

merge main into the current branch

3082621

Fix: add missing parameter to navigateToAndOpenChildReport function i…

22eabcd

…n ReportTest

Merge branch 'main' into fix/66411-part-39

f0172a4

rlinoz approved these changes Sep 1, 2026

View reviewed changes

Merge branch 'main' into fix/66411-part-39

74714ec

rlinoz merged commit 66153c7 into Expensify:main Sep 1, 2026
33 checks passed

OSBotify mentioned this pull request Sep 2, 2026

Deploy Checklist: New Expensify 2026-09-02 #100087

Closed

82 tasks done

melvin-bot Bot mentioned this pull request Sep 2, 2026

[Due for payment 2026-09-15] [Partial Payment made] Remove Onyx.connect() for the key: ONYXKEYS.CONCIERGE_REPORT_ID in src/libs/ReportUtils.ts #66411

Closed

Conversation

cretadn22 commented Aug 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 29, 2026

Uh oh!

codecov Bot commented Aug 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Sep 1, 2026

Uh oh!

DylanDylann commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot commented Sep 1, 2026

Uh oh!

DylanDylann commented Sep 1, 2026

Uh oh!

cretadn22 commented Sep 1, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 1, 2026

Uh oh!

OSBotify commented Sep 1, 2026

Uh oh!

github-actions Bot commented Sep 1, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

MelvinBot commented Sep 2, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

MelvinBot commented Sep 2, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cretadn22 commented Aug 29, 2026 •

edited

Loading

codecov Bot commented Aug 29, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Sep 1, 2026 •

edited

Loading