[Payment due @situchan] [No QA] Docs updates for E/A#97401 Settle balance confirmation step - #99705
Conversation
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://6852a7e7.helpdot.pages.dev ⚡️ Updated articles: |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safaritest.mov |
|
🎯 @situchan, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
@situchan bump on this! |
|
✅ The docs change matches current I verified the two claims in the diff against the code:
So the old wording ("Click Settle Balance to trigger an early settlement") was wrong on both counts, and the new 4-step version is accurate. Why I verified from code rather than the live appThe Settle balance button only renders when Status: approved by |
|
@MelvinBot mark this PR as ready for review. |
|
✅ Done — this PR is now marked Ready for review. Current state:
Nothing else is blocking on my side. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, targeted improvement to Troubleshoot-Expensify-Card-issues.md. It refines the numbered steps for refreshing a workspace Expensify Card limit: it corrects the button casing (Settle Balance to Settle balance) and adds a previously missing confirmation step. The change is scoped to a single procedure within an existing task-based section and improves both accuracy and completeness. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
@stephanieelliott done |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀
|
|
🤖 Payment issue created: #100625 |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
PR #97401 added a confirmation modal before an Expensify Card balance is settled. Clicking Settle balance now opens a confirmation window, and the settlement only fires after the user confirms.
The help article How to Troubleshoot Expensify Card Issues documented the old flow (a single click triggered settlement immediately) and also used the wrong capitalization (
Settle Balance). This updates the "refresh the workspace's Expensify Card limit" steps to:en.ts).Related PR
Fixed Issues
$ N/A — documentation follow-up for the behavior change in E/A#97401
Tests
N/A — documentation-only change.
QA Steps
N/A — documentation-only change.
PR Author Checklist
### Fixed Issuessection above@situchan, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.