Skip to content

[No QA] Docs updates for E/A#99400 Copilots can't close account owner's account - #99604

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-docsCloseAccountCopilots
Sep 16, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-docsCloseAccountCopilots

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Follow-up docs for #99400, which gates the Close account action for Copilots. When someone acting as a Copilot selects Close account in the account owner's Security settings, they now see a no-access message instead of the close form, and direct links show a full-page not-allowed view. The backend already blocks this action, so the form was never actionable for Copilots.

This updates the Act as a Copilot help article to reflect that closing the account owner's account is never available to Copilots, regardless of access level (including Full Access).

Changes

  • docs/articles/new-expensify/settings/Act-as-a-Copilot.md
    • Clarified in What you can do as a Copilot that a few actions (including closing the account owner's account) are never available to Copilots.
    • Added a note under the Why can't I perform certain actions? FAQ explaining that selecting Close account in the account owner's Security settings shows a "you don't have permission" message.

Related


@lakchote, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Lucien Akchoté <lakchote@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 26, 2026
@MelvinBot MelvinBot mentioned this pull request Aug 26, 2026
59 tasks
@github-actions github-actions Bot changed the title Docs updates for E/A#99400 Copilots can't close account owner's account [No QA] Docs updates for E/A#99400 Copilots can't close account owner's account Aug 26, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://82c71fad.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott

Copy link
Copy Markdown
Contributor

@lakchote, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

bump on this @lakchote!

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I checked the two doc statements against current main (acf82f8d) to make the review quicker for lakchote. Both are accurate.

Doc statement Code on main
Closing the account owner's account is never available to Copilots, regardless of access level SecuritySettingsPage.tsx:181-191 — the Close account menu item calls showDelegateNoAccessModal() whenever isActingAsDelegate, with no access-level branch
Selecting Close account shows a message saying you don't have permission en.ts:10803-10804 — "As a copilot for {email}, you don't have permission to take this action. Sorry!"
(PR body claim) Direct links show a full-page not-allowed view CloseAccountPage.tsx:114 — wrapped in DelegateNoAccessWrapper with the DELEGATE variant, which renders FullPageNotFoundView

One nuance worth a look: since #99400 merged, main added an exception at SecuritySettingsPage.tsx:188 — when you copilot into an Agent (not a person), Close account falls through and deletes the agent instead of showing the no-access modal. I don't think that changes the article, which is about copiloting a person's account, but flagging it in case you want the wording narrowed.

I'm leaving the ready-for-review flip to you, lakchote — reply with @MelvinBot mark this PR as ready for review once you're happy with the copy.


view run

@lakchote

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review

@lakchote

Copy link
Copy Markdown
Contributor

@lakchote, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

bump on this @lakchote!

Sorry @stephanieelliott this got lost into my GH notifications, it's done now! Thanks

@MelvinBot
MelvinBot marked this pull request as ready for review September 16, 2026 15:46
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — this PR is now ready for review.

PullerBear assigned stephanieelliott as the reviewer.

@lakchote

Copy link
Copy Markdown
Contributor

@stephanieelliott ready for review now

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This is a small, focused follow-up to App#99400 that documents that Copilots can never close the account owner's account, regardless of access level. Only one file is touched with two content additions: a clarifying sentence in the What you can do as a Copilot section, and an explanatory note under the Why can't I perform certain actions? FAQ. Both additions are accurate, well-scoped to the existing workflow, and consistent with the surrounding article. The change also cleans up a trailing space on an existing line.

Scores Summary

  • Readability: 9/10 - Both additions are clear, concise, and use a concrete example (Close account in Security settings) that reads naturally within the existing prose.
  • AI Readiness: 9/10 - New content reinforces retrievable search intent (why can't I close the account owner's account as a Copilot). It sits under existing task-based headings and does not introduce any heading, hierarchy, or metadata issues. internalScope and YAML remain intact (unchanged by this diff).
  • Style Compliance: 9/10 - UI labels are correctly bolded and use exact Sentence case (Close account, Security, Full Access, Limited Access), consistent with HELPSITE_NAMING_CONVENTIONS.md. No prohibited vague navigation phrasing.

Key Findings

  • The FAQ note gives a precise, deterministic description of the user-facing behavior (a you-do-not-have-permission message on selecting Close account), which is exactly the kind of concrete detail the guidelines favor.
  • Minor consistency nit: the two additions describe the same constraint in slightly different words (never available to Copilots, regardless of access level, including closing the account owner's account vs. never available to Copilots, even with Full Access). Both are correct; wording them identically would tighten consistency, but this is optional.
  • The FAQ note references Security settings but does not spell out the navigation path to reach them. Given the note is illustrative (behavior on selection) rather than procedural, this is acceptable and does not warrant a numbered navigation step.

Recommendations

  • No blocking issues. Optionally align the phrasing of the two new sentences for consistency (pick one canonical way to state the restriction).
  • Consider whether the FAQ heading Why can't I perform certain actions? could be made slightly more specific over time, but that is pre-existing and out of scope for this PR.

Files Reviewed

  • docs/articles/new-expensify/settings/Act-as-a-Copilot.md - Two accurate, well-scoped additions plus a whitespace cleanup. Compliant with governance; approve.

Note: This PR is small enough that no separate inline comments were necessary.

@stephanieelliott
stephanieelliott merged commit 4afb6a0 into main Sep 16, 2026
20 of 21 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsCloseAccountCopilots branch September 16, 2026 21:33
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.82-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.86-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.89-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants