Fix: anonymous user first time tapping on sign in button or a thread open public room - #99582
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f57a5591b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@nkdengineer Kindly check on the automated comments and address those if required. If not required kindly comment the reasoning. |
|
@abdulrahuman5196 I've done. |
abdulrahuman5196
left a comment
abdulrahuman5196
left a comment
There was a problem hiding this comment.
@nkdengineer Kindly fix the branch conflicts as well.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-09-16.at.9.16.19.PM.movAndroid: mWeb ChromeScreen.Recording.2026-09-16.at.9.22.07.PM.moviOS: HybridAppScreen.Recording.2026-09-16.at.8.28.11.PM.moviOS: mWeb SafariScreen.Recording.2026-09-16.at.8.49.03.PM.movMacOS: Chrome / SafariScreen.Recording.2026-09-16.at.5.20.16.PM.mov |
abdulrahuman5196
left a comment
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @stitesExpensify
🎀 👀 🎀
C+ Reviewed
|
🚧 stitesExpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.4.82-0 🚀
|
|
🤖 No help site changes are required. I did not create a docs PR. Why: This PR adds a navigation guard in Nothing user-facing changed: no new feature, screen, setting, tab, button, or label. The help site documents how features work, not navigation bug fixes, so no article under What I checked
|
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.4.86-0 🚀
|
|
🤖 No help site changes required — so I did not create a docs PR. Why: This PR is a navigation timing fix, not a product behavior change. It adds an Nothing changed that the help site documents:
Articles I checkedI searched
No article describes what an anonymous user sees after tapping a public room link, so there is no documented statement this fix makes stale. The existing docs already match the post-fix behavior, because the pre-fix behavior was the bug. If you want the deep link entry flow for anonymous users documented as a net-new article, say so and I'll draft one — but that would be new documentation scope, not a correction this PR forces. |
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 9.4.89-0 🚀
|
|
🤖 Re-checked — still no help site changes required. No docs PR created. Nothing has changed since my check yesterday: the PR is still the single-file change (last commit Why: This is a navigation timing fix, not a product behavior change. The Nothing the help site documents changed — no new or renamed feature, tab, setting, or button label, and no documented flow, permission, or pricing change. Articles I checkedSearching
No article describes what an anonymous user sees after tapping a public room link, so this fix makes no documented statement stale. The docs already match the post-fix behavior, because the pre-fix behavior was the bug. Since no changes were required, I skipped the conditional steps you specified — the draft PR, the If you'd like the anonymous deep link entry flow documented as a net-new article, reply and I'll draft one — but that is new documentation scope, not a correction this PR forces. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.89-0 🚀
Bundle Size Analysis (Sentry): |
6 participants
Explanation of Change
Fix: anonymous user first time tapping on sign in button or a thread open public room
Fixed Issues
$ #96346
PROPOSAL: #96346 (comment)
Tests
Offline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-26.at.22.46.35.mov
Android: mWeb Chrome
Screen.Recording.2026-08-26.at.22.44.31.mov
iOS: Native
Screen.Recording.2026-08-26.at.22.42.37.mov
iOS: mWeb Safari
Screen.Recording.2026-08-26.at.22.40.34.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-26.at.22.39.14.mov