fix: NitroSQLite not propagating native errors by upgrading Skia to 2.4.18

[chrispader]

On iOS, Skia 2.4.14's prebuilt C++ libraries do not receive the exception flags required for cross-module C++ exceptions. NitroFetch therefore turns useful URLSession failures into Unknown std::runtime_error error., which prevents App from classifying network failures. This PR upgrades Skia to 2.4.18, which keeps the exception fix first released in 2.4.17 and avoids the Android canvas transparency regression that 2.4.17 accidentally shipped.

@mountiny @mallenexpensify

Explanation of Change

Skia PR #3595 attempted to enable -fexceptions and -frtti through GN's extra_cflags, but that setting did not apply the flags to C++ sources in the prebuilt Apple libraries. Skia PR #3681 changed the setting to extra_cflags_cc and rebuilt the Apple artifacts. That fix shipped in 2.4.17 and remains in 2.4.18.

Skia 2.4.17 also included an accidental test change that made transparent Android canvas backgrounds render black. The maintainer republished the package, and the issue reporter confirmed that 2.4.18 fixes the regression in Shopify/react-native-skia#3683. No App or NitroFetch error handling changes in this PR.

Upstream context:

• fix(🐛): set -fexceptions and -frtti flag in the Skia build Shopify/react-native-skia#3595
• fix(🍏): use extra_cflags_cc for C++ exception handling flags Shopify/react-native-skia#3681
• fix(🍏): enable C++ exceptions and RTTI in podspec Shopify/react-native-skia#3638
• [android] canvas background color broken Shopify/react-native-skia#3683
• https://github.com/Shopify/react-native-skia/releases/tag/v2.4.18
• Bug: iOS Error: Unknown std::runtime_error when using react-native-skia margelo/nitro#919

Fixed Issues

$ #98988
PROPOSAL: #98988

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14083

Tests

1. On main, change the react-native import in index.js to include Alert, then add the following reproduction block immediately after additionalAppSetup():

   import {Alert, AppRegistry} from 'react-native';
   
   // ... existing app registration ...
   AppRegistry.registerComponent(Config.APP_NAME, () => App);
   additionalAppSetup();
   
   if (__DEV__) {
       setTimeout(() => {
           globalThis.fetch('https://127.0.0.1:1/nitro-fetch-error-repro').catch((error) => {
               const message = error instanceof Error ? error.message : String(error);
               Alert.alert('NitroFetch repro', message);
           });
       }, 3000);
   }

2. Run the iOS HybridApp development build.

3. Verify the request rejects with Unknown std::runtime_error error. while the app uses Skia 2.4.14.

4. Install this branch's dependencies and pods, then rebuild the same iOS target with Skia 2.4.18.

5. Run the identical request and verify it rejects with NSURLErrorDomain Code=-1004, Could not connect to the server., and the failing URL instead of the opaque runtime error.

6. Remove the temporary reproduction call and verify no reproduction alert or debug logging remains.

• Verify that no errors appear in the JS console

Offline tests

1. Open an iOS native development build and sign in while online.
2. Start a Request Money flow with a large PDF receipt.
3. Submit the request, then disable network connectivity while the upload is in progress.
4. Verify the app reports itself offline after repeated failures and keeps the request queued.
5. Restore connectivity and verify the request retries instead of being discarded.

QA Steps

1. Open an iOS native staging build and sign in.
2. Start a Request Money flow with a large PDF receipt.
3. Submit the request, then interrupt the network connection while the upload is in progress.
4. Verify the app reports itself offline after repeated failures and does not navigate to a Not Found page.
5. Restore connectivity and verify the request retries and the expense finishes creating.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

The after screenshot was captured with Skia 2.4.17, the first release with the C++ exception fix. The final dependency is 2.4.18 because it keeps that fix and resolves the Android canvas regression in Shopify/react-native-skia#3683.

iOS: Native

Before: Skia 2.4.14	After the exception fix: Skia 2.4.17

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 6 files with indirect coverage changes

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[melvin-bot]

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chrispader]

@brunovjk this PR is ready for review! 🙌🏼

[brunovjk]

Hey @chrispader, what do you think about this reported Android canvas transparency regression in Skia 2.4.17?

Shopify/react-native-skia#3683

It seems to be fixed in 2.4.18.

[chrispader]

Ahh thanks for raising that up. Let's bump to 2.4.18 then instead! 🙌🏼

[chrispader]

@brunovjk i've updated the Skia version!

[brunovjk]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

iOS: HybridApp

main:

this PR:

[brunovjk]

The diff looks good overall. @chrispader the Mobile-Expensify PR #14083 references the closed App PR #99696. Should we update it to reference this PR (#99541) instead?

[chrispader]

The diff looks good overall. @chrispader the Mobile-Expensify PR #14083 references the closed App PR #99696. Should we update it to reference this PR (#99541) instead?

@brunovjk done!

[github-actions]

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99541.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6a1b1ec-cd2cd49-bc67e5816cc5d15b97379e7dd2806bf3fc4f50cd/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6a1b1ec-cd2cd49-bd30671d56116ab98fb9bf6c7ae6edc83a1feebe/index.html

Web 🕸️
https://99541.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.65-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.65-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android