Skip to content

[No QA] Move docs to new Rillet hub on help site - #99454

Merged
stephanieelliott merged 10 commits into
mainfrom
helpsite-move-rillet-docs
Aug 25, 2026
Merged

stephanieelliott merged 10 commits into
mainfrom
helpsite-move-rillet-docs

Conversation

@stephanieelliott

@stephanieelliott stephanieelliott commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Unhide Rillet docs and create new hub folder in Connections section.

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

@stephanieelliott stephanieelliott self-assigned this Aug 25, 2026
@stephanieelliott
stephanieelliott requested a review from a team as a code owner August 25, 2026 18:13
@melvin-bot

melvin-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @jliexpensify

@melvin-bot

melvin-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

@mjasikowski @jliexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 25, 2026 18:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

After the initial sync completes, you can configure your import, export, and advanced accounting settings. Learn how to [configure your Rillet import, export, and advanced settings](/articles/Unlisted/Configure-Rillet).

P2 Badge Point the configuration link at its new route

After this commit moves the configuration article, this next-step link still targets /articles/Unlisted/Configure-Rillet, but that page no longer exists and docs/redirects.csv contains no redirect for it. Users following the link after connecting Rillet will receive a 404; update it to /articles/new-expensify/connections/rillet/Configure-Rillet or add the corresponding redirect.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR relocates two existing Rillet articles from docs/articles/Unlisted/ to a new public hub at docs/articles/new-expensify/connections/rillet/ and adds the hub landing page docs/new-expensify/hubs/connections/rillet.html. Both renames are 100% similarity moves, so no article body content changes in the diff. The scores below reflect the readiness of these articles to go live via this move, per the governance files.

Scores Summary

  • Readability: 8/10 - Clear, benefit-led intros, well-scoped procedural steps, and clean scannable bullet lists. Consistent How to... section phrasing reads well.
  • AI Readiness: 8/10 - Strong YAML metadata on both files including internalScope, task-based headings, single-workflow scoping, and correct # / ##-only hierarchy. Minor: Connect-to-Rillet.md carries an order: 1 field its sibling lacks.
  • Style Compliance: 6/10 - UI terminology, bolded buttons/tabs, the three dots (⋮) rule, and unified web/mobile navigation phrasing are all handled correctly. However the move breaks internal cross-links (see below), which is the main blocker introduced by this PR.

Key Findings

  • Blocker (introduced by this move): Cross-links still point at the old Unlisted locations and will 404 once the files move. Configure-Rillet.md links to /articles/new-expensify/Unlisted/Connect-to-Rillet (also a malformed path), and Connect-to-Rillet.md links to /articles/Unlisted/Configure-Rillet. Both should be updated to the new /articles/new-expensify/connections/rillet/... paths.
  • Pre-existing content nit surfaced by publishing: the screenshot placeholder in Connect-to-Rillet.md says "After step 7" but the procedure has only 4 steps.
  • Positives: Both articles follow the authoring spec closely — task-based headings, exact UI labels, correct button/tab bolding, compliant three dots menu reference, and a well-formed FAQ. Hub HTML uses the standard section.html include pattern.

Recommendations

  • Update all internal cross-links to the new connections/rillet/ paths before merge, and fix the malformed new-expensify/Unlisted segment.
  • Align the order frontmatter between the two articles for predictable hub ordering.
  • Correct the "After step 7" screenshot placeholder reference to match the 4-step flow.

Files Reviewed

  • docs/articles/new-expensify/connections/rillet/Connect-to-Rillet.md - Moved from Unlisted. Solid article; outbound cross-link needs path update.
  • docs/articles/new-expensify/connections/rillet/Configure-Rillet.md - Moved from Unlisted. Solid article; outbound cross-link needs path update (malformed Unlisted segment).
  • docs/new-expensify/hubs/connections/rillet.html - New hub page, standard template, looks correct.

Note: Detailed line-by-line feedback has been provided as inline comments.

@github-actions github-actions Bot changed the title Move docs to new Rillet hub on help site [No QA] Move docs to new Rillet hub on help site Aug 25, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 25, 2026
@stephanieelliott
stephanieelliott requested review from a team as code owners August 25, 2026 18:44
@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team August 25, 2026 18:44
@stephanieelliott
stephanieelliott removed request for a team and garrettmknight August 25, 2026 18:47
@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott requested a review from a team August 25, 2026 18:58
@melvin-bot

melvin-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @lschurr

@melvin-bot
melvin-bot Bot requested review from lschurr and mjasikowski and removed request for a team August 25, 2026 18:58
@melvin-bot

melvin-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

@mjasikowski @lschurr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NOTE: It looks like docs/redirects.csv was modified in this PR. Please see this SO for special instructions on how to review changes to that file.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://243f2165.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott removed the request for review from mjasikowski August 25, 2026 19:15
@lschurr

lschurr commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@stephanieelliott - in the preview of both articles, there are images that don't load:

image image

Should those load or is that normal for the preview?

@stephanieelliott

Copy link
Copy Markdown
Contributor Author

Oh @lschurr sorry I should've given you a heads up -- that's expected that the images don't load. Because they were also added in this PR, they won't render on the Dev build

@lschurr lschurr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@stephanieelliott
stephanieelliott merged commit 5ddfb51 into main Aug 25, 2026
16 of 18 checks passed
@stephanieelliott
stephanieelliott deleted the helpsite-move-rillet-docs branch August 25, 2026 19:48
@stephanieelliott

Copy link
Copy Markdown
Contributor Author

@MelvinBot the preview here shows the rillet hub and articles rendered correctly on helpdot.pages.dev. However, after merging this PR, the hub and articles are not showing on the live site help.expensify.com. Why is this happening, and how can I fix it?

@MelvinBot

Copy link
Copy Markdown
Contributor

Good news: the Rillet hub and both articles are live and rendering correctly on help.expensify.com right now. Nothing is broken in the build — what you saw was a stale Cloudflare edge cache, and it has since cleared.

I just verified on production:

  • https://help.expensify.com/new-expensify/hubs/connections/rillet → renders both Connect to Rillet and Configure Rillet cards ✅
  • https://help.expensify.com/new-expensify/hubs/connections/Rillet now appears as a section ✅
  • https://help.expensify.com/articles/new-expensify/connections/rillet/Connect-to-Rillet and .../Configure-Rillet → both return 200 with full content ✅

Why it looked broken right after merge: HelpDot pages are served through Cloudflare with a 24-hour edge cache (cache-control: public, max-age=86400). Your merge deploy (run succeeded at 19:48 UTC) rebuilt and pushed the site fine, but for a short window some edge locations (and your own browser) were still serving the pre-merge cache — the old Connections index without the Rillet card, and cached 404s for the brand-new URLs — until the deploy's cache-purge propagated. The currently-served copy is stamped last-modified: 25 Aug 2026 20:00 UTC, i.e. after the deploy, which is why it's correct now.

If you (or anyone) still see the old version: hard-refresh (Cmd/Ctrl+Shift+R) or wait for the edge cache to expire. No code change is needed for the hub or articles.


One real follow-up to fix, though — there's a typo in one of the redirects this PR added. In docs/redirects.csv:1020 the target is missing /articles/:

# current (404s):
https://help.expensify.com/articles/Unlisted/Configure-Rillet,https://help.expensify.com/new-expensify/connections/rillet/Configure-Rillet
# should be:
https://help.expensify.com/articles/Unlisted/Configure-Rillet,https://help.expensify.com/articles/new-expensify/connections/rillet/Configure-Rillet

I confirmed the old .../Unlisted/Configure-Rillet link currently redirects to a 404, while the Connect-to-Rillet redirect on line 1021 is correct (it has /articles/). Anyone following an old Configure-Rillet link will hit a dead page until this is patched. Reply @MelvinBot implement this and I'll open a quick PR to fix that one line.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.61-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants