Skip to content

fix: only fall back to group policy for expense sign when no report exists - #99434

Merged
marcochavezf merged 4 commits into
Expensify:mainfrom
M00rish:fix/98715-negative-amount-self-dm-submit
Sep 3, 2026
Merged

fix: only fall back to group policy for expense sign when no report exists#99434
marcochavezf merged 4 commits into
Expensify:mainfrom
M00rish:fix/98715-negative-amount-self-dm-submit

Conversation

@M00rish

@M00rish M00rish commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #98715
PROPOSAL:
#98715 (comment)

Tests

  1. Log in with either brand new account or an old one(bug happened in both)
  2. Go Offline
  3. Go to Global Create >> Select "Create Expense" >> Create a Manual Expense $ 1
    4.. Choose the recipient as "You" (Personal account)
  4. Navigate to Self DM >> Select Submit to someone (Or in this case I select the option "submit to your friend")
  5. then enter any account email >> submit the expense
  6. Navigate to Spend >> Expenses
  7. verify amount is not negative.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen_Recording_20260901_174109_New.Expensify.mp4
Android: mWeb Chrome
android.webm
iOS: Native
ios.webm
iOS: mWeb Safari
iosweb.webm
MacOS: Chrome / Safari
web1.webm

M00rish and others added 3 commits August 29, 2026 23:55
@M00rish
Merge branch 'Expensify:main' into fix/98715-negative-amount-self-dm-…
b15fc05 
…submit
@M00rish
Merge branch 'Expensify:main' into fix/98715-negative-amount-self-dm-…
210c7fb 
…submit
@M00rish
fix(tests): update CreateDraftTransaction categorize expectation for …
0a2a181 
…gated expense-sign

SelfDM report is type=chat/not expense, so with the isEmptyObject(report) gate
(ReportUtils:5073 / TotalCell:55) isGroupPolicy fallback is ignored. Draft amount
is now display-signed (+5000) not storage-negated, matching real isGroupPolicy(undefined)=false and fixing multi-WS P2P sign flip.
@M00rish
M00rish marked this pull request as ready for review September 1, 2026 21:31
@M00rish
M00rish requested review from a team as code owners September 1, 2026 21:31
@melvin-bot
melvin-bot Bot requested review from brunovjk and garrettmknight and removed request for a team September 1, 2026 21:31
@melvin-bot

melvin-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

garrettmknight
garrettmknight approved these changes Sep 2, 2026
View reviewed changes

@garrettmknight garrettmknight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a product perspective.

@brunovjk

brunovjk commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Uploading 99434_android_native.mov…

Android: mWeb Chrome

Uploading 99434_android_web.mov…

iOS: HybridApp
99434_ios_native.mov
iOS: mWeb Safari

Uploading 99434_ios_web.mov…

MacOS: Chrome / Safari
99434_web_chrome.mov

brunovjk
brunovjk approved these changes Sep 2, 2026
View reviewed changes

@brunovjk brunovjk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot
melvin-bot Bot requested a review from marcochavezf September 2, 2026 14:53
@marcochavezf
marcochavezf merged commit 3c6fb6c into Expensify:main Sep 3, 2026
38 of 40 checks passed
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99434.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3c6fb6c-701868e-fba942fdf528daa0d878d5478fb15b4425b2c198/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3c6fb6c-701868e-d998f1ce0247663d07ffd3f0b02eaf18841d0026/index.html
Android iOS
Web 🕸️
https://99434.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify OSBotify mentioned this pull request Sep 7, 2026
Closed
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@MelvinBot

MelvinBot commented Sep 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR, so I did not create a docs PR.

This is an internal sign-convention bug fix, not a behavior or feature change that the help site documents.

Why I concluded that

What changed: both src/components/TransactionItemRow/DataCells/TotalCell.tsx:55 and src/libs/ReportUtils.ts:5073 now only fall back to the group-policy check when no report exists. That stops an unreported expense from being treated as an expense-report expense, which is what made the amount render negative while offline.

Net user-facing effect: the amount displays correctly (positive) instead of incorrectly (negative). The corrected state is what the help site already implies, so there is nothing to add, remove, or reword.

Docs I checked in docs/articles:

  • No article mentions "Self DM", "Submit to someone", or the unreported-expense amount sign.
  • The three hits for "negative amount" are unrelated: Send-and-Pay-Invoices.md, Connect-To-QuickBooks-Desktop.md, and ONL691-Export-Error.md.
  • No article documents how amount signs are rendered on the Expenses page, so no page describes the old buggy output.

Other checks: no new or renamed UI labels, tabs, settings, or buttons; no new workflow or setting; no copy changes. The third file changed is a unit-test assertion.

@M00rish, please confirm you agree that no help site update is needed here. If you think an article should call out expense amount display, reply with @MelvinBot and the article you have in mind, and I will create the draft PR.

view run · view recording

@m-natarajan

m-natarajan commented Sep 7, 2026

Copy link
Copy Markdown

@M00rish @brunovjk No QA steps, Do we have to validate the QA steps?

@brunovjk

brunovjk commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

@M00rish @brunovjk No QA steps, Do we have to validate the QA steps?

They are the same as the Tests; @marcochavezf, could please you update the PR description? Thanks.

@M00rish

M00rish commented Sep 8, 2026

Copy link
Copy Markdown
Contributor Author

description updated

@melvin-bot melvin-bot Bot mentioned this pull request Sep 8, 2026
Closed
7 tasks
@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettmknight garrettmknight garrettmknight approved these changes
@marcochavezf marcochavezf marcochavezf approved these changes
+1 more reviewer
@brunovjk brunovjk brunovjk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@M00rish M00rish

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@M00rish @brunovjk @OSBotify @MelvinBot @m-natarajan @garrettmknight @marcochavezf