CompactAvatar + multi-select rows by jmusial · Pull Request #99421 · Expensify/App

jmusial · 2026-08-25T12:02:05Z

Explanation of Change

New CompactAvatar primitive, replaces four hand-rolled copies.
MultiSelectListItem + UserSelectionListItem migrated to it, plus ListItemComposed.Title/.Subtitle
item-cloning replaced by a real leftElement prop on BaseSelectListItem.
Suggesters split into folders (MentionSuggestions, EmojiSuggestions). Row renderers extracted from useCallback into components, mention rows now use CompactAvatar.

Fixed Issues

$ #98360
PROPOSAL:

Tests

Scenario 1: Mention suggestion

Open app, open any chat report.
Type @ in the composer, then a couple of letters matching a member.
Verify each row shows: round avatar on the left, bold display name, grey @ handle after it.
Verify the matched prefix is highlighted in both the name and the handle.
Type @ he and verify the @ here row shows a green megaphone icon.
Verify selecting a row still inserts the mention.

Scenario 2: Multi select row

Navigate to Spend -> Filters -> Workspace.
Verify each row shows the workspace avatar on the left with a checkbox.
Navigate to Spend -> Filters -> Status .
Verify rows render text-only at the compact row height.
Toggle several rows in both lists and verify selection state applies.

Offline tests

Same as tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-09-02.at.14.54.48.mov

Android: mWeb Chrome

Screen.Recording.2026-09-02.at.14.54.10.mov

iOS: Native

Screen.Recording.2026-09-02.at.14.47.49.mov

iOS: mWeb Safari

Screen.Recording.2026-09-02.at.14.48.54.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-02.at.14.37.22.mov

codecov · 2026-08-25T12:06:23Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...omponents/EmojiSuggestions/EmojiSuggestionItem.tsx	`100.00% <100.00%> (ø)`
...nents/MentionSuggestions/MentionSuggestionItem.tsx	`100.00% <100.00%> (ø)`
...ents/SelectionList/ListItem/BaseSelectListItem.tsx	`100.00% <100.00%> (ø)`
...nts/SelectionList/ListItem/MultiSelectListItem.tsx	`100.00% <100.00%> (+31.25%)`	⬆️
...s/SelectionList/ListItem/UserSelectionListItem.tsx	`100.00% <100.00%> (+5.00%)`	⬆️
...omponents/SelectionList/ListItemComposed/index.tsx	`100.00% <ø> (ø)`
...tItemComposed/primitives/ListItemCompactAvatar.tsx	`100.00% <100.00%> (ø)`
...nbox/report/ReportActionCompose/ComposerContext.ts	`95.65% <ø> (ø)`
...x/report/ReportActionCompose/SuggestionMention.tsx	`80.83% <ø> (ø)`
src/styles/index.ts	`64.03% <ø> (ø)`
... and 2 more
... and 46 files with indirect coverage changes

jmusial · 2026-09-02T11:53:12Z

@codex review

chatgpt-codex-connector · 2026-09-02T11:57:41Z

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 5281709fcc

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-09-02T12:57:09Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dylanexpensify

good from a product perspective 👍

jmusial · 2026-09-04T08:29:33Z

@truph01 kind bump

truph01 · 2026-09-04T08:46:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-09-04.at.15.45.35.mov

Android: mWeb Chrome

Screen.Recording.2026-09-04.at.15.42.44.mov

iOS: HybridApp

Screen.Recording.2026-09-04.at.15.44.57.mov

iOS: mWeb Safari

Screen.Recording.2026-09-04.at.15.43.27.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-04.at.15.39.21.mov

Screen.Recording.2026-09-04.at.15.41.09.mov

truph01 · 2026-09-04T08:46:29Z

@jmusial Could you fix the typecheck issue?

jmusial · 2026-09-04T11:00:52Z

@jmusial Could you fix the typecheck issue?

Sure, missed that sorry :(

EDIT: updated

roryabraham · 2026-09-04T15:18:35Z

+    prefix: string;
+
+    /** Stores user's preferred skin tone */
+    preferredSkinToneIndex: number;


NAB: I'm wondering if this should be a normal prop or if leaf nodes should subscribe directly. I think as useOnyx becomes more lightweight/efficient it will be increasingly a best practice to bring subscriptions lower in the tree so that only the leaves that need it re-render on changes, rather than larger subtrees.

roryabraham · 2026-09-04T15:22:56Z

+    /** Show that we can use large mention picker.
+     * Depending on available space and whether the input is expanded, we can have a small or large mention suggester.
+     * When this value is false, the suggester will have a height of 2.5 items. When this value is true, the height can be up to 5 items.  */
+    isMentionPickerLarge: boolean;


This is a configuration prop that survived. NAB since AutoCompleteSuggestions is not in-scope for this PR.

roryabraham · 2026-09-04T15:23:19Z

+    /** Measures the parent container's position and dimensions. Also add cursor coordinates */
+    measureParentContainerAndReportCursor: (callback: MeasureParentContainerAndCursorCallback) => void;
+
+    /** Reset the emoji suggestions */


Suggested change

/** Reset the emoji suggestions */

/** Reset the mention suggestions */

right?

this is the only thing I considered blocking on, but I won't since it's just a comment. @jmusial consider opening a quick follow-up.

I'll add it to next PR for this decomp, draf already here, so it shouldn't take too long

github-actions · 2026-09-04T15:31:39Z

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-04T15:36:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-04T15:37:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99421.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6ff03b6-2b74695-8b363463d7cb4974e0d5a8ff4d87122de174535a/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6ff03b6-2b74695-94ec725d6566d64a57b80a5acd6ba3b447d97dab/index.html

Web 🕸️
https://99421.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-07T11:02:25Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.73-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

MelvinBot · 2026-09-07T11:04:48Z

🤖 No help site changes are required for this PR, so I did not create a draft docs PR.

This is an internal component refactor with no change to what a user sees or does.

Why I reached that conclusion

What the PR changes: all 21 files are src/components/*, src/pages/inbox/report/ReportActionCompose/*, src/styles/index.ts, and tests/unit/*.

A new ListItemCompactAvatar primitive replaces four hand-rolled avatar copies.
MultiSelectListItem and UserSelectionListItem now use that primitive.
BaseSelectListItem gains a real leftElement prop, replacing item-cloning.
MentionSuggestions and EmojiSuggestions move into folders, with row renderers pulled out of useCallback into components.

What it does not change:

No copy. No file under src/languages/ is touched, and the diff adds no user-facing strings.
No feature, setting, or navigation change. No new or renamed menu item, tab, toggle, or button — so no naming, label, or capitalization in App/docs/articles goes stale.
No behavior change. The linked issue, [Due for payment 2026-09-16] [SelectionList ListItem] PR 3 — CompactAvatar + multi-select rows #98360 ("[SelectionList ListItem] PR 3 — CompactAvatar + multi-select rows"), scopes this as refactor work. The test steps in the PR body are all "verify each row still shows…" regression checks, not steps for something new.

Help site check: the mention suggestion list and multi-select filter rows this PR touches are UI plumbing that App/docs/articles describes only at the level of "type @ to mention someone" and "filter your expenses." That guidance stays accurate, because both flows look and behave the same after this PR.

I reviewed docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md before deciding — but since there is nothing new to document and nothing existing that became wrong, applying them would mean editing articles with no reason to change.

If you disagree, tell me which flow you think a customer would notice differently after this PR and I'll draft the article update for it.

You asked me to close with the line below. There is no help site PR to link, because no docs change is needed — so there is nothing for you to mark Ready for review. I'm including the line as requested:

@jmusial, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

view run · view recording

OSBotify · 2026-09-08T19:01:56Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

CompactAvatar + multi-select rows

d75a23e

melvin-bot Bot assigned jmusial Aug 25, 2026

Merge branch 'main' into chore/compact-avatar-and-multi-select-rows

e7108cf

MelvinBot mentioned this pull request Sep 1, 2026

[Tracking] Decompose Avatar component #95596

Closed

jmusial added 2 commits September 1, 2026 13:21

Merge branch 'main' into chore/compact-avatar-and-multi-select-rows

8b34242

Merge branch 'main' into chore/compact-avatar-and-multi-select-rows

5281709

self review

daf8893

jmusial marked this pull request as ready for review September 2, 2026 12:57

jmusial requested review from a team as code owners September 2, 2026 12:57

melvin-bot Bot requested review from dylanexpensify and truph01 and removed request for a team September 2, 2026 12:57

melvin-bot Bot removed the request for review from a team September 2, 2026 12:57

github-actions Bot reviewed Sep 2, 2026

View reviewed changes

Comment thread src/components/SelectionList/ListItem/UserSelectionListItem.tsx Outdated

github-actions Bot reviewed Sep 2, 2026

View reviewed changes

Comment thread src/components/MentionSuggestions/MentionSuggestionItem.tsx

jmusial added 2 commits September 2, 2026 15:15

fix consistency comments

cc1fda2

Merge branch 'main' into chore/compact-avatar-and-multi-select-rows

f643670

dylanexpensify previously approved these changes Sep 3, 2026

View reviewed changes

jmusial added 2 commits September 4, 2026 13:01

Merge branch 'main' into chore/compact-avatar-and-multi-select-rows

e53da70

fix ts

ba50bf5

jmusial dismissed dylanexpensify’s stale review via ba50bf5 September 4, 2026 11:04

truph01 approved these changes Sep 4, 2026

View reviewed changes

melvin-bot Bot requested a review from roryabraham September 4, 2026 11:12

roryabraham approved these changes Sep 4, 2026

View reviewed changes

roryabraham merged commit 6ff03b6 into Expensify:main Sep 4, 2026
38 of 40 checks passed

OSBotify mentioned this pull request Sep 7, 2026

Deploy Checklist: New Expensify 2026-09-07 #100479

Closed

This was referenced Sep 7, 2026

[Due for payment 2026-09-16] [SelectionList ListItem] PR 3 — CompactAvatar + multi-select rows #98360

Closed

[$1000] [Tracking] SelectionList ListItem - Composition over Configuration #97971

Open

	/** Reset the emoji suggestions */
	/** Reset the mention suggestions */

Conversation

jmusial commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Scenario 1: Mention suggestion

Scenario 2: Multi select row

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Aug 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jmusial commented Sep 2, 2026

Uh oh!

chatgpt-codex-connector Bot commented Sep 2, 2026

Uh oh!

melvin-bot Bot commented Sep 2, 2026

Uh oh!

Uh oh!

Uh oh!

dylanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

jmusial commented Sep 4, 2026

Uh oh!

truph01 commented Sep 4, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Sep 4, 2026

Uh oh!

jmusial commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roryabraham Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

roryabraham Sep 4, 2026

Choose a reason for hiding this comment

Uh oh!

jmusial Sep 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

OSBotify commented Sep 4, 2026

Uh oh!

github-actions Bot commented Sep 4, 2026

Uh oh!

OSBotify commented Sep 7, 2026

Uh oh!

MelvinBot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jmusial commented Aug 25, 2026 •

edited

Loading

codecov Bot commented Aug 25, 2026 •

edited by github-actions Bot

Loading

jmusial commented Sep 4, 2026 •

edited

Loading

MelvinBot commented Sep 7, 2026 •

edited

Loading