Skip to content

[No QA] Docs updates for E/A#96496 Replace new-expense highlighting with Expense added toast - #99233

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsExpenseAddedGrowl
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsExpenseAddedGrowl

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site docs update to match the behavior change in #96496.

That PR removes the row highlighting of newly created expenses in the Spend tab tables and instead shows an Expense added confirmation with a View button after an expense is created.

The Getting Started with the Spend Page article still described the old behavior under How to add a new expense to the table ("Its row is briefly highlighted as new."). This updates that line to describe the new Expense added confirmation and View button instead.

Verified against the current UI: creating an expense shows a green Expense added toast with a View action, and the new row is no longer highlighted.

Fixed Issues

Docs follow-up for #96496

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validate your changes worked.

  • Verify that no errors appear in the JS console

Offline tests

N/A — documentation-only change.

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

@mhawryluk, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…ation

Co-authored-by: Marcin Hawryluk <mhawryluk@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team August 22, 2026 03:47
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 22, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#96496 Replace new-expense highlighting with Expense added toast [No QA] Docs updates for E/A#96496 Replace new-expense highlighting with Expense added toast Aug 22, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://b34570c2.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott marked this pull request as ready for review August 28, 2026 03:46
@stephanieelliott
stephanieelliott self-requested a review as a code owner August 28, 2026 03:46
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @brianlee-expensify

@melvin-bot
melvin-bot Bot requested review from brianlee-expensify and removed request for a team August 28, 2026 03:47
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

@brianlee-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2213defac3

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@github-actions

Copy link
Copy Markdown
Contributor

test placeholder line one

@github-actions

Copy link
Copy Markdown
Contributor

line one
line two
line three

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This is a minimal, well-scoped documentation-only change. It updates a single line in Getting-Started-with-the-Spend-Page.md under the How to add a new expense to the table section to match the behavior change in the linked App PR (E/A 96496). The old text described row highlighting for newly created expenses; the new text describes the Expense added confirmation and its View button. The change is accurate to the current UI and touches nothing outside the proposed diff.

Scores Summary

  • Readability: 9/10 - The replacement sentence is clear, concise, and action-oriented. It fits cleanly into the existing bullet list and describes both the confirmation and the follow-up action a user can take.
  • AI Readiness: 8/10 - The change reinforces a task-based section with UI-exact terminology (Expense added, View), aiding semantic retrieval. Scope is one line, so no metadata or heading structure is affected. No AI-readiness regressions introduced.
  • Style Compliance: 9/10 - Follows the Button Naming Standards in HELPSITE_NAMING_CONVENTIONS.md: UI elements are bolded, use Sentence case, are not wrapped in quotation marks, and match the product UI exactly. No prohibited or vague navigation language.

Key Findings

  • The single-line change is accurate, well-formatted, and consistent with the naming conventions (bolded UI labels, exact casing).
  • It correctly removes now-obsolete behavior (row highlighting) and replaces it with the current confirmation toast and View action.
  • Minor observation: the surrounding section list describes outcomes rather than sequential numbered steps. This predates the PR and is outside the diff, so it is not scored here, but a future pass could align it with the Step Formatting Standard in HELP_AUTHORING_GUIDELINES.md Section 5.

Recommendations

  • No blocking changes required. The diff is compliant and ready.
  • Optional (out of scope): convert the outcome list in this section into sequential numbered steps per HELP_AUTHORING_GUIDELINES.md Section 5.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md - Single-line update, compliant and accurate. Approved.

Note: The change is a single line; no additional inline comments were necessary.

@stephanieelliott
stephanieelliott requested a review from a team August 28, 2026 04:11
@melvin-bot
melvin-bot Bot removed the request for review from a team August 28, 2026 04:11
@brianlee-expensify

Copy link
Copy Markdown
Contributor

@stephanieelliott do you need me to approve this, or you're all set here?

@mhawryluk

Copy link
Copy Markdown
Member

the PR has been reverted, so I think we should wait with merging

@stephanieelliott

Copy link
Copy Markdown
Contributor

A new Helpdot draft will be opened when the replacement PR hits staging, so we can close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants