Repository navigation
Conversation
…ation Co-authored-by: Marcin Hawryluk <mhawryluk@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://b34570c2.helpdot.pages.dev ⚡️ Updated articles: |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@brianlee-expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2213defac3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
test placeholder line one |
|
line one |
|
HelpDot Documentation Review Overall Assessment Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: The change is a single line; no additional inline comments were necessary. |
|
@stephanieelliott do you need me to approve this, or you're all set here? |
|
the PR has been reverted, so I think we should wait with merging |
|
A new Helpdot draft will be opened when the replacement PR hits staging, so we can close this! |
Explanation of Change
Help site docs update to match the behavior change in #96496.
That PR removes the row highlighting of newly created expenses in the Spend tab tables and instead shows an Expense added confirmation with a View button after an expense is created.
The Getting Started with the Spend Page article still described the old behavior under How to add a new expense to the table ("Its row is briefly highlighted as new."). This updates that line to describe the new Expense added confirmation and View button instead.
Verified against the current UI: creating an expense shows a green Expense added toast with a View action, and the new row is no longer highlighted.
Fixed Issues
Docs follow-up for #96496
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validate your changes worked.
Offline tests
N/A — documentation-only change.
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
@mhawryluk, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.