[Payment due @Krishna2323] [No QA] Add receipt prepare span and capture attributes to scan telemetry by VickyStash · Pull Request #99175 · Expensify/App

VickyStash · 2026-08-21T10:42:43Z

Explanation of Change

Add receipt prepare span and capture attributes to scan telemetry

New ManualReceiptPrepare span covers the previously un-instrumented gap between capture end and scan processing start (receipt adoption, buildReceiptFiles), closing the ManualShutterToConfirmation chain.
Stamp capture_method (takePhoto vs takeSnapshot), flash_used, and photo dimensions on ManualReceiptCapture to explain the native capture tail.

Fixed Issues

$ #99773
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

VickyStash · 2026-08-21T10:44:41Z

@MelvinBot review

codecov · 2026-08-21T10:46:17Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`92.59% <ø> (-2.27%)`	⬇️
.../step/IOURequestStepOdometerImage/index.native.tsx	`0.00% <ø> (ø)`
...request/step/IOURequestStepOdometerImage/index.tsx	`0.00% <ø> (ø)`
.../IOURequestStepScan/components/ScanEditReceipt.tsx	`89.65% <ø> (ø)`
...equestStepScan/components/ScanSkipConfirmation.tsx	`78.76% <ø> (+0.57%)`	⬆️
...equestStepScan/components/Camera/CameraCapture.tsx	`0.00% <0.00%> (ø)`
...p/IOURequestStepScan/utils/startScanProcessSpan.ts	`0.00% <0.00%> (ø)`
...OURequestStepScan/utils/startReceiptPrepareSpan.ts	`0.00% <0.00%> (ø)`
...RequestStepScan/components/Camera/index.native.tsx	`68.42% <0.00%> (-3.81%)`	⬇️
...st/step/IOURequestStepScan/captureReceipt/index.ts	`12.50% <16.66%> (-4.17%)`	⬇️
... and 676 files with indirect coverage changes

MelvinBot · 2026-08-21T10:49:23Z

Review

👍 Looks good. The new ManualReceiptPrepare span and the extra ManualReceiptCapture attributes are correct and well-scoped. Span start/end/cancel are balanced on every path I traced. No blocking issues — a few optional nits below.

Span lifecycle trace (why it's balanced)

ManualReceiptPrepare — started after capture ends, closed when the scan process begins:

Web: started right before onCapture in CameraCapture.tsx:133
Native: started before ReceiptStorage.adopt in index.native.tsx:179
Ended in startScanProcessSpan.ts:9, which is the first call in both navigateFromReport (ScanFromReport) and navigateGlobalCreate (NavigateGlobalCreateContext) — so the gap it measures ends exactly when scan processing starts. ✅
Cancelled in all three cleanup paths (onUnmount, onFocusCleanup, maybeCancelShutterSpan), so an abandoned capture can't leak it. ✅
Correctly guarded by !isMultiScanEnabled at start; endSpan in startScanProcessSpan is a harmless no-op in multi-scan since the span was never started. ✅

capture_method / flash_used — the isFlashUsed || isInLandscapeMode ? 'photo' : 'snapshot' mapping matches captureReceipt/index.ts (takePhoto when useFlash || isInLandscapeMode, else takeSnapshot). ✅

Import swap — endSpan → endSpanWithAttributes in index.native.tsx is clean; no leftover endSpan references in the file. ✅

Optional nits (non-blocking):

Duplicated capture-method logic. The useFlash || isInLandscapeMode decision now lives in both captureReceipt/index.ts:5 and index.native.tsx:162. If one branch ever changes, the telemetry label silently drifts from the actual capture call. Consider deriving the label from a shared helper so they can't diverge.
Label wording. The attribute values are 'photo'/'snapshot' while the PR description says takePhoto/takeSnapshot. Cosmetic, but worth confirming any Sentry dashboard/query you'll build expects photo/snapshot.
Web/native asymmetry. capture_method, flash_used, and photo_width/photo_height are only stamped on native ManualReceiptCapture — web still gets just platform. Presumably intentional (web uses getScreenshot), just flagging it so the dashboard doesn't treat those attributes as universal.

Note: this is a static review only. The changed code (camera capture spans) can't be meaningfully exercised in a headless web environment since it requires a real camera device — verification is best done by inspecting the emitted spans in Sentry on a real browser/device.

view run

melvin-bot · 2026-08-21T11:57:38Z

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d61713131a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

OlimpiaZurek · 2026-08-25T07:50:15Z

Left one minor comment, besides that LGTM.

VickyStash · 2026-08-26T11:36:38Z

^^ @Krishna2323 kind bump here

Krishna2323 · 2026-08-26T11:43:44Z

@VickyStash sorry for delay, I'll start reviewing within an hour.

Krishna2323 · 2026-08-26T13:21:44Z

+                    startSpan(CONST.TELEMETRY.SPAN_RECEIPT_PREPARE, {
+                        name: CONST.TELEMETRY.SPAN_RECEIPT_PREPARE,
+                        op: CONST.TELEMETRY.SPAN_RECEIPT_PREPARE,
+                        parentSpan: getSpan(CONST.TELEMETRY.SPAN_SHUTTER_TO_CONFIRMATION),
+                        attributes: {[CONST.TELEMETRY.ATTRIBUTE_PLATFORM]: 'native'},
+                    });


This block is duplicated in CameraCapture.tsx:133, with only the platform attribute being different. Could we extract a startReceiptPrepareSpan(platform) helper next to startScanProcessSpan, so the span start/end logic stays in the same place? Also, lets use constants for native and web.

Added startReceiptPrepareSpan util function and reused our getPlatform util function: b28dac3

Krishna2323 · 2026-08-26T17:59:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

android_hybrid.mp4

android_mWeb.mp4

Krishna2323 · 2026-08-26T18:09:33Z

+        name: CONST.TELEMETRY.SPAN_RECEIPT_PREPARE,
+        op: CONST.TELEMETRY.SPAN_RECEIPT_PREPARE,
+        parentSpan: getSpan(CONST.TELEMETRY.SPAN_SHUTTER_TO_CONFIRMATION),
+        attributes: {[CONST.TELEMETRY.ATTRIBUTE_PLATFORM]: getPlatform()},


@VickyStash getPlatform() returns ios/android/mobileweb, but sibling scan spans stamp native/web. Filtering the chain on platform:native will miss this span, pass the platform string in instead? We already have constants for native and web.

We already have constants for native and web

For web we have CONST.PLATFORM.WEB, but for native, only the capitalized Native string exists as CONST.OS.NATIVE.
Both consts are used in typing (ex: typeof CONST.PLATFORM), so we shouldn't adjust/change it here I think.

Maybe we can add a new TELEMETRY.SPAN_PLATFORM with native and reuse it across spans and siblings to maintain consistency? @Krishna2323 WDYT?

@VickyStash yes please, let's create new ones.

Krishna2323

LGTM!

melvin-bot · 2026-08-27T12:06:46Z

🎯 @Krishna2323, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

github-actions · 2026-08-28T23:29:36Z

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-08-28T23:31:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-08-28T23:33:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99175.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-33cf6dd-848d813-f11b9929b6332d3cf206ba00faaf569c4247c0b5/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-33cf6dd-848d813-a32a42509ec70de36da52a353575da803bd6d9f5/index.html

Web 🕸️
https://99175.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-31T18:56:49Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.65-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-08-31T19:00:41Z

No help site changes are required for this PR. I did not create a draft PR.

Why: every change is internal Sentry performance instrumentation. Nothing in the diff alters what a user sees or does.

New ManualReceiptPrepare span plus start/end/cancel calls across the scan flow — timing data only, no UI.
New capture_method, flash_used, photo_width, photo_height attributes on ManualReceiptCapture — span metadata sent to Sentry.
New CAPTURE_METHOD and SPAN_PLATFORM constants replacing inline 'native' / 'web' strings — a refactor with identical values.
shouldTakePhoto extracted from captureReceipt — the takePhoto vs takeSnapshot decision is byte-for-byte the same as before.

No user-facing copy, no button or label text, no settings, no new or changed feature behavior. App/docs/articles documents product behavior for customers, so there is nothing here to document. The PR is also marked [No QA], consistent with there being no observable change.

The receipt-scanning articles stay accurate as written — Create an expense and Attach and edit receipts on expenses.

If a future PR in this telemetry series changes the camera UI — for instance the flash control, landscape capture, or the multi-scan flow — that one would need a docs review.

@VickyStash, there is no help site PR to link because no docs changes are needed. If you disagree and want an article updated, reply with what should change and I'll open the draft PR.

view run

OSBotify · 2026-09-02T00:18:28Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.65-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Add receipt prepare span and capture attributes to scan telemetry

d617131

melvin-bot Bot assigned VickyStash Aug 21, 2026

VickyStash marked this pull request as ready for review August 21, 2026 11:57

VickyStash requested review from a team as code owners August 21, 2026 11:57

melvin-bot Bot requested review from Krishna2323 and removed request for a team August 21, 2026 11:57

melvin-bot Bot requested review from heyjennahay and removed request for a team August 21, 2026 11:57

VickyStash mentioned this pull request Aug 21, 2026

[Metrics] ManualShutterToConfirmation - Optimize "Confirm details" page rendering after receipt capture #83503

Open

github-actions Bot reviewed Aug 21, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepScan/components/Camera/index.native.tsx Outdated

chatgpt-codex-connector Bot reviewed Aug 21, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepScan/components/Camera/index.native.tsx Outdated

VickyStash added 2 commits August 21, 2026 15:36

Cancel receipt prepare span in flows that skip the confirmation page

7a5b6bb

Add CAPTURE_METHOD consts

5f71070

Julesssss previously approved these changes Aug 24, 2026

View reviewed changes

OlimpiaZurek reviewed Aug 25, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepScan/components/Camera/index.native.tsx Outdated

OlimpiaZurek approved these changes Aug 25, 2026

View reviewed changes

Extract shouldTakePhoto helper

f043cc4

VickyStash dismissed Julesssss’s stale review via f043cc4 August 25, 2026 09:51

Krishna2323 suggested changes Aug 26, 2026

View reviewed changes

Add startReceiptPrepareSpan util function

b28dac3

Krishna2323 reviewed Aug 26, 2026

View reviewed changes

Add CONST.TELEMETRY.SPAN_PLATFORM

d275a2f

Krishna2323 approved these changes Aug 27, 2026

View reviewed changes

melvin-bot Bot changed the title ~~[No QA] Add receipt prepare span and capture attributes to scan telemetry~~ [Payment due @Krishna2323] [No QA] Add receipt prepare span and capture attributes to scan telemetry Aug 27, 2026

cristipaval mentioned this pull request Aug 28, 2026

[Due for payment 2026-09-09] [Metrics] Add ManualReceiptPrepare span and capture attributes to scan telemetry #99773

Closed

cristipaval approved these changes Aug 28, 2026

View reviewed changes

Julesssss approved these changes Aug 28, 2026

View reviewed changes

Julesssss merged commit 33cf6dd into Expensify:main Aug 28, 2026
39 of 42 checks passed

OSBotify mentioned this pull request Aug 31, 2026

Deploy Checklist: New Expensify 2026-08-31 #99948

Closed

75 tasks

Conversation

VickyStash commented Aug 21, 2026 • edited by cristipaval Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Uh oh!

VickyStash commented Aug 21, 2026

Uh oh!

codecov Bot commented Aug 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MelvinBot commented Aug 21, 2026

Review

Uh oh!

melvin-bot Bot commented Aug 21, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

OlimpiaZurek commented Aug 25, 2026

Uh oh!

VickyStash commented Aug 26, 2026

Uh oh!

Krishna2323 commented Aug 26, 2026

Uh oh!

Krishna2323 Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

VickyStash Aug 26, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

VickyStash Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

VickyStash Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Aug 27, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026

Uh oh!

OSBotify commented Aug 28, 2026

Uh oh!

github-actions Bot commented Aug 28, 2026

Uh oh!

OSBotify commented Aug 31, 2026

Uh oh!

MelvinBot commented Aug 31, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

VickyStash commented Aug 21, 2026 •

edited by cristipaval

Loading

codecov Bot commented Aug 21, 2026 •

edited by github-actions Bot

Loading

Krishna2323 commented Aug 26, 2026 •

edited

Loading

Krishna2323 Aug 26, 2026 •

edited

Loading