Fix: Group horizontal scroll sync

[Krishna2323]

Explanation of Change

Fixed Issues

$ #98978
PROPOSAL:

Tests

Setup

1. Open the web app at a large screen width.
2. Go to Spend and select group by: From from display filter popover.
3. Enable enough columns to make the table overflow horizontally.

Core fix

4. Expand a group and confirm the sub-header is no longer squeezed/truncated.
5. Scroll horizontally and verify the header and rows stay aligned with no drift/delay.
6. Confirm there is only one scrollbar under the rows.
7. Scroll fully left/right and confirm both reach the edges together.

Sticky header

8. Scroll down until the group header sticks. Verify it keeps the same horizontal offset as the rows.
9. Scroll past the group and confirm the next group's header doesn't jump back to the left.

Re-render/recycling

10. Scroll horizontally, collapse/expand the group, and verify the offset is preserved.
11. Scroll far enough for the group to be recycled, then return and verify the offset is preserved without flashing to 0.

Other cases

12. Scroll two groups independently and confirm their offsets don't affect each other.
13. Change the query and confirm the new results start at the left edge.
14. Disable columns so the table fits and confirm there is no scrollbar/regression.
15. Verify group header click and select-all still work while horizontally scrolled.
16. Test an ungrouped type:expense search and confirm existing horizontal scrolling/offset behavior is unchanged.

• Verify that no errors appear in the JS console

Offline tests

• Same as tests

QA Steps

• Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android_hybrid.mp4

Android: mWeb Chrome

android_mWeb.mp4

iOS: Native

ios_hybrid.mp4

iOS: mWeb Safari

ios_mWeb.mp4

MacOS: Chrome / Safari

Monosnap.screencast.2026-09-08.18-43-57.mp4

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Search/ExpenseGroupedSearchView.tsx	59.78% <100.00%> (+0.44%)	⬆️
...earch/SearchList/ListItem/GroupChildrenContent.tsx	0.00% <ø> (ø)
...archList/ListItem/TransactionGroupListExpanded.tsx	67.18% <100.00%> (-1.00%)	⬇️
src/components/Search/SearchList/ListItem/types.ts	100.00% <ø> (ø)
...ch/hooks/useSyncedHorizontalScroll/index.native.ts	100.00% <100.00%> (ø)
...ponents/Search/SearchList/ListItem/GroupHeader.tsx	78.76% <88.88%> (+2.09%)	⬆️
src/libs/SearchUIUtils.ts	72.17% <12.50%> (+0.46%)	⬆️
...ts/Search/hooks/useSyncedHorizontalScroll/store.ts	0.00% <0.00%> (ø)
...ts/Search/hooks/useSyncedHorizontalScroll/index.ts	0.00% <0.00%> (ø)
... and 272 files with indirect coverage changes

[melvin-bot]

@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Krishna2323]

@Expensify/design, I'd like your review before moving forward. This isn't a regular scroll issue. The header and children use two separate containers to keep the group header sticky, and the only way I found to fix this is to sync the scroll position between them.

The transaction rows own the scroll, and the column header follows them, so they stay aligned, but only the rows show a scrollbar. This also means you can't drag or trackpad-scroll horizontally while hovering over the header row itself, you have to be over the rows.

Everything below 1024px and on native is unaffected since the header already lives inside the same scroller as the rows.

Let me know if this trade-off is acceptable or if you'd rather I explore something else.

Monosnap.screencast.2026-09-08.18-43-57.mp4

[dannymcclain]

The transaction rows own the scroll, and the column header follows them, so they stay aligned, but only the rows show a scrollbar. This also means you can't drag or trackpad-scroll horizontally while hovering over the header row itself, you have to be over the rows.

Personally that feels fine to me since the transaction rows are the only things that have horizontally scrolling content, but I'd love to get thoughts from the rest of the team as well.

[shawnborton]

Yeah, that seems to makes sense to me too.

[Krishna2323]

@cretadn22 this is ready for your review.

[Krishna2323]

@cretadn22 friendly bump

[cretadn22]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-09-10.at.14.03.50.mov

Android: mWeb Chrome

Screen.Recording.2026-09-10.at.14.00.33.mov

iOS: HybridApp

Screen.Recording.2026-09-10.at.14.03.05.mov

iOS: mWeb Safari

Screen.Recording.2026-09-10.at.13.58.59.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-10.at.13.56.34.mov

[github-actions]

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99107.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5ee2312-e0b1529-ae56cb37e3309e3a5e47bf53e83cb5d9431aaac4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5ee2312-e0b1529-f9310d66a422bf561287fdd27d819792c49bf584/index.html

Web 🕸️
https://99107.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.78-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 No help site changes are required for this PR, so I did not create a draft docs PR.

Why: This PR only fixes how the grouped Search table renders. It syncs the horizontal scroll offset between a group's sub-header and its expense rows, removes the duplicate scrollbar, and keeps the offset stable when a group is collapsed, re-expanded, or recycled. It changes no feature, setting, label, or user flow that the help site documents.

What I checked

The diff — all 12 changed files are rendering/layout internals plus tests:

• src/components/Search/hooks/useSyncedHorizontalScroll/* (new hook + store)
• src/components/Search/SearchList/ListItem/GroupHeader.tsx, GroupChildrenContent.tsx, TransactionGroupListExpanded.tsx, types.ts
• src/components/Search/ExpenseGroupedSearchView.tsx
• src/libs/SearchUIUtils.ts (getGroupColumnWidthFlags, getGroupTableScrollLayout)
• tests/ui/GroupHeaderTest.tsx, tests/unit/TransactionGroupListItemTest.tsx

No src/languages/* files were touched, so no user-facing copy changed. No new buttons, menu items, filters, or settings were added — Display > Group by and Display > Edit columns behave exactly as before.

The docs — I searched every article under docs/articles:

• grep -rni "horizontal scroll\|scrollbar" docs/articles → zero matches. The help site never documents table scroll behavior, so there is no existing statement that this fix makes stale.
• The articles that do cover grouping — Search-and-Download-Expenses.md, Getting-Started-with-the-Spend-Page.md, Accounting-Search-Shortcuts.md — describe how to apply Group by and which columns export. Both remain accurate.

Per HELP_AUTHORING_GUIDELINES.md, help articles document what a user needs to do to accomplish a task. A scroll-alignment bug fix restores the intended behavior rather than introducing a new one, so there is nothing new for a user to learn.

Since there is no docs PR to link, there is nothing to mark Ready for review. If you'd still like an article to call out that grouped tables scroll horizontally when you enable more columns than fit the screen, reply with @MelvinBot add a note about horizontal scrolling in grouped search results and I'll open the draft PR with the HelpDot label assigned to you.

---

view run · no recording available

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.78-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android