Fix company card export/details RHP background when opened from Members by MelvinBot · Pull Request #99056 · Expensify/App

MelvinBot · 2026-08-20T10:40:46Z

Explanation of Change

The company-card details and export RHP screens are dynamic routes that can be opened from more than one place (Members and Company cards). They were listed in WORKSPACE_TO_RHP, which is inverted (last-wins) into RHP_TO_WORKSPACE. Because COMPANY_CARDS is defined after MEMBERS, both dynamic screens inverted to Workspace_CompanyCards, and getMatchingFullScreenRoute consulted that map before the dynamic base-path branch. As a result, opening these RHPs from a member's profile and refreshing (or navigating in-app) resolved the background to Company cards instead of Members.

This PR removes the three dynamic-screen entries (DYNAMIC_COMPANY_CARD_DETAILS from both MEMBERS and COMPANY_CARDS, and DYNAMIC_COMPANY_CARD_EXPORT from COMPANY_CARDS) so the background is resolved from the actual URL by the dynamic base-path branch — the same pattern the file already documents for DYNAMIC_IMPORTED_MEMBERS_ROLE. The background now stays correct for every entry point (Members, Company cards, Expensify Card, Rillet card list). An explanatory comment was added so the entries aren't re-added.

Fixed Issues

$ #95303
PROPOSAL: #95303 (comment)

Tests

Same as #95303

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as #95303

PR Author Checklist

Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>

MelvinBot · 2026-08-20T10:49:53Z

🤖 Android testing blocked — could not exercise the test cases.

I couldn't run any of the three test steps because the required precondition can't be set up on this automated test account. This PR's tests need a workspace with a direct company-card feed, a card assigned to a member, and Sage Intacct connected — but creating the first company-card feed requires account validation.

Where it blocked: On a fresh account I completed onboarding, created a workspace, and enabled the Company cards feature. Opening Workspace → Company cards → Add cards immediately routed to a "This feature requires you to validate your account" screen asking for a 6‑digit security code emailed to the test account. That inbox isn't accessible to this run, so the flow can't proceed — and without a feed there's no assigned card or export screen to test.

Result per test step:

Step	Status
Members → member → card → export RHP background stays Members	⛔ Blocked (no feed/card)
Members → member → card details RHP background stays Members	⛔ Blocked (no feed/card)
Regression: Company cards → card → export RHP background stays Company cards	⛔ Blocked (no feed/card)

What I got through before the block

Drove the pre-started session from the post-login screen to Home, dismissed the notification-permission dialog, and completed the onboarding wizard ("Manage my team's expenses" → "11-50 employees" → enabled Company cards + Accounting), which auto-created a workspace.
Enabled the Company cards feature (confirmed it appeared in the workspace left-nav).
Tapped Add cards → hit the account-validation magic-code screen.

To verify this PR on Android, testing needs a pre-provisioned account that already has a direct feed + an assigned company card + Sage Intacct connected (magic-code validation can't be completed here). Alternatively, this is a navigation/route-resolution fix that is straightforward to verify on web with a URL refresh — happy to re-run on web, or on Android against a properly provisioned account, if you can point me at one.

view run

MelvinBot · 2026-08-20T11:01:57Z

🤖 Web testing blocked — could not exercise the test cases.

Same root blocker I hit on Android: this PR's tests need a workspace with a direct company-card feed + a card assigned to a member + Sage Intacct connected, and none of those preconditions can be established on the automated test account.

Where it blocked:

On a fresh account I drove to Home and created a workspace. Opening Company cards → Add cards (to create the first direct feed) immediately routed to a "Validate your account" 6‑digit magic-code screen. The code is emailed to an inbox this run can't access, so the feed can't be created — and without a feed there's no card to assign to a member and no export/details RHP to test.
I got further on the accounting side (enabled Accounting, upgraded to Control, reached the Sage Intacct setup wizard), but the wizard's next step triggered a full off-app navigation to help.expensify.com, which is a hard stop for the tester.

Result per test step:

Step	Status
Members → member → card → export RHP background stays Members after refresh	⛔ Blocked (no feed/card)
Members → member → card details RHP background stays Members after refresh	⛔ Blocked (no feed/card)
Regression: Company cards → card → export RHP background stays Company cards after refresh	⛔ Blocked (no feed + Sage Intacct wizard left app)

What I got through before the block

Drove the pre-started session from the post-signup "Join" screen to Home.
Created a workspace (account had none).
Company cards → Add cards → hit the account-validation magic-code wall.
Enabled Accounting → Sage Intacct → upgraded to Control → reached the Sage Intacct setup wizard, whose next step navigated off-app (help.expensify.com), ending the drive.

To verify this PR, testing needs a pre-provisioned account that already has a direct company-card feed, a card assigned to a member, and Sage Intacct connected — the magic-code account validation can't be cleared in this environment. If you can point me at such an account, I can re-run web or Android.

view run

melvin-bot · 2026-08-24T12:32:19Z

@ikevin127 @mjasikowski One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mjasikowski · 2026-08-24T12:32:38Z

@huult can you check and review this please?

huult · 2026-08-24T13:48:49Z

I will review this PR soon.

huult · 2026-08-25T03:30:57Z

@mjasikowski Please check off the author checklist and QA step

huult · 2026-08-25T03:31:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-08-25.at.11.51.02.mov

huult · 2026-08-25T04:42:38Z

@mjasikowski could you sync with main?

mjasikowski · 2026-08-25T06:10:19Z

@MelvinBot merge main

huult · 2026-08-25T06:13:57Z

@mjasikowski Please check off the author checklist and QA step

Could you check this one as well?

mjasikowski · 2026-08-25T06:21:09Z

@mjasikowski Please check off the author checklist and QA step

Could you check this one as well?

Yes, this is already done

…ortRhpBackground Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>

melvin-bot · 2026-08-25T06:23:18Z

@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

MelvinBot · 2026-08-25T06:23:25Z

🤖 Merged main into this branch — no conflicts. Pushed as 210b7436b02.

view run

MelvinBot · 2026-08-25T06:26:58Z

There's no code failure to fix here. The only failing check is Check independent approval (its Verify peer review step), which is the approval gate — it fails simply because the PR hasn't received an independent reviewer's approval yet. That clears on its own once someone approves; it isn't fixable by pushing to the branch.

Every actual CI check is green — tests (jobs 1–8), ESLint, Oxfmt, typecheck, React Compiler, Storybook, Bun tests, and all builds. The perf tests (branch-perf-tests / baseline-perf-tests) are still running and haven't failed.

So nothing to push — this PR just needs a reviewer approval to turn that last check green.

view run

huult

LGTM.

huult · 2026-08-25T06:59:49Z

-        SCREENS.WORKSPACE.DYNAMIC_COMPANY_CARD_DETAILS,
+        // For the same reason, the dynamic company-card details/export screens are NOT listed here (or under
+        // Company cards): they are shared by Members and Company cards, so their background must be resolved from
+        // the URL by the dynamic base-path branch, not pinned to a single central pane.


I don't think we need this comment. @mjasikowski, could you remove it?

@MelvinBot remove this comment:

// For the same reason, the dynamic company-card details/export screens are NOT listed here (or under // Company cards): they are shared by Members and Company cards, so their background must be resolved from // the URL by the dynamic base-path branch, not pinned to a single central pane.

Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>

MelvinBot · 2026-08-25T10:48:13Z

🤖 Removed the comment from WORKSPACE_TO_RHP.ts and pushed as fbc771d.

view run

MelvinBot · 2026-08-25T10:52:05Z

Still nothing to push here. The only failing check is Check independent approval (its Verify peer review step) — the approval gate. It fails only because the PR hasn't received an independent reviewer's approval yet, and it clears automatically once someone approves. There's no code failure behind it.

All actual CI checks are green (tests, ESLint, Oxfmt, typecheck, React Compiler, Storybook, Bun tests, builds); the perf tests are still running and haven't failed. This PR just needs a reviewer approval.

view run

github-actions · 2026-08-25T11:22:33Z

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-08-25T11:25:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-08-25T11:26:48Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99056.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-87ff05b-dcbf3cd-d91d38e1addb0e27e42acb5bcbd59ec255ff1a6d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-87ff05b-dcbf3cd-e1caa716561ace842703c505ecc283772c6b6543/index.html

Web 🕸️
https://99056.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-25T21:25:35Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.61-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-08-25T21:28:10Z

🤖 No help site changes required.

This PR is a navigation-routing bug fix. Its only change is to src/libs/Navigation/linkingConfig/RELATIONS/WORKSPACE_TO_RHP.ts, correcting which background pane resolves behind the company-card details and export RHP screens (Members vs Company cards) when opened from a member's profile and refreshed.

Nothing user-facing changes: the same screens open with the same content, buttons, and labels — only the underlying background is resolved from the URL instead of always defaulting to Company cards. App/docs/articles documents features and workflows, none of which are altered here, so there's nothing to add or update.

No draft PR was created.

view run

OSBotify · 2026-08-26T20:53:07Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.61-4 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Fix company card export/details RHP background on refresh from Members

6cce0e6

Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>

MelvinBot assigned mjasikowski Aug 20, 2026

melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Aug 20, 2026

MelvinBot requested a review from a team August 20, 2026 10:40

MelvinBot mentioned this pull request Aug 20, 2026

[Due for payment 2026-09-02] Company card - Background changes to Company card after refreshing export RHP on Members #95303

Closed

7 tasks

mjasikowski requested a review from huult August 24, 2026 12:32

mjasikowski marked this pull request as ready for review August 24, 2026 12:32

mjasikowski requested a review from a team as a code owner August 24, 2026 12:32

melvin-bot Bot requested review from heyjennahay, ikevin127 and mjasikowski and removed request for a team August 24, 2026 12:32

mjasikowski removed the request for review from ikevin127 August 24, 2026 12:32

Merge remote-tracking branch 'origin/main' into claude-companyCardExp…

210b743

…ortRhpBackground Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>

MelvinBot requested a review from a team as a code owner August 25, 2026 06:23

melvin-bot Bot requested review from thesahindia and removed request for a team August 25, 2026 06:23

huult approved these changes Aug 25, 2026

View reviewed changes

huult reviewed Aug 25, 2026

View reviewed changes

Remove company-card details/export comment from WORKSPACE_TO_RHP

fbc771d

Co-authored-by: Michał Jasikowski <mjasikowski@users.noreply.github.com>

mjasikowski approved these changes Aug 25, 2026

View reviewed changes

mjasikowski removed the request for review from thesahindia August 25, 2026 11:20

JS00001 approved these changes Aug 25, 2026

View reviewed changes

mjasikowski merged commit 87ff05b into main Aug 25, 2026
44 of 47 checks passed

mjasikowski deleted the claude-companyCardExportRhpBackground branch August 25, 2026 11:22

OSBotify mentioned this pull request Aug 25, 2026

Deploy Checklist: New Expensify 2026-08-25 #99466

Closed

63 tasks

Conversation

MelvinBot commented Aug 20, 2026 • edited by mjasikowski Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Uh oh!

MelvinBot commented Aug 20, 2026

Uh oh!

MelvinBot commented Aug 20, 2026

Uh oh!

melvin-bot Bot commented Aug 24, 2026

Uh oh!

mjasikowski commented Aug 24, 2026

Uh oh!

huult commented Aug 24, 2026

Uh oh!

huult commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

huult commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult commented Aug 25, 2026

Uh oh!

mjasikowski commented Aug 25, 2026

Uh oh!

huult commented Aug 25, 2026

Uh oh!

mjasikowski commented Aug 25, 2026

Uh oh!

melvin-bot Bot commented Aug 25, 2026

Uh oh!

MelvinBot commented Aug 25, 2026

Uh oh!

MelvinBot commented Aug 25, 2026

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

huult Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

mjasikowski Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Aug 25, 2026

Uh oh!

MelvinBot commented Aug 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

OSBotify commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

OSBotify commented Aug 25, 2026

Uh oh!

MelvinBot commented Aug 25, 2026

Uh oh!

OSBotify commented Aug 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MelvinBot commented Aug 20, 2026 •

edited by mjasikowski

Loading

huult commented Aug 25, 2026 •

edited

Loading

huult commented Aug 25, 2026 •

edited

Loading