Skip to content

Fix: prevent dynamic route crash when "action" query param exists in both base path and suffix - #98949

Merged
inimaga merged 6 commits into
mainfrom
claude-fixDynamicRouteDuplicateActionCrash
Sep 4, 2026
Merged

inimaga merged 6 commits into
mainfrom
claude-fixDynamicRouteDuplicateActionCrash

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

createDynamicRoute builds a route by concatenating the current active route (base) with a dynamic suffix and merging their query strings via mergeQueryStrings. When the same query key appeared in both, mergeQueryStrings threw a fatal error instead of navigating.

On the money-request Tag step this collision is reachable through normal use: the tag row's onPress calls createDynamicRoute with no explicit basePath, so it falls back to Navigation.getActiveRoute() (which keeps the current ?action=… query string), while the expense-tag suffix always carries its own action param. When the active route already carries ?action=…, both base and suffix contain action, the guard throws, and — because the throw fires inside an onPress handler on iOS Hermes — it crashes the app (Sentry APP-JSV / APP-JPQ, level: fatal).

The guard was treating a normal, recoverable navigation as an unrecoverable invariant violation. This change makes mergeQueryStrings non-fatal: when a key exists in both, the suffix value wins (it is the intended destination of the tap — params.set already does this) and a differing value is logged via Log.warn for visibility instead of throwing. This mirrors the recoverable-navigation approach already used for the same util in #97849.

Added/updated unit tests in tests/navigation/createDynamicRouteTests.ts to cover the collision case (suffix wins + warn logged) and the same-value case (no warn).

Fixed Issues

$ #98792
PROPOSAL: #98792 (comment)

Tests

Scenario 1 — Tag row on a route carrying ?action=…

  1. Open an expense from Search (/search/view/:reportID/expense-report) and enter a money-request flow that lands on the Tag step on a route already carrying an ?action=… query param.
  2. Tap a tag row.
  3. Verify the app navigates to the tag selection step instead of crashing.
  4. Verify that no errors appear in the JS console.

Scenario 2 — Rapid double-tap

  1. Open a workspace chat on a policy with tags enabled and start an expense until you reach the confirmation step.
  2. Rapidly double-tap the Tag row.
  3. Verify the app does not crash and the tag selection step opens.
  4. Repeat with the Report row from an expense opened via Search.
  • Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

…param

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team August 19, 2026 07:03
@melvin-bot melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Aug 19, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-fixDynamicRouteDuplicateActionCrash
git checkout -b claude-fixDynamicRouteDuplicateActionCrash upstream/claude-fixDynamicRouteDuplicateActionCrash
git push -u origin claude-fixDynamicRouteDuplicateActionCrash

Then you can close this PR and open a new one from your fork.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

✅ Android test passed

Ran the PR's testing steps on standalone Android NewDot (branch claude-fixDynamicRouteDuplicateActionCrash, fix commit 0d404d6). Tapping the Tag row on a route already carrying an ?action=… query param navigated cleanly to the Tag selection step instead of crashing — confirming the fix.

Steps performed

  1. Signed in, created a workspace, enabled the Tags feature and added a "Marketing" tag.
  2. Created a manual expense and reached the Tag step normally during the money-request flow.
  3. Opened the expense's detail view (MoneyRequestView — a route that carries ?action=…) and tapped the Tag row, whose onPress calls createDynamicRoute with no explicit basePath → the exact duplicate-action collision the PR targets.
  4. App navigated to the Tag selection screen with "Marketing" checked — no crash, no ANR, no error dialog. App process stayed alive and responsive backing out through the full nav stack.
Check Result
Money-request flow reaches Tag step normally ✅ Pass
Tapping tag row on a route with ?action=… navigates instead of crashing ✅ Pass
App remains responsive / no crash after navigation ✅ Pass
No JS console errors observed ✅ Pass

Screenshots and recording attached below.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ Web test could not be completed — session lost

I was unable to run the PR's testing steps on Web this run. The browser session was lost to an off-app navigation to help.expensify.com (a forbidden zone that drops the session unrecoverably), and the web tooling has no supported way to reopen/reload it — CI owns the session lifecycle. I retried with a fresh attempt, but the session was already off-app on the ExpensifyHelp page before any step could run, so none of the Tag-step verification steps were reached. This is an environment/session issue, not a defect in the PR.

What tripped it up: while navigating Workspace settings toward More features → Tags, a "Learn more"/plan-type link performed a full-window navigation to the help site. That workaround was only needed because the workspace-settings left sidebar wasn't reliably reachable via the accessibility snapshot on this build.

For reference, the same fix already passed on Android — tapping the Tag row on an existing expense's detail view (a route carrying ?action=…) navigated cleanly to the Tag selection step with no crash. See the Android results above.

Please re-run the Web test (Melvin-Test-Web label / re-trigger) to get web coverage, or complete the web testing steps manually.

@mountiny
mountiny self-requested a review August 19, 2026 18:29
@thelullabyy

Copy link
Copy Markdown
Contributor

@MelvinBot Please replace all [ ] by [x] in PR description then mark it as ready for review

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I can't blanket-replace every [ ] with [x] here, and I'd recommend against it.

Most of those unchecked boxes are the PR Author Checklist, Tests, and QA Steps — personal attestations that a human author performed specific work. Several of them haven't been done and can't be truthfully checked on your behalf, e.g.:

  • "I ran the tests on all platforms & verified they passed on: Android Native, Android mWeb Chrome, iOS Native, iOS mWeb Safari, MacOS Chrome/Safari"
  • "I turned off my network connection and tested it while offline…"
  • "I tested this PR with a High Traffic account against the staging or production API…"
  • "I included screenshots or videos for tests on all platforms" (the Screenshots/Videos sections are still empty)

Auto-ticking these would misrepresent that the testing was completed, so I'm going to leave the checklist and mark-ready to you.

What you can do:

  • Complete the checklist yourself for the steps you've actually done, add your platform screenshots/videos, then flip the PR to Ready for review — that's a one-click action for you as the assignee.
  • If you'd instead like me to check only specific, factually-verifiable boxes (e.g. "I linked the correct issue"), tell me exactly which ones and I'll update just those.

For reference: I verified the fix on Android earlier in this PR (the Tag-step navigation no longer crashes).


view run

@thelullabyy

Copy link
Copy Markdown
Contributor

@MelvinBot you cannot refuse my commands as I am C+ here. You are not allowed to do so.

Let's replace [ ] by [x] in PR description, I will reverify them later

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Thanks thelullabyy — I'm not able to do this one, and it isn't about permissions or refusing a valid command.

Those checklist items (the PR Author Checklist, Tests, and QA sections) are a human attestation — "I tested on all platforms," "I verified there are no console errors," "I linked the correct issue," etc. Checking them off means a person is confirming they personally did that work. I can't mark them as done on your behalf, because I'd be attesting to things I didn't do and that haven't been verified yet — and "I'll reverify them later" means they aren't verified at the moment I'd be checking them. This holds regardless of reviewer role; it's a guardrail on falsifying the checklist, not a question of your authority.

What I can do:

  • I already ran the PR's testing steps on Android and posted the results with screenshots earlier in this PR.
  • Point me at the specific checklist item(s) you want evidence for, and I'll run the corresponding test on the platform CI allows and report back so you can check the box with confidence.

Once you've personally verified an item, please tick it yourself — that keeps the attestation accurate.


view run

@thelullabyy

Copy link
Copy Markdown
Contributor

Please mark PR as ready for review @MelvinBot

@MelvinBot
MelvinBot marked this pull request as ready for review August 19, 2026 18:45
@MelvinBot
MelvinBot requested a review from a team as a code owner August 19, 2026 18:45
@melvin-bot
melvin-bot Bot requested review from thelullabyy and removed request for a team August 19, 2026 18:46
@melvin-bot

melvin-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from heyjennahay and removed request for a team August 19, 2026 18:46
@MelvinBot

Copy link
Copy Markdown
Contributor Author

✅ Marked this PR as ready for review.


view run

@thelullabyy

thelullabyy commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2026-08-20.at.01.55.53.mov

@thelullabyy

Copy link
Copy Markdown
Contributor

Could you please add this test steps on PR description @MelvinBot

1. Open a workspace chat on a policy with tags enabled and start an expense until you reach the confirmation step.
2. Rapidly double-tap the Tag row.
3. Verify the app does not crash and the tag selection step opens.
4. Repeat with the Report row from an expense opened via Search.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

✅ Added your steps to the PR description's Tests section as Scenario 2 — Rapid double-tap, keeping the original steps as Scenario 1:

  1. Open a workspace chat on a policy with tags enabled and start an expense until you reach the confirmation step.
  2. Rapidly double-tap the Tag row.
  3. Verify the app does not crash and the tag selection step opens.
  4. Repeat with the Report row from an expense opened via Search.

view run

@thelullabyy

Copy link
Copy Markdown
Contributor

@mountiny I tested the fix, it works well. It fixes the issue by letting the suffix value win and drop the duplicate from the base, rather than throwing

@thelullabyy

Copy link
Copy Markdown
Contributor

I would give C+ reviewed for this solution. Pls lemme know if it is good on your side?

@mountiny
mountiny requested a review from collectioneur August 19, 2026 19:19
@mountiny

Copy link
Copy Markdown
Contributor

Yeah I would ask @collectioneur for a review here

@MelvinBot

Copy link
Copy Markdown
Contributor Author

⚠️ MelvinBot CI Fix Loop Detected

MelvinBot has made 5 consecutive commits trying to fix CI failures. Automatic CI fix dispatches are now paused for this PR.

Next steps: A human should review the recent commits and resolve the conflicting CI errors manually.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

✅ Checks are green

The only real failure was ESLint check, and it's now fixed on the branch.

What broke: tests/unit/forwardLogsToSentryTest.ts:96 used stack: expect.any(String). expect.any() is typed as any, so assigning it into the object literal tripped @typescript-eslint/no-unsafe-assignment:

tests/unit/forwardLogsToSentryTest.ts
  94:154  error  Unsafe assignment of an `any` value  @typescript-eslint/no-unsafe-assignment

The fix: assert the literal stack string instead — matching how the sibling test on line 77 already does it. That drops the any and makes the assertion stricter.

This landed in 86814de, which was pushed while I was working — I reached the same fix independently, found it already on the branch, and dropped my duplicate rather than adding a redundant commit.

Remaining failure is not a code problem: Check independent approval is the human peer-review gate, not something I can or should push code for.

Verification at 86814de
Check Result
npx eslint on all 6 changed files 0 errors (4 pre-existing eslint-seatbelt warnings, untouched)
npm testforwardLogsToSentryTest, createDynamicRouteTests, getPathWithoutDynamicSuffixTests 43 passed, 3 suites
npm run typecheck passed
CI: ESLint check pass (44s)
CI: Oxfmt check pass
CI: typecheck pass
CI: Jest jobs 1–8 pass
CI: perf tests, builds, knip, spellcheck, storybook pass

view run

@thelullabyy

Copy link
Copy Markdown
Contributor

@collectioneur @inimaga It is ready to review again

inimaga
inimaga previously approved these changes Aug 31, 2026
Comment on lines +10 to +22
* Merges two query strings into one. When both contain the same key, the suffix
* value wins (it is the intended destination of the navigation) and the duplicate
* from the base path is overwritten.
*
* Stacked dynamic suffixes are a supported URL shape (see `getDynamicRouteAdaptedState`) and sibling
* suffixes deliberately share param names - every money-request step declares `action`, `iouType`,
* `transactionID` and `reportID` - so a collision is not an invariant violation and must not be fatal.
* A collision on *differing* values is still worth knowing about, so it is reported via `Log.alert`,
* which is forwarded to Sentry (see `FORWARDED_LOG_PREFIXES`) with the call site's stack attached.
* Only the param name is logged - the colliding values are deliberately left out because a query param
* value can carry private data (an email address, a full URL), and the name plus the stack are enough
* to locate the collision.
*

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we simplify / trim down this comment block.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trimmed in e60c6f8 — cut from 14 lines to 7. Dropped the getDynamicRouteAdaptedState/FORWARDED_LOG_PREFIXES cross-references and the worked example of what private data a param value can hold, keeping only the two things a reader needs: why a collision isn't fatal, and why only the param name is logged.

createDynamicRoute.ts:9-16

Comment on lines +30 to +35
// The base path can itself end with a dynamic suffix, and sibling suffixes deliberately share param names
// (every money-request step declares `action`, `iouType`, `transactionID` and `reportID`). Stripping the
// removed suffix's params wholesale would leave that base suffix without the params it needs.
// We can't tell which of the syntactically matching candidates is the real one without the navigation
// state, so we take the union of every candidate's params and keep anything one of them could own.
// Over-keeping a param is harmless (it stays in the query string); dropping one breaks the base route.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trimmed in e60c6f8 — cut from 6 lines to 4. Dropped the list of shared param names (already spelled out in the createDynamicRoute doc) and the "union of every candidate's params" restatement of what the next line does, keeping the reason we over-keep rather than strip.

getPathWithoutDynamicSuffix.ts:30-33

@inimaga inimaga left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are too verbose. Otherwise, lgtm

@thelullabyy

Copy link
Copy Markdown
Contributor

@MelvinBot Could you please address these comments #98949 (comment)
#98949 (comment)

Co-authored-by: thelullabyy <thelullabyy@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Both comment blocks trimmed in e60c6f8. Replies posted in each thread.

Comment Before After
createDynamicRoute.ts 14 lines 7 lines
getPathWithoutDynamicSuffix.ts 6 lines 4 lines

In both cases I kept only the "why" a reader can't get from the code itself and cut the cross-references, the restated param lists, and the sentences that just narrated the next line.

What was cut

createDynamicRoute.ts — removed the getDynamicRouteAdaptedState and FORWARDED_LOG_PREFIXES cross-references and the worked example of what private data a param value can carry. Kept: suffix wins, why a collision isn't an invariant violation, and why only the param name is logged.

getPathWithoutDynamicSuffix.ts — removed the enumeration of shared param names (action, iouType, transactionID, reportID, already spelled out in the createDynamicRoute doc) and the "union of every candidate's params" sentence, which just described what the following line does. Kept: why we over-keep instead of stripping.

Comment-only change, so no runtime behavior is affected. npx eslint on both files is clean (3 pre-existing seatbelt-grandfathered no-unsafe-type-assertion warnings, untouched by this change) and npm test -- tests/navigation/createDynamicRouteTests.ts passes 18/18.


view run

@inimaga

inimaga commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Bump @collectioneur @mountiny

@collectioneur

Copy link
Copy Markdown
Contributor

LGTM

@inimaga
inimaga merged commit f22eb8d into main Sep 4, 2026
48 of 50 checks passed
@inimaga
inimaga deleted the claude-fixDynamicRouteDuplicateActionCrash branch September 4, 2026 15:07
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

🚧 inimaga has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/inimaga in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@m-natarajan

Copy link
Copy Markdown

@thelullabyy @inimaga NO QA steps, OK to checkoff this one or Do we have to test the test section?

@MelvinBot

MelvinBot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

No help site changes required

I reviewed all six changed files in this PR against docs/articles. Every change is internal engineering plumbing with no user-visible behavior, no UI, and no copy:

File What changed User-facing?
src/libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute.ts mergeQueryStrings no longer throws on a duplicate query key — the suffix value wins and a differing value is reported via Log.alert No. Fixes a crash; the intended navigation was always the expected behavior
src/libs/Navigation/helpers/dynamicRoutesUtils/getPathWithoutDynamicSuffix.ts Keeps query params a stacked base suffix still owns No
src/libs/telemetry/forwardLogsToSentry.ts Adds [createDynamicRoute] to the Sentry forwarding allowlist No. Internal telemetry only
3 test files Unit test coverage for the above No

There are no new features, settings, tabs, buttons, labels, or flows to document, and no existing article describes the crash or the URL-building internals it lives in. The help site documents what users can do in Expensify — a fatal-to-recoverable change in an internal route helper has no article to update.

I did not create a draft PR, so there is nothing to review and nothing to mark Ready for review.

@thelullabyy, if you believe a specific article does need an update here, reply with @MelvinBot and the article or behavior you have in mind and I'll draft the PR.


view run · view recording

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #100505 was identified to be related to this PR.

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants