Skip to content

[No QA] Docs updates for E/A#95005 Cancel a pending P2P wallet payment - #98928

Merged
stephanieelliott merged 1 commit into
mainfrom
melvin-docs-cancel-p2p-payment
Sep 4, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
melvin-docs-cancel-p2p-payment

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Documents the new Cancel payment action added in #95005, which lets the sender of a peer-to-peer personal payment (paid from their Wallet) cancel it while it is held waiting for the recipient to set up their Wallet.

What changed

Added a section to Pay-Expenses.mdHow to cancel a personal payment before the recipient sets up their Wallet — under the personal payments workflow, covering:

  • When the payment is held (recipient hasn't set up their Wallet)
  • How the sender cancels it: Open the payment report → More → Cancel payment → confirm
  • That the held funds are returned and the option disappears once the payment completes
  • That only the sender sees Cancel payment

Terminology verification

UI labels were verified against the source language file (src/languages/en.ts): Cancel payment, the confirmation copy "Are you sure that you want to cancel this payment?", and the report header More menu. Note the underlying feature depends on a companion Auth backend change and is limited to U.S. personal Wallet payments.

Related PR


@KioCoan, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Kio <KioCoan@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 18, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#95005 Cancel a pending P2P wallet payment [No QA] Docs updates for E/A#95005 Cancel a pending P2P wallet payment Aug 18, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://bc8db5c6.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott marked this pull request as ready for review August 28, 2026 04:06
@stephanieelliott
stephanieelliott self-requested a review as a code owner August 28, 2026 04:06
Comment thread docs/articles/new-expensify/wallet-and-payments/Pay-Expenses.md
Comment thread docs/articles/new-expensify/wallet-and-payments/Pay-Expenses.md
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single, well-scoped section to Pay-Expenses.md documenting the new Cancel payment action for held peer-to-peer personal Wallet payments. The change is focused, accurate, and fits cleanly into the existing personal payments workflow. Terminology was verified against src/languages/en.ts, which is exactly the right practice. Feedback below applies only to the added lines.

Scores Summary

  • Readability: 9/10 - Clear, concise prose; the lead-in sentence sets context well, steps are sequential and action-oriented, and the closing Note on sender-only visibility is a helpful clarification.
  • AI Readiness: 8/10 - Excellent task-based ## heading ("How to cancel a personal payment before the recipient sets up their Wallet") starting with an action phrase and including the feature name. Correct heading level. Minor gap: no explicit web/mobile navigation for locating the payment report.
  • Style Compliance: 7/10 - Button and menu names are correctly bolded (More, Cancel payment) and the confirmation copy matches the UI. Main issue: the inline link uses a full help.expensify.com URL, but HELP_AUTHORING_GUIDELINES.md Section 7 requires relative links only.

Key Findings

  • Strength: Heading is fully task-based, searchable, and feature-specific, meeting the AI retrieval rules (at least one full "How to..." heading with the feature name).
  • Strength: Deterministic, UI-exact button/menu references with correct bold formatting; confirmation string verified against the source language file.
  • Strength: Tightly scoped to a single sub-workflow with a clear held/returned-funds outcome and a useful sender-only limitation note.
  • Issue (must fix): The link to Set-up-your-wallet uses a full URL. Per Section 7 (Link Formatting), use a relative link. Also consider descriptive anchor text phrased as a task.
  • Issue (minor): Steps use Select while the surrounding personal-payment steps use Tap/Open; align verb usage for consistency, or provide web/mobile phrasing per the Navigation Instruction Standards.
  • Note (pre-existing, not scored): The file uses multiple top-level headings at the H1 level, which conflicts with Section 4 (exactly one H1 plus optional FAQ). This predates the PR and is out of scope, but worth flagging for a future cleanup.

Recommendations

  • Convert the inline Wallet setup link to a relative link (drop the full-domain prefix) to comply with Link Formatting rules.
  • Align step verbs with the surrounding section (e.g., Tap/Open) or add explicit web/mobile navigation for opening the payment report.
  • Otherwise ready: content is accurate, well-structured, and retrieval-friendly.

Files Reviewed

  • Pay-Expenses.md (docs/articles/new-expensify/wallet-and-payments/) - New section added; strong quality, one relative-link fix recommended.

Note: This is a summary review of the proposed changes only.

@stephanieelliott
stephanieelliott merged commit e322686 into main Sep 4, 2026
22 of 24 checks passed
@stephanieelliott
stephanieelliott deleted the melvin-docs-cancel-p2p-payment branch September 4, 2026 00:47
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants