[No QA] Docs updates for E/A#98291 grouped current view export columns - #98820
Conversation
Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
|
I looked into the checks — there's nothing to fix in the code.
No push needed. Once you've reviewed the doc changes, this should be good to move forward. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes small, targeted corrections across three export-related articles to match a behavior change in #98291. Previously the docs stated Export current view was unavailable when a Group by filter is applied and directed users to Basic export to preserve groups; the changes now correctly state that Current view works on grouped views, keeps each group as its own section, and uses the columns configured via Display > Edit columns. The changes are accurate, internally consistent, and well-scoped (6 additions, 6 deletions). Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a summary review. The changes are low-risk and align with governance standards. |
Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
|
Addressed the review feedback on this PR:
Pushed in |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b75531c8a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 6. Select **Export current view**. | ||
|
|
||
| The CSV uses the same columns displayed on the page. **Export current view** is not available when a **Group by** filter is applied. | ||
| The CSV uses the same columns displayed on the page. When a **Group by** filter is applied the CSV keeps each group as its own section and uses the columns currently shown on the page. |
There was a problem hiding this comment.
Remove grouped-export instructions from the Reports guide
On the Reports page this scenario is unreachable: the Display menu only renders Group by for expense or trip searches (DisplayPopup.tsx checks isExpenseType || isTripType), not for the expense-report view described throughout this guide. Claiming that a grouped Reports export preserves sections therefore directs readers toward a control they cannot use; restrict this statement to the Expenses workflow or remove it here.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Done — removed the grouped-export sentence from How-to-Export-Reports.md:49, so it now just reads "The CSV uses the same columns displayed on the page."
Confirmed the flag: DisplayPopup.tsx:90 only renders Group by for isExpenseType || isTripType, not the EXPENSE_REPORT view this guide describes — so the grouped-section claim was unreachable here. The statement still lives in the Expenses guide, where Group by is available.
Pushed in 858ae35.
…lable on report view) Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
|
A preview of your ExpensifyHelp changes have been deployed to https://c7bdd937.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.61-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.61-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Expensify/App#98291 changed how Export current view behaves on a grouped Search (a Bank Reconciliation view or any
Group byview). Previously it produced a CSV with a fixed set of columns; now it honors the columns configured in the view (Display > Edit columns) while keeping each group as its own section. On a grouped search, Basic export is no longer offered separately — Current view is the plain-CSV export.The help site said the opposite in several places ("Export current view is not available when a Group by filter is applied") and told users to pick Basic export to keep their groups. This PR updates the docs to match the new behavior.
Files changed
docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.md— removed the "not available when Group by is applied" claim; now states Export current view works on grouped views and uses the displayed columns.docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md— same correction.docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md— corrected the Current view template description, updated the "Export grouped expenses" steps and FAQ to select Current view (not Basic export), and noted that grouped exports use the columns set in Display > Edit columns.Verification
src/languages/en.tsin Expensify/App.useSearchBulkActionsExportTest.ts): on a grouped search, Current view is the only plain-CSV export and it carries the configured expense columns.@rlinoz, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.