Skip to content

[No QA] Docs updates for E/A#98291 grouped current view export columns - #98820

Merged
rlinoz merged 5 commits into
mainfrom
claude-docsGroupedExportColumns
Aug 25, 2026
Merged

rlinoz merged 5 commits into
mainfrom
claude-docsGroupedExportColumns

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Expensify/App#98291 changed how Export current view behaves on a grouped Search (a Bank Reconciliation view or any Group by view). Previously it produced a CSV with a fixed set of columns; now it honors the columns configured in the view (Display > Edit columns) while keeping each group as its own section. On a grouped search, Basic export is no longer offered separately — Current view is the plain-CSV export.

The help site said the opposite in several places ("Export current view is not available when a Group by filter is applied") and told users to pick Basic export to keep their groups. This PR updates the docs to match the new behavior.

Files changed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.md — removed the "not available when Group by is applied" claim; now states Export current view works on grouped views and uses the displayed columns.
  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md — same correction.
  • docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md — corrected the Current view template description, updated the "Export grouped expenses" steps and FAQ to select Current view (not Basic export), and noted that grouped exports use the columns set in Display > Edit columns.

Verification

  • UI labels ("Current view", "Basic export", "Display", "Edit columns", "Group by") were verified against src/languages/en.ts in Expensify/App.
  • Behavior confirmed from the PR's code and its unit tests (useSearchBulkActionsExportTest.ts): on a grouped search, Current view is the only plain-CSV export and it carries the configured expense columns.
  • A live web check of the grouped export menu was attempted but blocked by an empty test account (no expenses to select), so the copy is based on the code and verified string labels above — please double-check against the live product.

@rlinoz, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 18, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#98291 grouped current view export columns [No QA] Docs updates for E/A#98291 grouped current view export columns Aug 18, 2026
@OSBotify

This comment has been minimized.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I looked into the checks — there's nothing to fix in the code.

  • The one earlier concern was the Deploy ExpensifyHelp build check, which was still running when you pinged. It has since finished and passed ✅ (this is the relevant check for a docs-only PR).
  • All other checks (check, dryRun, spellcheck, validate, verify, verifySignedCommits, CLA) are green.
  • The only remaining failing check is Check independent approval, which isn't something a code change can resolve — it just needs an independent human reviewer to approve the PR. That's expected here since I opened the PR.

No push needed. Once you've reviewed the doc changes, this should be good to move forward.

Comment thread docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.md Outdated
Comment thread docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md Outdated
@rlinoz
rlinoz marked this pull request as ready for review August 19, 2026 19:06
Comment thread docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.md Outdated
Comment thread docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes small, targeted corrections across three export-related articles to match a behavior change in #98291. Previously the docs stated Export current view was unavailable when a Group by filter is applied and directed users to Basic export to preserve groups; the changes now correctly state that Current view works on grouped views, keeps each group as its own section, and uses the columns configured via Display > Edit columns. The changes are accurate, internally consistent, and well-scoped (6 additions, 6 deletions).

Scores Summary

  • Readability: 8/10 - The updated sentences are clear and actionable. A couple of the new lines run slightly long and would read better with a comma after the introductory clause (e.g., "When a Group by filter is applied the CSV keeps..." reads better as "When a Group by filter is applied, the CSV keeps..."). One of the three files already includes this comma, so phrasing is inconsistent across files.
  • AI Readiness: 9/10 - Full, UI-exact feature names are used throughout (Current view, Group by, Display, Edit columns). The edits reinforce a single workflow and align with realistic search intent ("keep groups when exporting"). No heading or metadata changes were introduced, so structure is unaffected.
  • Style Compliance: 9/10 - UI labels are bolded and match the product strings verified against en.ts. Terminology such as Workspace Admin is preserved. The changed lines are internally consistent in their label casing.

Key Findings

  • The core correction is accurate and removes contradictory/incorrect guidance that would have misled users.
  • Changes are consistent across all three files, keeping the messaging aligned.
  • Positive: UI labels were verified against source strings and the behavior was confirmed via the referenced PR's unit tests.
  • Minor: introductory-clause comma usage is inconsistent between files (Search-and-Download-Expenses.md includes the comma; How-to-Export-Expenses.md and How-to-Export-Reports.md omit it).
  • Note from author: a live product check was blocked by an empty test account, so a reviewer should confirm against the live grouped-export menu.

Recommendations

  • Add a comma after the introductory clause in How-to-Export-Expenses.md and How-to-Export-Reports.md for consistency with Search-and-Download-Expenses.md and improved readability.
  • Have a reviewer verify the copy against the live grouped-export flow, since automated UI verification was not possible.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Expenses.md - Accurate correction; minor comma nit.
  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md - Accurate correction; minor comma nit.
  • docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md - Accurate correction to template description, steps, and FAQ; well phrased.

Note: This is a summary review. The changes are low-risk and align with governance standards.

Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Addressed the review feedback on this PR:

  • Both suggestion blocks (rlinoz) on How-to-Export-Expenses.md and How-to-Export-Reports.md were already applied to the branch via the GitHub UI (437a5f24, b75531c8) — no further action needed.
  • Readability comment (github-actions bot): added the comma after "applied" so the introductory clause reads "When a Group by filter is applied, the CSV keeps each group...". Applied it to both How-to-Export-Expenses.md and How-to-Export-Reports.md for consistency (Search-and-Download-Expenses.md already had it).

Pushed in 2d54d1d. Docs-only markdown change — no code tests apply. Replied in each review thread as well.


view run

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b75531c8a4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

6. Select **Export current view**.

The CSV uses the same columns displayed on the page. **Export current view** is not available when a **Group by** filter is applied.
The CSV uses the same columns displayed on the page. When a **Group by** filter is applied the CSV keeps each group as its own section and uses the columns currently shown on the page.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove grouped-export instructions from the Reports guide

On the Reports page this scenario is unreachable: the Display menu only renders Group by for expense or trip searches (DisplayPopup.tsx checks isExpenseType || isTripType), not for the expense-report view described throughout this guide. Claiming that a grouped Reports export preserves sections therefore directs readers toward a control they cannot use; restrict this statement to the Expenses workflow or remove it here.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice catch, @MelvinBot update.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — removed the grouped-export sentence from How-to-Export-Reports.md:49, so it now just reads "The CSV uses the same columns displayed on the page."

Confirmed the flag: DisplayPopup.tsx:90 only renders Group by for isExpenseType || isTripType, not the EXPENSE_REPORT view this guide describes — so the grouped-section claim was unreachable here. The statement still lives in the Expenses guide, where Group by is available.

Pushed in 858ae35.


view run

…lable on report view)

Co-authored-by: Rodrigo Lino da Costa <rlinoz@users.noreply.github.com>
@OSBotify

Copy link
Copy Markdown
Contributor

@rlinoz
rlinoz self-requested a review August 25, 2026 16:46
@rlinoz
rlinoz merged commit d57ad07 into main Aug 25, 2026
21 of 22 checks passed
@rlinoz
rlinoz deleted the claude-docsGroupedExportColumns branch August 25, 2026 16:46
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.61-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants