[No QA] Docs updates for E/A#97071 Show GL codes in category picker - #98818
Conversation
…97071) Co-authored-by: Yusuf: Software Engineer <yusufdeveloper2903@users.noreply.github.com>
|
There's nothing to fix here — no check is failing on the PR's contents. The only red check is Check independent approval, whose failing step is Everything else is green ( To clear it: have an independent reviewer approve the PR — once |
This comment has been minimized.
This comment has been minimized.
HelpDot Documentation ReviewOverall AssessmentThis PR updates Create-expense-categories.md to document a new capability: showing GL codes to Workspace Members in the category picker via the Show GL codes when categorizing expenses setting. It adds one new task-based section, revises the GL/payroll codes explanation, and updates the related FAQ answer. The changes are accurate, well-scoped to the existing article's workflow, and generally follow the governance conventions. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd16b04649
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
|
Fixed the failing spellcheck check: a typo The other red check, |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @lschurr |
This comment has been minimized.
This comment has been minimized.
|
A preview of your ExpensifyHelp changes have been deployed to https://8133599b.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/lschurr in version: 9.4.65-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.4.65-3 🚀
Bundle Size Analysis (Sentry): |
Docs update for #97071
#97071 reapplied the feature that shows category GL codes in the category picker, gated behind a new workspace setting: Show GL codes when categorizing expenses (
src/languages/en.ts→workspace.categories.showCategoryGLCodes). The toggle lives on the Categories settings page (Categories > More > Settings) and only appears when the workspace has GL codes assigned.This made the existing help article
docs/articles/new-expensify/workspaces/Create-expense-categories.mdinaccurate — it stated GL codes are never visible to members.Changes
Notes
en.tsand matched to the existing article's navigation phrasing (Categories > More > Settings), per HELPSITE_NAMING_CONVENTIONS.md.Create-and-manage-expense-tags.mdwas intentionally left unchanged — this PR's setting (showCategoryGLCodes) only affects category GL codes, not tag GL codes.@yusufdeveloper2903, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.