Skip to content

[No QA] Docs updates for E/A#97071 Show GL codes in category picker - #98818

Merged
lschurr merged 3 commits into
mainfrom
melvin-docs-93155-glcodes-categorypicker
Aug 31, 2026
Merged

lschurr merged 3 commits into
mainfrom
melvin-docs-93155-glcodes-categorypicker

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Docs update for #97071

#97071 reapplied the feature that shows category GL codes in the category picker, gated behind a new workspace setting: Show GL codes when categorizing expenses (src/languages/en.ts → workspace.categories.showCategoryGLCodes). The toggle lives on the Categories settings page (Categories > More > Settings) and only appears when the workspace has GL codes assigned.

This made the existing help article docs/articles/new-expensify/workspaces/Create-expense-categories.md inaccurate — it stated GL codes are never visible to members.

Changes

  • Added a task-based section, How to show GL codes to members when categorizing expenses, with the steps to enable the setting.
  • Updated the How to add or edit GL codes or payroll codes section — it previously said GL and payroll codes are "not visible to members," which is no longer true for GL codes.
  • Rewrote the FAQ How can members see GL codes? — it previously said the only workaround was putting the GL code in the category name; it now points members/admins to the new setting.

Notes

  • All UI labels were taken verbatim from en.ts and matched to the existing article's navigation phrasing (Categories > More > Settings), per HELPSITE_NAMING_CONVENTIONS.md.
  • The tag GL code visibility statement in Create-and-manage-expense-tags.md was intentionally left unchanged — this PR's setting (showCategoryGLCodes) only affects category GL codes, not tag GL codes.

@yusufdeveloper2903, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…97071)

Co-authored-by: Yusuf: Software Engineer <yusufdeveloper2903@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 18, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

There's nothing to fix here — no check is failing on the PR's contents.

The only red check is Check independent approval, whose failing step is Verify peer review. This isn't a code failure; it's the approval gate that stays red until the PR gets an approving review from an independent reviewer. It's on the list of checks I don't act on, so there's no branch fix to push.

Everything else is green (check, dryRun, spellcheck, validate, verify, verifySignedCommits, CLA), and build is still pending rather than failing.

To clear it: have an independent reviewer approve the PR — once @yusufdeveloper2903 (or another reviewer) reviews and approves, Check independent approval will pass.

@github-actions github-actions Bot changed the title Docs updates for E/A#97071 Show GL codes in category picker [No QA] Docs updates for E/A#97071 Show GL codes in category picker Aug 18, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott self-assigned this Aug 28, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review August 28, 2026 01:26
@stephanieelliott
stephanieelliott self-requested a review as a code owner August 28, 2026 01:26
Comment thread docs/articles/new-expensify/workspaces/Create-expense-categories.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Create-expense-categories.md
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates Create-expense-categories.md to document a new capability: showing GL codes to Workspace Members in the category picker via the Show GL codes when categorizing expenses setting. It adds one new task-based section, revises the GL/payroll codes explanation, and updates the related FAQ answer. The changes are accurate, well-scoped to the existing article's workflow, and generally follow the governance conventions.

Scores Summary

  • Readability: 9/10 - Clear, concise prose; sequential numbered steps; the revised paragraph cleanly distinguishes payroll-code vs GL-code visibility behavior.
  • AI Readiness: 8/10 - New heading is fully task-based and feature-specific ("How to show GL codes to members when categorizing expenses"); UI-exact labels used. Metadata was not updated to reflect the new show-GL-codes capability/keywords.
  • Style Compliance: 8/10 - Bold UI labels, correct sentence case, and consistent navigation phrasing in the new steps. Minor deviations noted below in the FAQ breadcrumb and setting-verb phrasing.

Key Findings

  • Positive: The new section "How to show GL codes to members when categorizing expenses" is task-based, searchable, and uses the exact setting label Show GL codes when categorizing expenses. Steps follow the established file pattern (unified navigation-tabs web/mobile phrasing).
  • Positive: The revised intro paragraph accurately separates payroll code visibility (hidden) from GL code visibility (hidden by default, can be shown), preventing member confusion.
  • Positive: The FAQ answer was updated to stay consistent with the new capability rather than left stale.
  • Improvement: Metadata (keywords/internalScope) was not updated to cover the new show-GL-codes-when-categorizing workflow. Adding a keyword phrase (e.g., "show GL codes to members") improves retrieval alignment per HELP_AUTHORING_GUIDELINES.md Sections 3 and 6.
  • Improvement: The updated FAQ answer uses a "Workspaces > [Workspace name] > Categories > More > Settings" breadcrumb, whereas the rest of the file (and the new section) uses explicit numbered navigation-tab steps. Consider matching the article's dominant navigation style for consistency (HELPSITE_NAMING_CONVENTIONS.md Navigation Standards).
  • Note: Show GL codes when categorizing expenses is described with "Enable" (per Toggles guidance). If this control is a toggle in the UI, current phrasing is correct; if it is a checkbox/button, verify the verb matches the UI.

Recommendations

  • Update the YAML keywords (and optionally internalScope) to include the new show-GL-codes-to-members workflow.
  • Align the FAQ answer's navigation with the numbered navigation-tabs pattern used elsewhere in the article for consistency.
  • Confirm the exact UI control type/verb for Show GL codes when categorizing expenses (toggle vs checkbox) so the action verb matches the product.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Create-expense-categories.md - Approve with minor suggestions. Accurate, well-scoped additions; metadata and FAQ navigation consistency are the main polish items.

Note: Detailed line-by-line feedback has been provided as inline comments.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cd16b04649

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/articles/new-expensify/workspaces/Create-expense-categories.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Create-expense-categories.md Outdated
Co-authored-by: Stephanie Elliott <stephanieelliott@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Fixed the failing spellcheck check: a typo GL codee → GL code in Create-expense-categories.md:94. Ran npm run spell-changed locally on the file afterward — 0 issues.

The other red check, Check independent approval, is a review-gate check unrelated to the code and not something a code change resolves.


view run

@melvin-bot

melvin-bot Bot commented Aug 28, 2026 •

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @lschurr

@melvin-bot
melvin-bot Bot requested review from lschurr and removed request for a team August 28, 2026 05:04
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

@lschurr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

This comment has been minimized.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://8133599b.helpdot.pages.dev ⚡️

Updated articles:

@lschurr lschurr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@lschurr
lschurr merged commit d6e6cdb into main Aug 31, 2026
16 of 17 checks passed
@lschurr
lschurr deleted the melvin-docs-93155-glcodes-categorypicker branch August 31, 2026 18:25
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/lschurr in version: 9.4.65-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.65-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants