[Payment due @truph01] Docs updates for E/A#98161 document Download workflows option on Workflows page - #98479
Conversation
Co-authored-by: truph01 <truph01@users.noreply.github.com>
|
I looked into the failing checks. There's nothing to fix here with a code change. The only failing check is That check isn't a build/test failure. It fails because this PR was opened by MelvinBot and still needs an approval from an independent human reviewer (someone other than the author). It will turn green automatically once the PR is reviewed and approved — there's no branch change that can clear it. Next step: review the changed docs and, once they look right, mark the PR ready for review and approve it (or have another reviewer approve). Per the PR description, you can also reply with |
|
@MelvinBot mark this PR as ready |
|
Done — this PR is now marked Ready for review. 🚀 One reminder from the PR description: the UI labels (Workflows tab, More button, Download workflows item) were taken verbatim from the strings in #98161 but couldn't be confirmed against the live UI during authoring, so please give those a final glance during review. |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a single, focused task-based section (## How to download your workflow configuration) to docs/articles/new-expensify/workspaces/Workspace-Workflows.md, documenting the new Download workflows option in the More menu on the Workflows page. The addition is small, self-contained, and matches the existing article style well. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a summary review of the proposed diff only. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbd909c0f5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Nothing to fix here — there's no code failure to push a fix for. The only failing check is Check independent approval, and it's failing simply because the PR doesn't yet have an independent reviewer's approval ( To clear it: this PR needs an approval from an independent reviewer (someone other than the author). Since it's a HelpDot docs change, once you've reviewed the files and confirmed they reflect the current behavior, get a reviewer to approve it and the check will pass. Full check status
|
|
🎯 @truph01, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@Kel-Expensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.60-0 🚀
|
|
Any QA steps here? |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.60-2 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #99469 |
Docs update for #98161
#98161 adds a Download workflows option to the More dropdown on Workspace > Workflows, letting admins export their workflow configuration as a CSV. The Workspace Workflows help article didn't document this (or the More menu) at all, so this PR adds a short task-based section covering it.
What changed
docs/articles/new-expensify/workspaces/Workspace-Workflows.mdwith steps to open Workflows > More > Download workflows, plus a note on the offline behavior.Label verification
UI labels used in the article (Workflows tab, More button, Download workflows item) were taken verbatim from the strings shipped in #98161 (
common.more,spreadsheet.downloadWorkflows). I was unable to confirm them against the live UI because the test session wasn't authenticated during this run, so please double-check the exact on-screen labels when reviewing.@truph01, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.