Skip to content

[No QA] Docs updates for E/A#97083 note comma values need quotes in search - #98475

Merged
stephanieelliott merged 2 commits into
mainfrom
docs-97083-search-comma-quoting
Sep 4, 2026
Merged

stephanieelliott merged 2 commits into
mainfrom
docs-97083-search-comma-quoting

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Docs update prompted by #97083, which fixed contextual search suggestions failing when a workspace or room name contains a comma. The parser ends an unquoted value at a comma (commas are the OR separator), so a name like Acme, Inc was read back as two values. The PR now quotes such values automatically.

The public help article Use Search Operators to Filter and Analyze only told members to quote values that contain spaces — it never mentioned commas. A member manually typing workspace:Acme, Inc (unquoted) would hit the same OR-splitting behavior. This PR closes that gap.

Changes

In docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md:

  • Added a core-rules bullet explaining that a value containing a space or a comma must be wrapped in quotes so it reads as one value instead of two OR conditions.
  • Updated the workspace: operator row and example to cover commas (workspace:"Acme, Inc").
  • Updated the Note under the operator table to state quotes are required for names with spaces or commas, with the reason (commas separate OR conditions).
  • Updated the "Do I need to use quotes for everything?" FAQ answer to include commas.

No new UI labels were introduced — the operators, Search icon, and Spend tab referenced were already documented in this article.

Verification note

Live-UI verification of the search bar could not be completed in this automated run because the pre-started test session was not authenticated. The wording relies only on behavior already documented in this article and established by #97083 and its unit tests (the parser splits unquoted values at commas). Please double-check the exact operator wording against the current UI when reviewing.


@mukhrr, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Mukhriddin Shakhriyorov <mukhrr@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 12, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review August 28, 2026 00:59
@stephanieelliott
stephanieelliott self-requested a review as a code owner August 28, 2026 00:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 61f98b5fba

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

- Combine fields for **AND** conditions: `amount>50 status:approved`.
- Use `-` to exclude results: `-has:receipt`.
- Use quotes for exact phrases: `description:"team lunch"`.
- Wrap a value in quotes when the value itself contains a space or a comma, so it is read as one value instead of two OR conditions: `workspace:"Acme, Inc"`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Distinguish how unquoted spaces are parsed

When a value contains a space, the unquoted suffix is not interpreted as a second OR value: for example, workspace:Acme Inc parses as the workspace filter Acme plus the keyword Inc, combined with AND. Only the comma case becomes two values of the same filter. Please limit the “two OR conditions” explanation to commas or describe the space and comma cases separately so members are not taught the wrong query semantics.

Useful? React with 👍 / 👎.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, well-scoped update to the Use-Search-Operators-to-Filter-and-Analyze article. It closes a real documentation gap: the article previously told members to quote only values containing spaces, but the parser also splits unquoted values at commas (the OR separator). The PR adds comma guidance in four consistent places (core-rules bullet, the workspace operator table row, the Note under the table, and the FAQ answer). The changes are accurate, consistent, and stay within the existing article scope.

Scores Summary

  • Readability: 9/10 - Additions are clear, concise, and use consistent inline code formatting. The Note explains the reason (commas separate OR conditions), which aids comprehension.
  • AI Readiness: 9/10 - New wording reinforces existing task-based headings and uses UI-exact operator names. Examples like workspace:"Acme, Inc" match realistic search phrasing. No metadata or heading changes were needed; existing structure is compliant.
  • Style Compliance: 9/10 - Uses exact operator syntax, correct bold for OR/AND and the Note label, and consistent backtick formatting. Aligns with the existing FAQ structure. No UI label naming issues introduced.

Key Findings

  • Accurate fix that matches the underlying parser behavior from E/A 97083; the added rationale (commas = OR separator) is a genuine improvement over the prior spaces-only guidance.
  • Consistent application across all four touchpoints, so members will not get conflicting instructions.
  • Minor inconsistency: the table example changed from workspace:"Acme Inc." to workspace:"Acme, Inc", dropping the trailing period. This is fine, but consider keeping the sample company name consistent across the article for polish.

Recommendations

  • No blocking issues.
  • Consider noting that the app now auto-quotes such values (per the PR summary) so members understand autocomplete already handles this, distinguishing it from manually typed queries.
  • Optionally standardize the sample workspace name used across examples.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md - Approved with minor optional suggestions.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott requested a review from a team August 28, 2026 01:25
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @CortneyOfstad

@melvin-bot
melvin-bot Bot requested a review from CortneyOfstad August 28, 2026 01:25
@melvin-bot

melvin-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 28, 2026 01:25
CortneyOfstad
CortneyOfstad previously approved these changes Sep 3, 2026
@CortneyOfstad
CortneyOfstad dismissed stale reviews from stephanieelliott and themself via ddc9c1f September 3, 2026 13:32
@github-actions github-actions Bot changed the title Docs updates for E/A#97083 note comma values need quotes in search [No QA] Docs updates for E/A#97083 note comma values need quotes in search Sep 3, 2026
@OSBotify

OSBotify commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://c5e419e4.helpdot.pages.dev ⚡️

Updated articles:

@CortneyOfstad
CortneyOfstad self-requested a review September 3, 2026 13:52
@CortneyOfstad

CortneyOfstad commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@stephanieelliott not sure why the review is not being accepted 🤔

I requested a review from you to see if that will do the trick

@stephanieelliott
stephanieelliott merged commit 6cc6e0a into main Sep 4, 2026
26 of 28 checks passed
@stephanieelliott
stephanieelliott deleted the docs-97083-search-comma-quoting branch September 4, 2026 04:33
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants