[No QA] Docs updates for E/A#97083 note comma values need quotes in search - #98475
Conversation
Co-authored-by: Mukhriddin Shakhriyorov <mukhrr@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61f98b5fba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - Combine fields for **AND** conditions: `amount>50 status:approved`. | ||
| - Use `-` to exclude results: `-has:receipt`. | ||
| - Use quotes for exact phrases: `description:"team lunch"`. | ||
| - Wrap a value in quotes when the value itself contains a space or a comma, so it is read as one value instead of two OR conditions: `workspace:"Acme, Inc"`. |
There was a problem hiding this comment.
Distinguish how unquoted spaces are parsed
When a value contains a space, the unquoted suffix is not interpreted as a second OR value: for example, workspace:Acme Inc parses as the workspace filter Acme plus the keyword Inc, combined with AND. Only the comma case becomes two values of the same filter. Please limit the “two OR conditions” explanation to commas or describe the space and comma cases separately so members are not taught the wrong query semantics.
Useful? React with 👍 / 👎.
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, well-scoped update to the Use-Search-Operators-to-Filter-and-Analyze article. It closes a real documentation gap: the article previously told members to quote only values containing spaces, but the parser also splits unquoted values at commas (the OR separator). The PR adds comma guidance in four consistent places (core-rules bullet, the workspace operator table row, the Note under the table, and the FAQ answer). The changes are accurate, consistent, and stay within the existing article scope. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@CortneyOfstad Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
ddc9c1f
|
A preview of your ExpensifyHelp changes have been deployed to https://c5e419e4.helpdot.pages.dev ⚡️ Updated articles: |
|
@stephanieelliott not sure why the review is not being accepted 🤔 I requested a review from you to see if that will do the trick |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Summary
Docs update prompted by #97083, which fixed contextual search suggestions failing when a workspace or room name contains a comma. The parser ends an unquoted value at a comma (commas are the OR separator), so a name like
Acme, Incwas read back as two values. The PR now quotes such values automatically.The public help article Use Search Operators to Filter and Analyze only told members to quote values that contain spaces — it never mentioned commas. A member manually typing
workspace:Acme, Inc(unquoted) would hit the same OR-splitting behavior. This PR closes that gap.Changes
In
docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md:workspace:operator row and example to cover commas (workspace:"Acme, Inc").No new UI labels were introduced — the operators, Search icon, and Spend tab referenced were already documented in this article.
Verification note
Live-UI verification of the search bar could not be completed in this automated run because the pre-started test session was not authenticated. The wording relies only on behavior already documented in this article and established by #97083 and its unit tests (the parser splits unquoted values at commas). Please double-check the exact operator wording against the current UI when reviewing.
@mukhrr, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.