[No QA] Docs updates for E/A#97094 Show GL codes in tag picker setting - #98474
Conversation
Co-authored-by: Neeraj Bachani <neerajbachani@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ecb252734
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| 1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]**. | ||
| 2. Select **Tags**. | ||
| 3. In the top-right corner, select **Settings**. |
There was a problem hiding this comment.
Route admins through the More menu to Settings
On the Tags page there is no top-right Settings control to select directly: WorkspaceTagsPage adds Settings to secondaryActions, which is rendered inside the More dropdown. Following these instructions therefore leaves an admin looking for a nonexistent button; update this step to More > Settings, consistent with the article's import instructions.
Useful? React with 👍 / 👎.
HelpDot Documentation ReviewOverall AssessmentThis PR documents a new Control-plan setting that lets Workspace Admins display tag GL codes in the tag picker. It adds a new task-based section ("How to show tag GL codes when selecting a tag"), refines an existing sentence about default GL code visibility, and updates the corresponding FAQ answer. The changes are small, focused, and stay within the single-workflow scope of the existing article. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Help site update for E/A#97094
PR #97094 adds a Show GL codes when selecting a tag toggle in Workspaces > [workspace name] > Tags > Settings (Control plan, visible only when GL codes are enabled). When on, each tag's GL code appears as a muted second line under the tag name in the tag picker, and members can search tags by GL code.
This changes previously documented behavior: the help article stated that tag GL codes are not visible to members. That is now conditional.
Changes
Updated
docs/articles/new-expensify/workspaces/Create-and-manage-expense-tags.md:Notes for reviewer
src/languages/en.ts) and the existing help-site navigation conventions. A live-UI verification pass could not complete because the test session lost authentication — please confirm the toggle label and location against the current UI.SetPolicyShowTagGLCodesbackend command is not yet deployed, so enabling the toggle currently rolls back with an error. This PR is left as a draft until the feature is fully live in production.Kept as a draft pending the review below.
@neerajbachani, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.