Skip to content

[No QA] Docs updates for E/A#97094 Show GL codes in tag picker setting - #98474

Merged
stephanieelliott merged 1 commit into
mainfrom
docs-97094-show-tag-gl-codes
Sep 4, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
docs-97094-show-tag-gl-codes

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site update for E/A#97094

PR #97094 adds a Show GL codes when selecting a tag toggle in Workspaces > [workspace name] > Tags > Settings (Control plan, visible only when GL codes are enabled). When on, each tag's GL code appears as a muted second line under the tag name in the tag picker, and members can search tags by GL code.

This changes previously documented behavior: the help article stated that tag GL codes are not visible to members. That is now conditional.

Changes

Updated docs/articles/new-expensify/workspaces/Create-and-manage-expense-tags.md:

  • Added a new section How to show tag GL codes when selecting a tag describing the toggle and its effect.
  • Updated the How to add or edit a tag GL code intro note to reflect that GL codes can now be shown in the tag picker.
  • Updated the FAQ Can members see Tag GL codes? to explain the new setting.

Notes for reviewer

  • Feature name, toggle label (Show GL codes when selecting a tag), and the Tags > Settings navigation were taken from the source PR's copy (src/languages/en.ts) and the existing help-site navigation conventions. A live-UI verification pass could not complete because the test session lost authentication — please confirm the toggle label and location against the current UI.
  • Backend dependency: the source PR notes the SetPolicyShowTagGLCodes backend command is not yet deployed, so enabling the toggle currently rolls back with an error. This PR is left as a draft until the feature is fully live in production.

Kept as a draft pending the review below.


@neerajbachani, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: Neeraj Bachani  <neerajbachani@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 12, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review August 28, 2026 00:57
@stephanieelliott
stephanieelliott self-requested a review as a code owner August 28, 2026 00:57
@stephanieelliott stephanieelliott self-assigned this Aug 28, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4ecb252734

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".


1. In the **navigation tabs** (on the left on web, and at the bottom on mobile), select **Workspaces** > **[workspace name]**.
2. Select **Tags**.
3. In the top-right corner, select **Settings**.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Route admins through the More menu to Settings

On the Tags page there is no top-right Settings control to select directly: WorkspaceTagsPage adds Settings to secondaryActions, which is rendered inside the More dropdown. Following these instructions therefore leaves an admin looking for a nonexistent button; update this step to More > Settings, consistent with the article's import instructions.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot fix this

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR documents a new Control-plan setting that lets Workspace Admins display tag GL codes in the tag picker. It adds a new task-based section ("How to show tag GL codes when selecting a tag"), refines an existing sentence about default GL code visibility, and updates the corresponding FAQ answer. The changes are small, focused, and stay within the single-workflow scope of the existing article.

Scores Summary

  • Readability: 9/10 - Clear, concise, action-oriented steps with a well-placed explanatory sentence and a helpful conditional note. Sentences flow well and are easy to scan.
  • AI Readiness: 8/10 - The new heading is task-based and feature-specific ("How to show tag GL codes when selecting a tag"), the workflow is self-contained, and search-relevant phrasing is used. Minor gap: no metadata changes to surface the new GL-code visibility workflow in keywords/description (acceptable for a small addition, but a keyword touch-up would improve retrieval).
  • Style Compliance: 9/10 - UI labels are bold and match the setting name exactly (Show GL codes when selecting a tag), navigation uses the approved unified web/mobile phrasing, and roles (Workspace Admin) are capitalized correctly. The FAQ answer stays inline and directly answers the question.

Key Findings

  • New section heading is correctly task-based, searchable, and includes the exact UI label.
  • Navigation instruction correctly uses the unified "(on the left on web, and at the bottom on mobile)" pattern.
  • Button/setting names are bolded and match the UI exactly; the Settings reference is correctly formatted.
  • FAQ answer was updated for consistency and correctly cross-references the new setting path (Tags > Settings).
  • Minor: Step 3 ("In the top-right corner, select Settings") is clear; confirm this matches the actual UI element rather than a three dots menu, per the Three Dots Menu Rule.
  • Minor: Consider whether a screenshot of the GL code appearing as a second line in the tag picker would reduce member confusion (optional per Section 8).

Recommendations

  • Optional: Add GL-code visibility phrasing to the article's keywords/description metadata to strengthen AI retrieval for this new workflow.
  • Verify step 3's Settings reference matches the exact UI affordance (label vs. icon) to stay compliant with UI referencing rules.
  • Consider an optional screenshot showing the GL code displayed beneath the tag name in the picker.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Create-and-manage-expense-tags.md - Approved with minor optional suggestions.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott merged commit a8b15fa into main Sep 4, 2026
21 of 24 checks passed
@stephanieelliott
stephanieelliott deleted the docs-97094-show-tag-gl-codes branch September 4, 2026 04:30
@stephanieelliott stephanieelliott changed the title Docs updates for E/A#97094 Show GL codes in tag picker setting [No QA] Docs updates for E/A#97094 Show GL codes in tag picker setting Sep 4, 2026
@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants