Skip to content

Use 20px horizontal margin for Section cards to match standard spacing #98443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blimpich merged 3 commits into from
Aug 17, 2026
Merged

Use 20px horizontal margin for Section cards to match standard spacing #98443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01631ba
Use 20px horizontal margin for Section cards to match standard spacing
MelvinBot Aug 12, 2026
b7293f4
Bump sectionMargin to 20 so gutter and section max-width stay in sync
MelvinBot Aug 12, 2026
b5869e4
Remove extra 4px gutter on More Features section to match 20px standard
MelvinBot Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/workspace/WorkspaceMoreFeaturesPage/MoreFeaturesSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function MoreFeaturesSection({title, children}: MoreFeaturesSectionProps) {
return (
<View style={[styles.mt3, shouldUseNarrowLayout ? styles.workspaceSectionMobile : {}]}>
<Section
containerStyles={[styles.ph1, styles.pv0, styles.bgTransparent, styles.noBorderRadius]}
containerStyles={[styles.ph0, styles.pv0, styles.bgTransparent, styles.noBorderRadius]}
childrenStyles={[styles.flexRow, styles.flexWrap, styles.columnGap3]}
renderTitle={() => (
<Text
Expand Down
2 changes: 1 addition & 1 deletion src/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6541,7 +6541,7 @@ const staticStyles = (theme: ThemeColors) =>
flexDirection: 'row',
alignItems: 'center',
gap: variables.componentBorderRadius,
marginBottom: variables.sectionMargin,
marginBottom: 16,
},
chartTitle: {
...FontUtils.fontFamily.platform.EXP_NEUE_BOLD,

@github-actions github-actions Bot Aug 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ CONSISTENCY-2 (docs)

This line replaces the named reference variables.sectionMargin with a hardcoded magic number 16. The value 16 is not self-explanatory in this context and is no longer tied to any documented constant, so a future reader cannot tell whether it is intentionally decoupled from sectionMargin (now 20) or an oversight. Since sectionMargin was intentionally bumped to 20, hardcoding 16 here silently freezes the old spacing without explanation.

Introduce a named constant for the chart header spacing (or reuse an existing one that semantically represents this value) instead of a bare literal:

// in variables.ts
chartHeaderMargin: 16,

// in index.ts chartHeader
marginBottom: variables.chartHeaderMargin,

If the intent is truly to keep the pre-bump spacing, add a comment explaining why this section must stay at 16 while sectionMargin is 20.

Reviewed at: b5869e4 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.

Expand Down
2 changes: 1 addition & 1 deletion src/styles/variables.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ export default {
modalRightDockedZIndex: 9997,
modalLowestZIndex: 9996,
workspaceTypeIconWidth: 34,
sectionMargin: 16,
sectionMargin: 20,
workspaceSectionMaxWidth: 680,
sectionIllustrationHeight: 220,
tripsIllustrationW: 168,
Expand Down
Loading