Skip to content

[CP Staging] Remove TOP_MERCHANTS from HOME_INSIGHT_KEYS - #98354

Merged
mountiny merged 1 commit into
Expensify:mainfrom
ZhenjaHorbach:zhenjahorbach/98331-hide-top-merchants-insight
Aug 12, 2026
Merged

[CP Staging] Remove TOP_MERCHANTS from HOME_INSIGHT_KEYS#98354
mountiny merged 1 commit into
Expensify:mainfrom
ZhenjaHorbach:zhenjahorbach/98331-hide-top-merchants-insight

Conversation

@ZhenjaHorbach

@ZhenjaHorbach ZhenjaHorbach commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #98331
PROPOSAL:

Tests

QA Steps

  1. Open the app and go to Home.
  2. Scroll down to the Insights section.
  3. Tap the insight title next to the chevron to open the insight switcher dropdown.
  4. Verify that Top merchants is not present in the dropdown.
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
2026-08-11.21.16.22.mov

@ZhenjaHorbach ZhenjaHorbach mentioned this pull request Aug 11, 2026
Closed
1 of 7 tasks
@codecov

codecov Bot commented Aug 11, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...ages/home/InsightsSection/useHomeInsightConfigs.ts 11.11% <100.00%> (ø)
... and 17 files with indirect coverage changes

@mountiny
mountiny marked this pull request as ready for review August 12, 2026 09:00
@mountiny
mountiny requested review from a team as code owners August 12, 2026 09:00
@melvin-bot
melvin-bot Bot requested review from QichenZhu and heyjennahay August 12, 2026 09:00
@melvin-bot

melvin-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team August 12, 2026 09:00
@mountiny

mountiny commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@mountiny mountiny mentioned this pull request Aug 12, 2026
Closed
41 of 43 tasks
@mountiny mountiny changed the title Remove TOP_MERCHANTS from HOME_INSIGHT_KEYS [CP STaging] Remove TOP_MERCHANTS from HOME_INSIGHT_KEYS Aug 12, 2026
@mountiny
mountiny removed the request for review from QichenZhu August 12, 2026 09:00
mountiny
mountiny approved these changes Aug 12, 2026
View reviewed changes

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mountiny mountiny changed the title [CP STaging] Remove TOP_MERCHANTS from HOME_INSIGHT_KEYS [CP Staging] Remove TOP_MERCHANTS from HOME_INSIGHT_KEYS Aug 12, 2026
@mountiny
mountiny merged commit c79006b into Expensify:main Aug 12, 2026
43 of 44 checks passed
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify pushed a commit that referenced this pull request Aug 12, 2026
@mountiny @OSBotify
Merge pull request #98354 from ZhenjaHorbach/zhenjahorbach/98331-hide…
07818d7 
…-top-merchants-insight

(cherry picked from commit c79006b)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 12, 2026
@OSBotify OSBotify mentioned this pull request Aug 12, 2026
Closed
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #98354.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c79006b-d34dd40-f73b864fe9430f0877f73c1edf65eda554a60b0a/index.html https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c79006b-d34dd40-75167cba0178737f1346038362bdac40cd5f1061/index.html
Android iOS
Web 🕸️
https://98354.pr-testing.expensify.com
Web

👀 View the workflow run that generated this build 👀

@OSBotify

OSBotify commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.52-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

No help site changes required

This PR removes TOP_MERCHANTS from HOME_INSIGHT_KEYS, which only hides Top merchants from the Home page's Insights switcher dropdown — a scoped fix for the iOS crash in Expensify/App#98331. It does not remove the Top Merchants insight from the app.

Top merchants is still fully available in the Spend tab Insights section, which is exactly where the help articles tell users to find it:

The Expensify-Home-Overview article does not document a Home Insights switcher or list Top Merchants on Home, so nothing there is affected either.

Since no public-facing behavior described in App/docs/articles changed, no draft docs PR is needed.

@ZhenjaHorbach, no help site PR was created because no docs changes are required. Please confirm this assessment reflects the current behavior — if you believe a docs update is needed, let me know and I'll create the draft PR.

@OSBotify

OSBotify commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.52-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Help site review: no changes required ✅

I reviewed this PR against the help site articles in App/docs/articles and no docs updates are needed.

Why: This PR only removes TOP_MERCHANTS from HOME_INSIGHT_KEYS in useHomeInsightConfigs.ts, so Top merchants no longer appears in the Home insight switcher dropdown (the crash fix for Expensify/App#98331). The Top Merchants report itself is not removed — it's still surfaced through the Spend tab's Insights via SearchUIUtils.ts, which this PR doesn't touch.

The relevant help articles describe accessing Top Merchants via the Spend navigation, and that path is unchanged:

Since no help article documents the specific list of insights in the Home page switcher, and the Top Merchants report remains available via the Spend tab, there's nothing to update. No draft help site PR was created.

@ZhenjaHorbach, if you'd still like a docs change here (for example, documenting the Home insight switcher explicitly), let me know and I'll open one.

@OSBotify

OSBotify commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

OSBotify commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.53-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

I've re-reviewed and my conclusion is unchanged: no help site changes are required (see my earlier review).

This PR only removes TOP_MERCHANTS from HOME_INSIGHT_KEYS, which hides Top merchants from the Home insight switcher (the crash fix for Expensify/App#98331). The Top Merchants report is still fully available via the Spend tab → Insights (SearchUIUtils.ts is untouched), and that's exactly the access path the help articles describe — so View-the-Top-Merchants-report.md and How-to-Use-Insights-in-Expensify.md remain accurate. No article documents the Home insight switcher's item list, so there's nothing to update and no draft PR was created.

@ZhenjaHorbach, if you'd still like a docs change here (e.g. explicitly documenting the Home insight switcher), let me know and I'll open one.

@mhawryluk mhawryluk mentioned this pull request Aug 13, 2026
Merged
38 tasks done
@OSBotify

OSBotify commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.53-10 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes
@heyjennahay heyjennahay Awaiting requested review from heyjennahay

Assignees

@ZhenjaHorbach ZhenjaHorbach

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZhenjaHorbach @mountiny @OSBotify @MelvinBot