Skip to content

Concierge HTML tables: make the whole row clickable and align styling with other tables - #97670

Merged
marcochavezf merged 3 commits into
Expensify:mainfrom
dukenv0307:fix/97247
Aug 10, 2026
Merged

marcochavezf merged 3 commits into
Expensify:mainfrom
dukenv0307:fix/97247

Conversation

@dukenv0307

@dukenv0307 dukenv0307 commented Aug 3, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

If a table's links all sit in one column, that column's link becomes the row's link:

  1. TableRenderer scans the table body once. If every link lives in a single column, that column index becomes the table's link column. No links, or links spread across columns → no link column, and the table renders exactly as before.
  2. Each body row in such a table takes its link column cell's href as the row's destination, and renders as a pressable: press opens the link, hover highlights the row, and a chevron sits at the row end. Long press still opens the comment context menu.
  3. The link column's anchor renders as plain text, since the row is now the thing that navigates — no link color, no second target inside the row.
  4. Rows in that table with no link stay static, but still reserve the chevron width so columns line up.

Fixed Issues

$ #97247
PROPOSAL:

Tests

  1. Go to Concierge chat
  2. Ask the question Show my June 2026 expenses sorted by amount
  3. Wait until the concierge responds
  4. Verify the table is shown in this response
  5. Verify that the row is clickable and we don't show the link in the merchant column
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as above

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-03.at.4.30.56.PM.mov

@dukenv0307
dukenv0307 marked this pull request as ready for review August 3, 2026 09:39
@dukenv0307
dukenv0307 requested review from a team as code owners August 3, 2026 09:39
@melvin-bot
melvin-bot Bot requested review from daledah and flaviadefaria and removed request for a team August 3, 2026 09:39
@melvin-bot

melvin-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 3, 2026 09:39
@codecov

codecov Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.81% <ø> (ø)
...neProvider/HTMLRenderers/TableLinkColumnContext.ts 100.00% <100.00%> (ø)
...s/HTMLEngineProvider/HTMLRenderers/TableRowLink.ts 100.00% <100.00%> (ø)
src/styles/index.ts 64.50% <ø> (+1.50%) ⬆️
src/styles/variables.ts 100.00% <ø> (ø)
...TMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx 73.52% <66.66%> (-0.32%) ⬇️
...HTMLEngineProvider/HTMLRenderers/TableRenderer.tsx 0.00% <0.00%> (ø)
...LEngineProvider/HTMLRenderers/TableRowRenderer.tsx 0.00% <0.00%> (ø)
... and 320 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a2c3acc008

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/TableRowLink.ts Outdated
Comment thread src/components/HTMLEngineProvider/HTMLRenderers/TableRowLink.ts
@shawnborton

Copy link
Copy Markdown
Contributor

Is the chevron here using the same color/opacity as the row chevrons we use elsewhere on tables?

@daledah

daledah commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
Screen.Recording.2026-08-04.at.01.13.30.mov

When I long-press a row in this table, it doesn't show the disabled state like it does in the other tables.

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/TableRowRenderer.tsx Outdated
@daledah

daledah commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@dukenv0307 please fix the failing ESLint check

@dukenv0307

Copy link
Copy Markdown
Contributor Author

Is the chevron here using the same color/opacity as the row chevrons we use elsewhere on tables?

Yes

icon: icons.ArrowRight
fill: theme.icon
size: variables.iconSizeNormal (20) both axes
opacity: !hovered && styles.opacitySemiTransparent (0.5 → solid on hover)

@dukenv0307

Copy link
Copy Markdown
Contributor Author

@daledah What do you mean by disabled state?

@daledah

daledah commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@daledah What do you mean by disabled state?

@dukenv0307 I mean that when I long-press a row in the table, it doesn't show the pressed/disabled visual state (text and background color change) like other tables in the app do.

@dukenv0307

Copy link
Copy Markdown
Contributor Author

like other tables in the app do.

@daledah are you sure? I don't see it in other places like WS -> Members or WS -> Category

@daledah

daledah commented Aug 5, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android.mov
Android: mWeb Chrome
android-mweb.mov
iOS: HybridApp
Screen.Recording.2026-08-05.at.10.46.14.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov

@daledah daledah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot

melvin-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #97247 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@melvin-bot
melvin-bot Bot requested a review from marcochavezf August 5, 2026 03:47
@dannymcclain

Copy link
Copy Markdown
Contributor

Is this ready for @Expensify/design review? Shall we make an ad hoc build?

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@dukenv0307

Copy link
Copy Markdown
Contributor Author

@marcaaron all yours!

@marcochavezf marcochavezf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcochavezf marcochavezf reopened this Aug 10, 2026
@marcochavezf
marcochavezf merged commit 323fb4c into Expensify:main Aug 10, 2026
42 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.52-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: no changes required

I reviewed the changes in this PR against App/docs/articles and no help site updates are needed.

Why: This PR is a purely presentational/interaction enhancement to how Concierge's HTML expense tables render in chat — when every link in a table sits in one column, the whole row becomes pressable (press opens the linked expense, hover highlights the row, a chevron sits at the row end), the redundant per-cell link renders as plain text, and the styling is aligned with other tables. It doesn't add or change any documented, user-facing capability.

The most relevant article, How Concierge Analyzes Spend, documents what you can ask Concierge about your expenses and where it answers — it deliberately does not document the exact message/table format ("The format, frequency, and content of these messages may change over time"). Nothing in it, or in any other article under docs/articles, describes the table rendering format, so no existing content becomes inaccurate and this level of rendering/interaction polish isn't something the help site documents.

Because no changes are required, I did not create a draft help site PR.

@dukenv0307, if you believe a help article should now call out that Concierge expense tables are clickable (e.g. "tap a row to open the expense"), let me know and I'll draft a PR to add it.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants