Repository navigation
Concierge HTML tables: make the whole row clickable and align styling with other tables - #97670
Conversation
… with other tables
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2c3acc008
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Is the chevron here using the same color/opacity as the row chevrons we use elsewhere on tables? |
Screen.Recording.2026-08-04.at.01.13.30.movWhen I long-press a row in this table, it doesn't show the disabled state like it does in the other tables. |
|
@dukenv0307 please fix the failing ESLint check |
Yes icon: icons.ArrowRight |
|
@daledah What do you mean by |
@dukenv0307 I mean that when I long-press a row in the table, it doesn't show the pressed/disabled visual state (text and background color change) like other tables in the app do. |
@daledah are you sure? I don't see it in other places like WS -> Members or WS -> Category |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid.movAndroid: mWeb Chromeandroid-mweb.moviOS: HybridAppScreen.Recording.2026-08-05.at.10.46.14.moviOS: mWeb Safariios-mweb.movMacOS: Chrome / Safariweb.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #97247 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
Is this ready for @Expensify/design review? Shall we make an ad hoc build? |
|
🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
@marcaaron all yours! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 marcochavezf has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.4.52-0 🚀
|
|
🤖 Help site review: no changes required I reviewed the changes in this PR against Why: This PR is a purely presentational/interaction enhancement to how Concierge's HTML expense tables render in chat — when every link in a table sits in one column, the whole row becomes pressable (press opens the linked expense, hover highlights the row, a chevron sits at the row end), the redundant per-cell link renders as plain text, and the styling is aligned with other tables. It doesn't add or change any documented, user-facing capability. The most relevant article, How Concierge Analyzes Spend, documents what you can ask Concierge about your expenses and where it answers — it deliberately does not document the exact message/table format ("The format, frequency, and content of these messages may change over time"). Nothing in it, or in any other article under Because no changes are required, I did not create a draft help site PR. @dukenv0307, if you believe a help article should now call out that Concierge expense tables are clickable (e.g. "tap a row to open the expense"), let me know and I'll draft a PR to add it. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
If a table's links all sit in one column, that column's link becomes the row's link:
Fixed Issues
$ #97247
PROPOSAL:
Tests
Offline tests
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-03.at.4.30.56.PM.mov