Fix missing report export templates by ShridharGoel · Pull Request #97484 · Expensify/App

ShridharGoel · 2026-07-30T15:14:11Z

Explanation of Change

Only treat selected UI groups as grouped exports when the search has an explicit groupBy. Report rows also use groups internally, but selecting them should still show report export templates.

Fixed Issues

$ #97431
PROPOSAL:

Tests

Open Spend > Reports.
Select two reports from different workspaces.
Open the selected-items menu and choose Export.
Verify Current view, Basic export, All Data - expense level, All Data - report level, and available custom templates appear.
Open Spend > Expenses and group expenses by category or member.
Select a full group and open Export.
Verify unsupported template exports remain hidden and Current view remains available.

Verify that no errors appear in the JS console

Offline tests

Repeat the Tests steps while offline. Verify the same export options appear because the menu is built locally.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2026-07-30.at.11.37.20.PM.mov

melvin-bot · 2026-07-30T15:23:41Z

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

thelullabyy · 2026-07-30T17:26:18Z

@ShridharGoel Looks like you forgot to add recordings. Please add recordings on platforms

thelullabyy · 2026-07-30T17:26:26Z

@codex review

chatgpt-codex-connector · 2026-07-30T17:32:49Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 0188a517ad

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

thelullabyy · 2026-07-30T18:23:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

…e-options-97431 Fix missing report export templates (cherry picked from commit 8f98cf6) (cherry-picked to staging by marcaaron)

OSBotify · 2026-07-30T21:07:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-07-30T21:49:52Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.46-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-30T21:52:29Z

🤖 Help site review: no docs changes required.

This PR is a regression fix, not a behavior change. It corrects useSearchBulkActions.ts:1615 so that selecting report rows is only treated as a "grouped export" when the search has an explicit groupBy. The effect is to restore the report export templates (Basic export, All Data - expense level, All Data - report level, and custom templates) that were incorrectly hidden when selecting multiple reports on Spend > Reports — exactly the behavior described in issue #97431.

That intended behavior is already documented correctly in How to Export Reports:

The How to export multiple reports flow already lists choosing an export template from the menu after selecting reports.
The What export templates can I choose from? section already lists Basic export, All Data - expense level, All Data - report level, and custom templates.
The note that Export current view is not available when a Group by filter is applied is also already present.

Since the fix makes the app match what the help site already says (rather than introducing anything new to the UI, labels, or flows), no updates to App/docs/articles are needed, so I have not opened a draft help site PR.

If you'd still like a targeted wording/clarity pass on the export-templates article, let me know and I'll open a draft PR for it.

github-actions · 2026-07-30T22:03:50Z

🚧 marcaaron has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-30T22:10:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97484.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-8f98cf6b4bf-e786e1f-93f7e394b35352b494ceb728a48bca106e11cfcd/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-8f98cf6-e786e1f-1fad6dea69872d09ca4b05342d74d7f4f84af402/index.html

Web 🕸️
https://97484.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-30T22:48:21Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-30T22:50:44Z

🤖 I already reviewed this and my conclusion is unchanged: no help site changes are required, so no draft PR was opened. See my earlier comment for the full reasoning: #97484 (comment)

In short, this PR is a regression fix that restores the report export templates (Basic export, All Data - expense level, All Data - report level, and custom templates) on Spend > Reports — the behavior already documented correctly in How to Export Reports. Nothing in App/docs/articles needs updating.

If you'd like a wording/clarity pass on that article regardless, reply and I'll open a draft PR for it.

IuliiaHerets · 2026-07-31T07:06:44Z

Issue is not reproducible on Windows 11 / Chrome in v9.4.46-10

bandicam.2026-07-31.14-03-30-702.mp4

OSBotify · 2026-07-31T07:38:44Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

OSBotify · 2026-07-31T07:56:31Z

🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.47-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-08-01T02:48:07Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.47-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

fix(search): show report export templates

9d82d0c

melvin-bot Bot assigned ShridharGoel Jul 30, 2026

test(search): cover grouped export templates

0188a51

ShridharGoel marked this pull request as ready for review July 30, 2026 15:23

ShridharGoel requested review from a team as code owners July 30, 2026 15:23

melvin-bot Bot requested review from thelullabyy and removed request for a team July 30, 2026 15:23

melvin-bot Bot requested review from flaviadefaria and removed request for a team July 30, 2026 15:23

JS00001 approved these changes Jul 30, 2026

View reviewed changes

thelullabyy approved these changes Jul 30, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 July 30, 2026 19:15

marcaaron approved these changes Jul 30, 2026

View reviewed changes

marcaaron merged commit 8f98cf6 into Expensify:main Jul 30, 2026
38 of 39 checks passed

OSBotify pushed a commit that referenced this pull request Jul 30, 2026

Merge pull request #97484 from ShridharGoel/fix-report-export-templat…

74d73d4

…e-options-97431 Fix missing report export templates (cherry picked from commit 8f98cf6) (cherry-picked to staging by marcaaron)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 30, 2026

OSBotify mentioned this pull request Jul 30, 2026

Deploy Checklist: New Expensify 2026-07-29 #97375

Closed

melvin-bot Bot mentioned this pull request Jul 31, 2026

[Due for payment 2026-08-07] Export - All Data - expense level, All Data - report level options are missing #97431

Closed

1 of 7 tasks

Conversation

ShridharGoel commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 30, 2026

Uh oh!

thelullabyy commented Jul 30, 2026

Uh oh!

thelullabyy commented Jul 30, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 30, 2026

Uh oh!

thelullabyy commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jul 30, 2026

Uh oh!

OSBotify commented Jul 30, 2026

Uh oh!

MelvinBot commented Jul 30, 2026

Uh oh!

github-actions Bot commented Jul 30, 2026

Uh oh!

github-actions Bot commented Jul 30, 2026

Uh oh!

OSBotify commented Jul 30, 2026

Uh oh!

MelvinBot commented Jul 30, 2026

Uh oh!

IuliiaHerets commented Jul 31, 2026

Uh oh!

OSBotify commented Jul 31, 2026

Uh oh!

OSBotify commented Jul 31, 2026

Uh oh!

OSBotify commented Aug 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ShridharGoel commented Jul 30, 2026 •

edited

Loading

thelullabyy commented Jul 30, 2026 •

edited

Loading