Make report, expense, and member values copyable by x-dev90 · Pull Request #97277 · Expensify/App

x-dev90 · 2026-07-28T20:44:11Z

Explanation of Change

This PR makes copy/paste more reliable for values shown inside interactive rows.

The issue is that many amount, report, expense, and member values are rendered inside pressable rows that disable text selection or prevent the mouse-down event needed to start native browser selection. To fix this, this PR adds an opt-in copyable text path and applies it to the issue scope:

Amount and total values
Member names/emails/custom fields
Reports and expenses page values, including report titles, report IDs, grouped headers, and list column values
Expense detail amount values covered by the issue repro

The copyable text path marks selectable values with the shared copyable text marker, applies selectable text styling, and uses shared row press handling so copyable values can start native selection without opening or selecting the row. It also updates SelectionScraper so explicitly copyable values are preserved when copying from rows that are otherwise hidden from copied content.

Fixed Issues

$ #96948
PROPOSAL: #96948 (comment)

Tests

Open an expense detail page.
Drag-select the visible amount value without opening the amount edit step.
Copy and paste the selected value somewhere else.
Verify the copied value matches the visible amount.
Open the workspace members table.
Drag-select a member name, email, or custom field value.
Copy and paste the selected value somewhere else.
Verify the copied value matches the selected member value.
Open the reports/expenses page in Spend.
Drag-select values shown in report/expense list rows, including report titles, report IDs, grouped headers, totals, dates, merchants, categories, and workspace names.
Verify the selected values can be copied without opening the report or expense row.
Repeat the reports/expenses page checks in both narrow and wide layouts.
Click rows normally without selecting text.
Verify row navigation/selection still works.

Verify that no errors appear in the JS console.

Offline tests

Same as Test

QA Steps

Same as Tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

Screenrecorder-2026-09-02-23-26-16-923.mp4

Screenrecorder-2026-09-02-21-30-58-235.mp4

iOS: Native

N/A

iOS: mWeb Safari

Screen.Recording.2026-09-03.at.3.26.53.AM.mov

Screen.Recording.2026-09-03.at.3.21.08.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2026-07-29.at.11.15.05.AM.mov

codecov · 2026-07-28T20:50:03Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	`91.52% <ø> (ø)`
src/components/AvatarWithDisplayName.tsx	`81.00% <100.00%> (+0.19%)`	⬆️
src/components/DisplayNames/index.native.tsx	`100.00% <100.00%> (ø)`
src/components/FormHelpMessage.tsx	`91.48% <100.00%> (ø)`
...cPressable/implementation/BaseGenericPressable.tsx	`81.30% <100.00%> (+0.15%)`	⬆️
...c/components/ReportActionItem/MoneyRequestView.tsx	`82.62% <100.00%> (+0.55%)`	⬆️
src/components/ReportSearchHeader/index.tsx	`100.00% <100.00%> (ø)`
src/components/Search/ExpenseFlatSearchView.tsx	`100.00% <ø> (ø)`
src/components/Search/ExpenseReportSearchView.tsx	`100.00% <ø> (ø)`
.../Search/SearchList/ListItem/BaseListItemHeader.tsx	`100.00% <ø> (ø)`
... and 50 more
... and 11 files with indirect coverage changes

melvin-bot · 2026-07-29T07:59:27Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2b6ff4f686

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

FitseTLT · 2026-07-29T12:09:13Z

@x-dev90 Pls always respond to all codex reviews if you don't agree with the review you should still state it putting 👎 reaction to the comment.

JmillsExpensify

All LGTM

FitseTLT · 2026-07-29T14:27:49Z

@codex REVIEW

x-dev90 · 2026-07-29T14:29:11Z

Hi @FitseTLT, I’ve addressed the automated review feedback and pushed the updates. Could you please take another look when you have a chance?

Thank you!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 90714cc808

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

x-dev90 · 2026-09-09T05:48:21Z

@FitseTLT, gentle bump—thanks!

JS00001 · 2026-09-10T14:11:35Z

@FitseTLT can we please try to get this one in

FitseTLT · 2026-09-10T14:56:14Z

Finalizing

FitseTLT · 2026-09-09T14:36:03Z

    }, [helperText, shouldParseHelperText, shouldEscapeText]);

-    const shouldRenderTitleAsHTML = shouldRenderAsHTML && !!title && Parser.isHTML(title);
+    const shouldRenderTitleAsHTML = shouldRenderAsHTML && !!title && Parser.hasHTMLTags(title);


Why this change?

This was introduced while fixing descriptions containing &, which were incorrectly interpreted as HTML and became unselectable on mobile web. Parser.isHTML detects both HTML entities and tags, but this rendering path only needs to detect actual HTML tags. I initially used an inline check, then moved the logic to Parser.hasHTMLTags in response to MelvinBot’s feedback.

I explained this in this comment.
thank you!

But that doesn't solve the problem from the root cause because now mark down description is not selectable on mobile.

I addressed this issue. Expense descriptions containing Markdown formatting, such as bold text, are now selectable on mobile web while preserving existing native, desktop, and link-handling behavio:

Screenrecorder-2026-09-12-18-39-32-110.mp4

FitseTLT · 2026-09-10T13:38:23Z

+                                                style={[
+                                                    styles.flexRow,
+                                                    StyleUtils.getMenuItemTextContainerStyle(isCompact),
+                                                    !hasPressableRightComponent && !isTitleSelectable && styles.pointerEventsNone,


What is the purpose of the change?

This supports the separate isTitleSelectable behavior introduced following your earlier feedback. During Safari testing, I found that pointerEventsNone prevented selectable titles from receiving native selection gestures, so it is skipped only for opted-in selectable titles. Other MenuItems retain their existing behavior.

Okay but I was confused because it is applied to the badge compoent 😕 ???

FitseTLT · 2026-09-10T23:04:35Z

BUG

2026-09-10.18-42-21.mp4

JS00001 · 2026-09-11T11:22:39Z

conflicts

x-dev90 · 2026-09-11T11:40:07Z

BUG

2026-09-10.18-42-21.mp4

Addressed by clearing the active text selection before applying a new grouping, preventing it from expanding across the regrouped rows.

Screencast.From.2026-09-11.16-06-46.mp4

x-dev90 · 2026-09-11T11:51:16Z

@FitseTLT I’ve addressed all your feedback. Could you please review the latest changes? Thank you!

FitseTLT · 2026-09-11T14:47:45Z

@x-dev90 still conflicts

FitseTLT · 2026-09-11T16:32:51Z

BUG: Map is getting copied (and map is selectable on desktop web )

2026-09-11.19-31-05.mp4

FitseTLT · 2026-09-11T17:40:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

x-dev90 · 2026-09-11T18:06:51Z

BUG: Map is getting copied (and map is selectable on desktop web )

2026-09-11.19-31-05.mp4

@FitseTLT, addressed thanks!

Screencast.From.2026-09-11.22-31-24.mp4

Screenrecorder-2026-09-11-22-30-49-272.mp4

x-dev90 · 2026-09-11T18:46:58Z

The action failure is not related to the code changes in this PR.

FitseTLT · 2026-09-11T18:54:06Z

there are other comments unaddressed

x-dev90 · 2026-09-12T05:33:33Z

I found and addressed this bug.
Verification steps:

Log in as User B on Android Chrome mWeb.
Open the report shared by User A.
Open the expense details.
Long-press the Attendees name.
Verify native text selection appears and the Expensify “Copy to clipboard” sheet does not open.

Before:

Screen.Recording.2026-09-11.at.6.33.56.PM.mov

After:

Screenrecorder-2026-09-12-09-55-36-360.mp4

Make report, expense, and member values copyable

b263311

melvin-bot Bot assigned x-dev90 Jul 28, 2026

x-dev90 added 3 commits July 29, 2026 08:41

Merge branch 'main' into fix/96948-copyable-row-values

876076e

Fix copyable expense row compiler regression

358e890

Fix copyable row lint regressions

2b6ff4f

x-dev90 marked this pull request as ready for review July 29, 2026 07:59

x-dev90 requested review from a team as code owners July 29, 2026 07:59

melvin-bot Bot requested review from FitseTLT and removed request for a team July 29, 2026 07:59

melvin-bot Bot requested review from JmillsExpensify and removed request for a team July 29, 2026 07:59

github-actions Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread src/components/TextWithTooltip/selection.ts Outdated

github-actions Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread src/components/TextWithTooltip/selection.ts Outdated

github-actions Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread src/libs/SelectionScraper/index.ts Outdated

github-actions Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread src/components/Search/SearchList/ListItem/TransactionGroupListItem.tsx Outdated

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread src/components/MenuItem.tsx Outdated

x-dev90 added 3 commits July 29, 2026 17:45

Merge branch 'main' into fix/96948-copyable-row-values

4eaa7f2

Document copyable text selection helpers

1f17abd

Centralize copyable text DOM marker

d7a86b1

JmillsExpensify previously approved these changes Jul 29, 2026

View reviewed changes

Extract copyable row press handling

dc2bdef

x-dev90 dismissed JmillsExpensify’s stale review via dc2bdef July 29, 2026 14:09

Remove unused copyable selection exports

90714cc

chatgpt-codex-connector Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread src/components/MoneyRequestReportView/MoneyRequestReportTransactionItem.tsx Outdated

Merge branch 'main' into fix/96948-copyable-row-values

7eb522a

Merge branch 'main' into fix/96948-copyable-row-values

932002d

FitseTLT reviewed Sep 10, 2026

View reviewed changes

x-dev90 added 3 commits September 11, 2026 10:55

fix: preserve default trip field selection behavior

cccf241

chore: remove redundant report header comment

0dfac7d

refactor: remove obsolete selection content cleanup

476a6a9

fix: clear text selection when changing expense grouping

e1881bb

Merge branch 'main' into fix/96948-copyable-row-values

a0f56b5

Merge branch 'main' into fix/96948-copyable-row-values

6f70f2c

x-dev90 added 2 commits September 11, 2026 22:20

fix: exclude map receipts from copied expense rows

de02363

fix: exclude receipt thumbnails from copied expense rows

2b2c4c9

Merge branch 'main' into fix/96948-copyable-row-values

e2e8b2b

x-dev90 added 2 commits September 12, 2026 09:13

fix: exclude distance hint text from expense detail copy

137acf1

fix: suppress copy sheet for selectable attendee pills

df6d1be

x-dev90 added 2 commits September 12, 2026 18:12

Merge branch 'main' into fix/96948-copyable-row-values

f2e0c21

fix: enable formatted expense description selection on mobile web

c2cb147

Uh oh!

Conversation

x-dev90 commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

FitseTLT commented Jul 29, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

FitseTLT commented Jul 29, 2026

Uh oh!

x-dev90 commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

x-dev90 commented Sep 9, 2026

Uh oh!

JS00001 commented Sep 10, 2026

Uh oh!

FitseTLT commented Sep 10, 2026

Uh oh!

FitseTLT Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

x-dev90 Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

x-dev90 Sep 12, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

x-dev90 Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

FitseTLT Sep 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FitseTLT commented Sep 10, 2026

Uh oh!

JS00001 commented Sep 11, 2026

Uh oh!

x-dev90 commented Sep 11, 2026

x-dev90 commented Jul 28, 2026 •

edited

Loading

codecov Bot commented Jul 28, 2026 •

edited by github-actions Bot

Loading