Share extension: pre-mount destination report and create expense before reveal transition by jmgraa · Pull Request #97242 · Expensify/App

jmgraa · 2026-07-28T13:36:44Z

Explanation of Change

Before this change, submitting a shared receipt could briefly show the Inbox behind the share modal before the destination chat appeared on top - a visible flash during dismiss.

SubmitDetailsPage now handles two navigation strategies based on layout and report state:

Narrow layout: Pre-mounts the destination report behind the modal (when it already exists in Onyx) so the correct chat is ready when the modal closes.

Wide layout (tablets/desktop): Reveals the destination report on top of the modal first, then dismisses the modal after the animation completes.

Both strategies keep the confirm button in loading state until navigation is safe. When the destination report doesn't exist yet (new recipient), the page waits for the optimistic report to land in Onyx before navigating - with fallback timers (500ms if ID changes, 5s absolute timeout) to prevent indefinite hangs.

The expense is created immediately on submit (not after the reveal animation), and cleanup skips a second navigation (shouldNavigate: false) since reveal/pre-mount already handles routing. Stale tracking spans are cancelled before creation to avoid lifecycle conflicts, improving telemetry accuracy.

Fixed Issues

$ #97667
PROPOSAL:

Tests

Share extension with existing recipient
- Share a receipt/image to Expensify via share extension
- Select an existing contact as recipient
- Verify confirm button shows loading state briefly, then navigates to the report
Share extension with new recipient
- Share a receipt/image via share extension
- Select a new recipient (first-time conversation)
- Verify destination report doesn't exist yet (pre-mount disabled)
- Verify confirm button stays in loading state until optimistic report lands from backend
- Verify navigation completes to newly created report within 5 seconds
Share extension with destination already topmost
- Open a report, then trigger share extension for the same recipient
- Verify standard navigation flow works correctly

Repeat tests 1-3 both on narrow and wide layout

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

iOS: Native

ios.mov

codecov · 2026-07-29T07:53:16Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...on/helpers/cleanupAndNavigateAfterExpenseCreate.ts	`100.00% <100.00%> (ø)`
src/pages/Share/SubmitDetailsPage.tsx	`90.18% <90.38%> (+1.68%)`	⬆️
... and 7 files with indirect coverage changes

JakubKorytko

the pre-mount idea is right, and the refactor is clean 🎉

Main thing: this re-does what the manual flow already has (getSubmitExpensePreMountDestinationRoute + handleReportPreInsert + usePreMountDestination) and drops the stability guard, which I think breaks the pre-mount. Details on the preMountDestinationRoute line.

On telemetry: ManualSubmitToDestinationVisible can't regress here - thank you for that haha. Share never calls startTracking, so the span is never started and every touchpoint is behind isTracking(). But that also means the whole flow is unmeasured, so the win this PR claims isn't verifiable, added a more precise comment in code.

Three behaviour changes also look inherited rather than decided: Search tab, wide layout, and report-already-in-RHP.

…yout

…ountDestinationRoute

JakubKorytko

the pre-insert gates and optimisticChatReportID close most of the last round, so what's left is mainly the pending-navigation branch (still the one that can park the modal in a loading state with nothing to resolve it) plus a few leftovers from round one. Otherwise, LGTM!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 19d8139deb

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…reate-expense # Conflicts: # src/pages/Share/SubmitDetailsPage.tsx

ChavdaSachin · 2026-08-05T05:37:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2026-08-05.at.11.47.30.AM.mov

Screen.Recording.2026-08-07.at.11.12.06.AM.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

ChavdaSachin · 2026-08-05T06:31:11Z

BUG: clicking the share button multiple times shares the files multiple times

Video

Screen.Recording.2026-08-05.at.11.48.30.AM.mov

jmgraa · 2026-08-05T08:58:27Z

This issue is reproducible on main and was not introduced by these changes. It is also out of scope for this PR.

ChavdaSachin

LGTM! ✅

github-actions · 2026-08-10T13:07:47Z

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-08-10T13:11:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-08-10T13:14:13Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97242.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6d0cb5c9d54-7e8bfd0-a5a8bda8bb2b72f67f33fe548ed16d975f9cf223/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6d0cb5c-7e8bfd0-3077419cfa767886df1d63bcc1ff29089b823598/index.html

Web 🕸️
https://97242.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-10T22:07:18Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.52-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-08-10T22:10:24Z

🤖 No help site changes required.

I reviewed the changes in this PR against Expensify's help site content under docs/articles, and no updates are needed.

Why

What the PR changes: This is an internal navigation/animation-timing fix for the share extension flow. It reworks how SubmitDetailsPage reveals or pre-mounts the destination report so the Inbox no longer flashes behind the share modal during dismiss, and keeps the confirm button in a loading state until navigation is safe.

Changed files are all implementation/tests — no user-facing feature, label, setting, or workflow was added or renamed:

src/pages/Share/SubmitDetailsPage.tsx
src/libs/Navigation/helpers/cleanupAndNavigateAfterExpenseCreate.ts
tests/ui/SubmitDetailsPageTest.tsx, tests/unit/cleanupAndNavigateAfterExpenseCreateTest.ts

End-user behavior is unchanged: share a receipt → the expense is created → you land on the destination chat. The only difference is a smoother transition (no visible flash).

No affected docs: a search of docs/articles found no help articles that document the share extension / "share a receipt to Expensify" flow, so there is nothing to keep in sync with this change.

Since no changes are required, I did not create a draft help site PR.

IuliiaHerets · 2026-08-11T19:05:53Z

Hi @jmgraa. One of our four testers can still reproduce the original issue. Expensify doesn’t open when sharing an image from the Gallery or Files.
iPhone 12 / iOS 26.3.1

VID-20260811-WA0002.mp4

cc @mjasikowski @heyjennahay @JakubKorytko

jmgraa · 2026-08-12T07:27:55Z

Hi! Thanks for testing. I'm a bit disoriented by the video. My PR fixes a visual flash after submitting a receipt, whereas the video shows the share extension failing to open on launch.

Could you share the exact steps to reproduce this and check if it's also happening on main?

IuliiaHerets · 2026-08-12T08:04:09Z

Hi @jmgraa. Our testers have different results.

It works as expected on the latest build 52-8.

ScreenRecording_08-12-2026.14-52-54_1.MP4

ScreenRecording_08-12-2026.14-51-46_1.MP4

When tapping on the Expensify app, nothing happens. A pop-up briefly appears and then disappears, and the user remains on the same app selection screen.

VID-20260811-WA0002.1.mp4

OSBotify · 2026-08-12T18:17:13Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

jmgraa · 2026-08-17T17:23:01Z

As discussed with @IuliiaHerets, the bug mentioned above was just a one-off on a single device and couldn't be reproduced. There are no other cases or steps to trigger it

jmgraa added 2 commits July 28, 2026 14:47

handle pre-mount destination

8375f84

create expense before reveal transition

954c5cf

melvin-bot Bot assigned jmgraa Jul 28, 2026

jmgraa added 3 commits July 28, 2026 16:33

delay navigation until next screen is ready when 1:1 chat doesn't exist

5f2a408

mock getReportOrDraftReport in SubmitDetailsPageTest

bb0a638

expect shouldNavigate in cleanup nav test

754d5c1

jmgraa added 2 commits July 29, 2026 10:38

clarify expense creation timing during reveal transition

acdd657

prevent dual navigation race condition during optimistic report landing

d415c6d

JakubKorytko reviewed Jul 29, 2026

View reviewed changes

jmgraa added 17 commits July 30, 2026 11:51

sync cleanup transition wait with shouldNavigate

5000852

move draft skip comment to getReportOrDraftReport call

9926795

add navigationReportID parameter for consistent navigation

d9035d8

run expense creation before revealing

ce543eb

passing parameters when shouldNavigate is false

7d736c8

add two tests for race conditions

10fdcaf

add test for narrow layout and rename old one

ad9e965

mock getTopmostReportId in resetNavigationMocksForSubmitDetailsPageTests

1a336ea

add test to handle confirm before scheduleWhenIdle fires in narrow la…

343b12a

…yout

change default layout to narrow

ad3c671

remove redundant mocks and lean on the onyx seeding

086951e

add optimisticChatReportID parameter to requestMoney

b34ffd3

track reveal state

346f2dd

cancel tracking before reveal

a482333

perform cleanup after reveal's afterTransition

5d127a9

fix preMountDestinationRoute conditions based on getSubmitExpensePreM…

436748a

…ountDestinationRoute

add eslint-disable for console.warn

c8d82dc

JakubKorytko approved these changes Jul 31, 2026

View reviewed changes

jmgraa added 2 commits July 31, 2026 13:56

replace console.warn with Log.warn

95f52d3

update documentation for telemetry span ownership

f7308b0

melvin-bot Bot requested review from heyjennahay and removed request for a team August 3, 2026 09:38

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread src/pages/Share/SubmitDetailsPage.tsx Outdated

github-actions Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread src/pages/Share/SubmitDetailsPage.tsx Outdated

jmgraa added 3 commits August 3, 2026 14:21

pass routeReportID instead of reportOrAccountID as optimistic chat IDs

f0f70a4

use single reveal function

6c8c738

Merge remote-tracking branch 'upstream' into jmgraa/share-extension-c…

1e152ce

…reate-expense # Conflicts: # src/pages/Share/SubmitDetailsPage.tsx

jmgraa mentioned this pull request Aug 4, 2026

[Due for payment 2026-09-03] [Metric] [Performance] ShareExtensionOpenSubmitFlow - iOS Native Share Extension is slow and feels broken #95335

Closed

ChavdaSachin approved these changes Aug 7, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski August 7, 2026 05:41

mjasikowski approved these changes Aug 10, 2026

View reviewed changes

mjasikowski closed this Aug 10, 2026

mjasikowski reopened this Aug 10, 2026

mjasikowski merged commit 6d0cb5c into Expensify:main Aug 10, 2026
42 checks passed

OSBotify mentioned this pull request Aug 10, 2026

Deploy Checklist: New Expensify 2026-08-10 #98179

Closed

quinthar added the #quality label Aug 11, 2026

jmgraa deleted the jmgraa/share-extension-create-expense branch August 28, 2026 11:55

Conversation

jmgraa commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JakubKorytko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakubKorytko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

ChavdaSachin commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ChavdaSachin commented Aug 5, 2026

Uh oh!

jmgraa commented Aug 5, 2026

Uh oh!

ChavdaSachin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

OSBotify commented Aug 10, 2026

Uh oh!

github-actions Bot commented Aug 10, 2026

Uh oh!

OSBotify commented Aug 10, 2026

Uh oh!

MelvinBot commented Aug 10, 2026

Uh oh!

IuliiaHerets commented Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jmgraa commented Aug 12, 2026

Uh oh!

IuliiaHerets commented Aug 12, 2026

Uh oh!

OSBotify commented Aug 12, 2026

Uh oh!

jmgraa commented Aug 17, 2026

Uh oh!

jmgraa commented Jul 28, 2026 •

edited

Loading

codecov Bot commented Jul 29, 2026 •

edited by github-actions Bot

Loading

ChavdaSachin commented Aug 5, 2026 •

edited

Loading

IuliiaHerets commented Aug 11, 2026 •

edited

Loading