Fix merge navigation from Inbox opening Spend tab - #97186
mjasikowski merged 2 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01dca0c73f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppCleanShot.2026-07-28.at.16.14.05.4.mp4iOS: mWeb SafariMacOS: Chrome / SafariMerge from Spent CleanShot.2026-07-28.at.16.11.38.3.mp4Merge from Inbox CleanShot.2026-07-28.at.15.55.17.2.mp4CleanShot.2026-07-28.at.15.52.29.1.mp4 |
suneox
left a comment
There was a problem hiding this comment.
MergeTransactionsListContent is now used inside Dynamic Route, so removing isOnSearch LGTM
|
🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…end-after-inbox-merge Fix merge navigation from Inbox opening Spend tab (cherry picked from commit 3407990) (cherry-picked to staging by marcaaron)
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.45-8 🚀
|
|
🤖 I reviewed this PR against the help site articles under No help site changes are required, so I did not create a draft PR. WhyThis PR is a navigation bug fix: it removes the The relevant help article, How to Merge Duplicate Expenses, documents:
It does not document which tab/navigation destination opens after a merge, so this behavior change is not reflected in any help site content. There is nothing to update. @huult, please confirm you agree no help site update is needed here. If you think the post-merge navigation behavior should be documented, let me know and I'll draft a docs PR. |
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.45-10 🚀
|
|
🤖 I already completed this help site review above — my conclusion is unchanged: no help site changes are required, so there's no draft PR to create. This PR is a navigation bug fix (a merged expense now reopens on the tab the user started from instead of the Spend tab). The How to Merge Duplicate Expenses article documents eligibility, the merge steps, and what happens to the expense data — but not the post-merge navigation destination, so nothing there needs updating. @huult, if you'd like the post-merge navigation behavior documented, let me know and I'll draft a docs PR. Otherwise no action is needed. |
|
Chrome / v9.4.45-10 7beeae6ddcc1587e23a1590f3e6e0b1d.mp4 |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/marcaaron in version: 9.4.46-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site files in No help site changes are required. This PR is a navigation bug fix — it removes the The only related article, How to merge duplicate expenses, documents how to merge and what happens to the expense data afterward. It does not document which screen you land on after a merge, so nothing in it is made inaccurate by this change. No draft PR was created since there is nothing to update. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #97147
PROPOSAL:
Tests
Same QA step
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-28.at.12.11.28.mov