Repository navigation
[No QA] Docs updates for E/A#96912 optional Card name column for CSV import - #97143
Conversation
Co-authored-by: Justin Persaud <justinpersaud@users.noreply.github.com>
MelvinBot
added
the
HelpDot
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| 6. Choose the CSV, TXT, XLS, or XLSX file you want to upload. | ||
| 7. Enter a name for the card feed. | ||
| 8. Set your field mappings (e.g., Card Number, Date, Amount, Merchant). | ||
| 8. Set your field mappings. Map either a **Card number** or a **Card name** (at least one is required so each transaction can be matched to a card), along with **Date**, **Merchant**, **Amount**, and **Currency**. |
There was a problem hiding this comment.
Step formatting: Per HELP_AUTHORING_GUIDELINES.md Section 5, steps must be clear and action-oriented. This step packs a full explanation (the parenthetical rationale about matching) into a single numbered action, which weakens scannability. Keep the step to the action (e.g. Set your field mappings, mapping either a **Card number** or a **Card name**, along with **Date**, **Merchant**, and **Amount**.) and move the "at least one is required so each transaction can be matched" explanation to prose or the FAQ section below.
|
|
||
| ## How does matching transactions by card name work? | ||
|
|
||
| Instead of a card number, you can map a **Card name** column, and Expensify will match each transaction to the assigned card whose name matches the value in that column. If a row's card name doesn't match an assigned card, that transaction won't be imported. You only need one card-identity column, so map a **Card number** column instead if you'd rather match by number. |
There was a problem hiding this comment.
UI referencing / consistency: This sentence uses lowercase "card number" while the same UI label is written as the bold Card number column elsewhere in this section. Per HELPSITE_NAMING_CONVENTIONS.md (exact UI referencing + Deterministic Writing Rule), reference the label consistently: use Card number here to match.
HelpDot Documentation ReviewOverall AssessmentThis PR updates the company card spreadsheet import article to document that transactions can be matched by either a Card number or a Card name column (at least one required). It updates the import step, the "required columns" FAQ, and the "Oops!" error FAQ, and adds a new task-based FAQ explaining card-name matching. The changes are accurate, well-scoped to a single workflow, and improve on the prior text. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a summary review; the changes are small and self-contained. |
| 6. Choose the CSV, TXT, XLS, or XLSX file you want to upload. | ||
| 7. Enter a name for the card feed. | ||
| 8. Set your field mappings (e.g., Card Number, Date, Amount, Merchant). | ||
| 8. Set your field mappings. Map either a **Card number** or a **Card name** (at least one is required so each transaction can be matched to a card), along with **Date**, **Merchant**, **Amount**, and **Currency**. |
There was a problem hiding this comment.
Step formatting: Per HELP_AUTHORING_GUIDELINES.md Section 5, steps must be clear and action-oriented. This step packs a full explanation (the parenthetical rationale about matching) into a single numbered action, which weakens scannability. Keep the step to the action (e.g. Set your field mappings, mapping either a **Card number** or a **Card name**, along with **Date**, **Merchant**, and **Amount**.) and move the "at least one is required so each transaction can be matched" explanation to prose or the FAQ section below.
|
|
||
| ## How does matching transactions by card name work? | ||
|
|
||
| Instead of a card number, you can map a **Card name** column, and Expensify will match each transaction to the assigned card whose name matches the value in that column. If a row's card name doesn't match an assigned card, that transaction won't be imported. You only need one card-identity column, so map a **Card number** column instead if you'd rather match by number. |
There was a problem hiding this comment.
UI referencing / consistency: This sentence uses lowercase "card number" while the same UI label is written as the bold Card number column elsewhere in this section. Per HELPSITE_NAMING_CONVENTIONS.md (exact UI referencing + Deterministic Writing Rule), reference the label consistently: use Card number here to match.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 176a1894de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ## How does matching transactions by card name work? | ||
|
|
||
| Instead of a card number, you can map a **Card name** column, and Expensify will match each transaction to the assigned card whose name matches the value in that column. If a row's card name doesn't match an assigned card, that transaction won't be imported. You only need one card-identity column, so map a **Card number** column instead if you'd rather match by number. |
There was a problem hiding this comment.
For a new CSV feed, no cards are assigned when this mapping is performed; imported card identifiers are exposed as unassigned entries for assignment after upload (buildCompanyCardEntries() adds names from cardList/accountList in src/hooks/useCompanyCards.ts). Therefore, a new Card name value does not need to match an already-assigned card and is not discarded merely because it is unmatched. This FAQ may make admins believe they must pre-create or rename cards before importing; describe the value as identifying/grouping a feed card that can subsequently be assigned.
Useful? React with 👍 / 👎.
|
@MelvinBot address review feedback |
…label, correct card-name matching FAQ Co-authored-by: Justin Persaud <justinpersaud@users.noreply.github.com>
|
Addressed the review feedback in
Ready for another look. |
github-actions
Bot
changed the title
|
A preview of your ExpensifyHelp changes have been deployed to https://0c7aaea3.helpdot.pages.dev ⚡️ Updated articles: |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.46-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀
Bundle Size Analysis (Sentry): |
4 participants
Explanation of Change
Updates the help-site article Import Company Card Transactions From a Spreadsheet to reflect #96912, which adds an optional Card name column to the NewDot company-card CSV import mapping step. Card identity is now either/or — a feed can map a Card number or a Card name (at least one required), instead of always requiring a card number.
What changed in the doc
UI labels were verified against
src/languages/en.tsin #96912 — the mapping options are Card number and Card name (sentence case).Related PR
@justinpersaud, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.