Skip to content

[No QA] Docs updates for E/A#92546 multi-expense preview per-expense navigation and View button - #97142

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-92546-multi-expense-preview-nav
Closed

MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-92546-multi-expense-preview-nav

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

This documents the behavior changes from #92546 in the multi-expense Report Previews section of the Getting Started with the Spend Page article.

PR #92546 changed how the multi-expense report preview behaves:

  • Clicking an individual expense in the preview now opens that specific expense instead of the parent report. On wide screens it opens in the right-hand pane; on narrow screens it opens on top of the report so pressing back returns to the report.
  • A grey View button is now always shown in the preview's action row (alongside the role-based action button like Submit, Approve, or Pay) so the full report stays reachable.

What changed in the article

  • Updated the Preview Details action-button line to note both the role-based action button and the always-present View button.
  • Added a task-based section, How to open an expense or the report from a report preview, describing per-expense navigation and the View button.

I verified the button label against the code: it uses common.viewView.


@wildan-m, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: wildan-m <wildan-m@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 27, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#92546 multi-expense preview per-expense navigation and View button [No QA] Docs updates for E/A#92546 multi-expense preview per-expense navigation and View button Jul 27, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://f54e160b.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott self-assigned this Jul 30, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review July 30, 2026 20:26
@stephanieelliott
stephanieelliott self-requested a review as a code owner July 30, 2026 20:26

- Click an individual expense in the preview to open that expense.
- On a wide screen, the expense opens in the right-hand pane.
- On a narrow screen (mobile or mWeb), the expense opens on top of the report, so pressing back returns you to the report.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal/jargon language: "mWeb" is internal terminology and should not appear in a HelpDot article (HELP_AUTHORING_GUIDELINES.md Section 6 — "Avoid internal language"). Use plain user-facing wording, e.g. "On a narrow screen (mobile web or the mobile app)".

Also, "right-hand pane" (line 35) is internal layout jargon. Prefer describing behavior in user terms rather than the internal RHP name.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, focused documentation update to Getting-Started-with-the-Spend-Page.md, documenting behavior changes from #92546. It (1) expands the Preview Details action-button line into a role-based button and a View button, and (2) adds a task-based section, How to open an expense or the report from a report preview, covering per-expense navigation and the View button. The changes are accurate, concise, and well-aligned with the governance rules.

Scores Summary

  • Readability: 9/10 - Clear, scannable bullets. Nested lists and the wide/narrow screen distinction are easy to follow and read naturally.
  • AI Readiness: 8/10 - The new heading is task-based, starts with "How to", is feature-specific, and uses only ##. Search-friendly and retrievable.
  • Style Compliance: 9/10 - All button names correctly bolded in Sentence case (Submit, Approve, Pay, View). "right-hand pane" and the explicit wide vs. narrow (mobile or mWeb) behavior follow the Cross-Platform Clarity Rule.

Key Findings

  • Positive: The new ## How to open an expense or the report from a report preview heading fully complies with the task-based heading rule (Section 2) and satisfies the "at least one How to heading" retrieval requirement.
  • Positive: Button labels are exact, bolded, and in Sentence case per Naming Conventions. The author verified the View label against common.view in code.
  • Positive: Platform behavior differences (wide screen opens the right-hand pane; narrow screen opens on top of the report) are stated explicitly rather than assuming parity, matching the Cross-Platform Clarity Rule.
  • Minor: The instructions use "Click an individual expense" / "Click View" for behavior that also applies on mobile; consider "Select" for cross-platform consistency per the navigation phrasing guidance.

Recommendations

  • Optional: Consider "Select" instead of "Click" since the described behavior includes mobile/mWeb.
  • No blocking issues. The changes are accurate to the referenced PR and compliant with the governance files.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Getting-Started-with-the-Spend-Page.md - Compliant; minor optional phrasing suggestion.

Note: This review is based only on the proposed diff, not on unchanged content in the file.

@stephanieelliott

Copy link
Copy Markdown
Contributor

I don't think this needs to be documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants