Repository navigation
[Payment due @suneox] Fix exact merchant group exports - #97046
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd217fcfc8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@ShridharGoel Could you please provide more context for this PR since it's an internal issue? |
|
If you try steps 1-4, you'll see that both groups get exported even after selecting just "Amazon" one. This was happening because the logic was based on "includes" instead of equality. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppaz_recorder_20260727_175308.2.mp4Android: mWeb ChromeUploading CleanShot 2026-07-27 at 17.54.58.mp4… iOS: HybridAppCleanShot.2026-07-27.at.17.54.58.5.mp4iOS: mWeb SafariCleanShot.2026-07-27.at.17.47.14.4.mp4MacOS: Chrome / SafariCleanShot.2026-07-27.at.17.43.40.3.mp4 |
suneox
left a comment
There was a problem hiding this comment.
Changeset LGTM, functionality works as expected. The test failure is flaky and unrelated to these changes.
|
🎯 @suneox, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
| const filterSet = new Set<string>(orderedQuery); | ||
| const exactMatchFilterKeys = [...(query.exactMatchFilterKeys ?? [])].sort(); | ||
| if (exactMatchFilterKeys.length > 0) { | ||
| const exactMatchIdentity = `exactMatch:${exactMatchFilterKeys.join(',')}`; |
There was a problem hiding this comment.
Just internal, to have different hashes (not user-facing)
There was a problem hiding this comment.
These queries will have different hashes:
merchant:Amazon
merchant:Amazon exactMatch:merchant
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.46-0 🚀
|
Help site review — no docs changes requiredI reviewed the changes in this PR against the help site under Why: This PR is a bug fix. It makes merchant-group exports use exact-match semantics so that exporting the
Since no documentation is inaccurate or missing as a result of this change, I did not open a help site PR.
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #97532 |
Explanation of Change
Merchant group expansion and exports now keep generated merchant filters as exact matches. Normal merchant and description searches still use partial matching.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/643664
PROPOSAL:
Tests
AmazonandAmazon MarketplaceAmazongroupAmazongroupmerchant:Amazonand verify partial merchant matching still worksOffline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified that the component works as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Groups list had both "Amazon" and "Amazon Marketplace" and the export was done only for "Amazon":