[Part 21] Remove Onyx.connect from LocalePhoneNumber - #97022
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@marufsharifi Please fix the test case and recordings. |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-26.at.9.00.35.AM.mov |
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.45-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site content under No help site changes are required. This PR is an internal refactor: it removes the direct Since there are no user-facing feature, UI, label, or behavior changes, there is nothing to document or update on the help site, so I did not create a draft docs PR. @marufsharifi, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This PR removes another focused
LocalePhoneNumber.formatPhoneNumberdependency from the report action context-menu copy-message path.ContextMenuActionsno longer importsformatPhoneNumberdirectly fromLocalePhoneNumber. Instead,BaseReportActionContextMenupasses the active localizedformatPhoneNumberfromuseLocalize()through the context-menu action payload.User-facing behavior should stay the same. Copying reimbursement queued report action messages should still produce the same copied text, but this path now uses the active localized formatter so we can continue moving toward removing
Onyx.connect()fromLocalePhoneNumber.Fixed Issues
$ #66327
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screencast.From.2026-07-27.18-29-00.webm