Revert "feat: Enable react-native-nitro-fetch (V3)" - #97000
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1c13142b4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Builds expected to fail due to mobile-expensify counterpart |
|
@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
…ble-nitro-fetch-v3 Revert "feat: Enable `react-native-nitro-fetch` (V3)" (cherry picked from commit 055f6b0) (cherry-picked to staging by yuwenmemon)
|
🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.4.44-5 🚀
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🤖 No help site changes required. I reviewed the changes in this PR. It's a straight revert of #95518 ("Enable
None of this maps to any customer-facing feature, setting, tab, or button documented under @yuwenmemon, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.44-6 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.4.45-0 🚀
|
Help site review — no changes requiredI reviewed the changes in this PR against the help site content under Conclusion: No help site updates are required, and no draft PR was created. This PR is a pure revert of #95518 ("Enable
None of this changes any feature, tab, setting, button label, or documented workflow. There are no If you believe a specific user-facing behavior did change as a result of this revert (e.g. something previously documented that no longer applies), reply with the detail and I'll create the docs PR. @yuwenmemon, since no help site changes were required, there is no linked help site PR to review or mark |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/yuwenmemon in version: 9.4.46-0 🚀
|
No help site changes requiredI reviewed the changes in this PR against the help site articles under This PR reverts #95518 — re-enabling
The Expensify help site documents customer-facing product behavior (workspaces, billing, integrations, features), and none of that is affected by which native networking library backs @yuwenmemon, please confirm you agree no help site changes are required. If you believe something here does warrant a docs update, let me know what behavior changed and I'll open a draft PR. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀
Bundle Size Analysis (Sentry): |
Reverts #95518
Fixed Issues
$ #96917
$ #96933