Migrate money request destination step to dynamic routes (#83850 part 1) by suneox · Pull Request #96949 · Expensify/App

suneox · 2026-07-24T11:08:42Z

Explanation of Change

Migrate the per-diem money-request Destination step (MONEY_REQUEST_STEP_DESTINATION, wizard entry from MONEY_REQUEST.CREATE) and its edit variant (MONEY_REQUEST_STEP_DESTINATION_EDIT, entry from STEP_CONFIRMATION) from static routes to dynamic URL navigation, removing the backTo/backToReport params. The step page is renamed IOURequestStepDestination → DynamicIOURequestStepDestination; edit mode is now derived from route.name and the back path from useDynamicBackPath. Forward entries and cross-file goBack targets (Time step, report-selection step) rebuild the absolute path via createDynamicRoute on the MONEY_REQUEST_CREATE base. OldRoutes redirects cover the legacy URLs, and the dynamic suffixes are namespaced per-diem-destination/per-diem-destination-edit (dynamic paths must be globally unique across DYNAMIC_ROUTES, since react-navigation flattens them — a bare destination collides with the existing Sage Intacct suffix). Part 1 of #83850 (Time/Subrate are Parts 2/3).

Fixed Issues

$ #83850
PROPOSAL:

Tests

DYNAMIC_ROUTES.MONEY_REQUEST_STEP_DESTINATION — wizard destination step (non-edit)

Case 1.1 — Workspace select → Destination (forward entry)

Target: src/pages/iou/request/step/IOURequestStepPerDiemWorkspace.tsx:77

Precondition: ≥2 per-diem workspaces (workspace selector is shown).

Steps:

Open the app and log in.
FAB → Create expense → Per diem tab.
Select a workspace from the list.

Expected: The Destination step opens; URL ends with /start/<txn>/<rpt>/per-diem-destination (no ?backTo=), title is the tab title.

Case 1.2 — Destination back (cut suffix → start)

Steps:

From Case 1.1 (on Destination), tap the header Back button.

Expected: Returns to the Workspace select / Start screen (suffix /per-diem-destination stripped). No /not-found.

Case 1.3 — Destination → Time (forward)

Target: DynamicIOURequestStepDestination updateDestination

Steps:

On Destination, select a destination (tap a rate).

Expected: Navigates to the Time step (Time is still static in Part 1 — must work normally).

Case 1.4 — Time back → Destination (cross-file goBack)

Target: src/pages/iou/request/step/IOURequestStepTime.tsx:99

Precondition: ≥2 per-diem workspaces (hasMoreThanOnePolicyWithPerDiemEnabled), global create.

Steps:

From Case 1.3 (on Time), tap Back.

Expected: Returns to the dynamic Destination step; rates shown and selectable. No /not-found.

Case 1.5 — Report step policy change → Destination (new reportID)

Target: useReportSelectionActions.ts:165

Precondition: per-diem transaction (global create); select a report from a different policy.

Steps:

Global-create a per-diem expense; reach the Report selection step.
Select a report from a different per-diem workspace (policy changes).

Expected: Goes back to Destination with the new reportID; subrates cleared; Destination shows the new policy's rates. No /not-found.

Case 1.6 — Deep-link / refresh + OldRoutes redirect

Steps:

Open the legacy URL directly: /create/submit/destination/123/456.

Expected: Redirects to /create/submit/start/123/456/per-diem-destination; Destination opens, stack restored (back → start). ⚠️ Legacy query (?backTo=) is not preserved (append-suffix, accepted — no call site produces a query anymore).

DYNAMIC_ROUTES.MONEY_REQUEST_STEP_DESTINATION_EDIT — edit destination from Confirmation

Case 2.1 — Confirmation → edit Destination (forward entry)

Target: src/components/MoneyRequestConfirmationList/sections/PerDiemFields.tsx:111

Precondition: on the Confirmation step of a per-diem expense.

Steps:

Complete the per-diem wizard to reach Confirmation.
Tap the Destination field in the confirmation list.

Expected: Destination opens in edit mode, title = "Destination"; URL /confirmation/<txn>/<rpt>/per-diem-destination-edit.

Case 2.2 — Edit select → back to Confirmation

Steps:

From Case 2.1, select a different destination.

Expected: Returns to Confirmation (suffix /per-diem-destination-edit stripped); destination updated; subrates cleared if the destination changed.

Case 2.3 — Edit back button

Steps:

From Case 2.1, tap Back (without selecting).

Expected: Returns to Confirmation, no change.

Case 2.4 — Deep-link edit + OldRoutes redirect

Steps:

Open the legacy URL: /create/submit/destination/123/456/edit.

Expected: Redirects to /create/submit/confirmation/123/456/per-diem-destination-edit; edit mode opens on top of Confirmation.

Verify that no errors appear in the JS console

Offline tests

Same as tests — pure navigation refactor (static route → dynamic URL + OldRoutes redirect). No network/API behavior changed; offline forward/back/deep-link behavior is unchanged.

QA Steps

Test case 1: Open the per-diem Destination step from the workspace selector

Log in on an account that belongs to ≥2 workspaces with per-diem rates enabled.
Tap the FAB → Create expense → Per diem tab.
Select one of the per-diem workspaces from the "Choose a workspace" list.
Verify the Destination step opens and the browser URL ends with /per-diem-destination (no ?backTo=).
Tap the header Back button.
Verify you return to the workspace/start screen and the URL no longer contains /per-diem-destination.

Test case 2: Edit the Destination from the per-diem confirmation screen

Complete a per-diem expense through the wizard (Destination → Time → Subrate) to reach the Confirmation screen.
Tap the Destination row in the confirmation list.
Verify the Destination screen reopens in edit mode and the URL ends with /per-diem-destination-edit.
Select a different destination.
Verify you return to the Confirmation screen, the Destination value is updated, and the URL no longer contains /per-diem-destination-edit.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

CleanShot.2026-07-27.at.18.24.29.1.mp4

CleanShot.2026-07-27.at.18.29.57.1.mp4

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Case 1.1 — Workspace select → Destination (forward entry)

Case 1.2 — Destination back (cut suffix → start)

Case 1.3 — Destination → Time (forward)

Case 1.4 — Time back → Destination (cross-file goBack)

Case 1.5 — Report step policy change → Destination (new reportID)

Case 1.6 — Deep-link / refresh + OldRoutes redirect (non-edit)

Case 2.1 — Confirmation → edit Destination (forward entry)

Case 2.2 — Edit select → back to Confirmation

Case 2.3 — Edit back button

Case 2.4 — Deep-link edit + OldRoutes redirect

…3850 part 1) Migrate MONEY_REQUEST_STEP_DESTINATION (path `destination`, entry MONEY_REQUEST.CREATE) and MONEY_REQUEST_STEP_DESTINATION_EDIT (path `destination-edit`, entry STEP_CONFIRMATION) to dynamic routes, removing their static routes and the `backTo` param. - Rename IOURequestStepDestination -> DynamicIOURequestStepDestination; edit mode now derived from route.name, back path from useDynamicBackPath. - Forward entries use createDynamicRoute; cross-file goBack targets (Time, report selection) rebuild the absolute path via createDynamicRoute with the MONEY_REQUEST_CREATE base. - Add OldRoutes redirects + getMatchingNewRoute unit tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

codecov · 2026-07-24T11:15:40Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/ROUTES.ts	`22.11% <ø> (+0.07%)`	⬆️
src/SCREENS.ts	`100.00% <ø> (ø)`
...RequestConfirmationList/sections/PerDiemFields.tsx	`0.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/OldRoutes.ts	`100.00% <ø> (ø)`
src/libs/Navigation/linkingConfig/config.ts	`66.66% <ø> (ø)`
src/pages/iou/request/IOURequestStartPage.tsx	`83.78% <ø> (ø)`
...ou/request/step/IOURequestStepPerDiemWorkspace.tsx	`0.00% <ø> (ø)`
src/pages/iou/request/step/IOURequestStepTime.tsx	`0.00% <ø> (ø)`
...iou/request/step/withFullTransactionOrNotFound.tsx	`96.15% <ø> (ø)`
.../iou/request/step/withWritableReportOrNotFound.tsx	`83.87% <ø> (ø)`
... and 3 more
... and 12 files with indirect coverage changes

melvin-bot · 2026-07-27T11:15:33Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huult · 2026-07-28T06:05:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-28.at.15.14.33.mov

Screen.Recording.2026-07-28.at.15.15.42.mov

huult

LGTM.

github-actions · 2026-07-28T11:25:21Z

🚧 mjasikowski has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-28T11:29:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-28T11:30:42Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96949.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3cbdc3c2403-38e8a32-713b5bcc1ccaf913d85f6bd763c3b03fbf101ca3/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3cbdc3c-38e8a32-cae76280d03bbede296ef6cb99a8df1eaf3c35d6/index.html

Web 🕸️
https://96949.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-29T21:20:25Z

🚀 Deployed to staging by https://github.com/mjasikowski in version: 9.4.46-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-29T21:22:58Z

No help site changes are required for this PR.

This is a pure internal navigation refactor — it migrates the per-diem money-request Destination step (and its edit variant) from static routes to dynamic URL navigation, renames a component (IOURequestStepDestination → DynamicIOURequestStepDestination), removes the backTo/backToReport params, and adds OldRoutes redirects for the legacy URLs. As the PR description itself notes, this is a "pure navigation refactor (static route → dynamic URL + OldRoutes redirect). No network/API behavior changed."

The help site articles under App/docs/articles document user-facing product behavior — they don't reference internal route names, URL suffixes (e.g. per-diem-destination), or navigation internals. Nothing a user sees or does changes here, so no article needs updating. (I also confirmed there are no existing help articles that mention per-diem destination flows.)

No draft PR was created since no documentation changes are warranted, so there's no linked help site PR to review here.

@suneox, if you believe a user-facing behavior did change and warrants a docs update, let me know and I'll create the draft PR.

OSBotify · 2026-07-31T07:36:08Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned suneox Jul 24, 2026

suneox added 2 commits July 27, 2026 18:12

Merge branch 'main' into 83850-migrate-money-request-part-1-suneox

519acc7

Merge branch 'main' into 83850-migrate-money-request-part-1-suneox

2809429

suneox marked this pull request as ready for review July 27, 2026 11:15

suneox requested review from a team as code owners July 27, 2026 11:15

melvin-bot Bot requested review from heyjennahay and huult and removed request for a team July 27, 2026 11:15

melvin-bot Bot removed the request for review from a team July 27, 2026 11:15

huult approved these changes Jul 28, 2026

View reviewed changes

melvin-bot Bot requested a review from mjasikowski July 28, 2026 08:20

mjasikowski approved these changes Jul 28, 2026

View reviewed changes

mjasikowski merged commit 3cbdc3c into Expensify:main Jul 28, 2026
39 checks passed

OSBotify mentioned this pull request Jul 29, 2026

Deploy Checklist: New Expensify 2026-07-29 #97375

Closed

melvin-bot Bot mentioned this pull request Jul 31, 2026

[BT-122] Migrate Money Request (Part 3) #83850

Closed

6 tasks

quinthar added the #quality label Aug 11, 2026

Navigation Menu

Repository navigation

Migrate money request destination step to dynamic routes (#83850 part 1) - #96949

Migrate money request destination step to dynamic routes (#83850 part 1)#96949
mjasikowski merged 3 commits into
Expensify:mainfrom
suneox:83850-migrate-money-request-part-1-suneox

suneox commented Jul 24, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jul 24, 2026 •

edited by github-actions Bot

Loading

Uh oh!

melvin-bot Bot commented Jul 27, 2026

Uh oh!

huult commented Jul 28, 2026 •

edited

Loading

Uh oh!

huult left a comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 29, 2026

Uh oh!

MelvinBot commented Jul 29, 2026

Uh oh!

OSBotify commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

suneox commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Case 1.1 — Workspace select → Destination (forward entry)

Case 1.2 — Destination back (cut suffix → start)

Case 1.3 — Destination → Time (forward)

Case 1.4 — Time back → Destination (cross-file goBack)

Case 1.5 — Report step policy change → Destination (new reportID)

Case 1.6 — Deep-link / refresh + OldRoutes redirect

Case 2.1 — Confirmation → edit Destination (forward entry)

Case 2.2 — Edit select → back to Confirmation

Case 2.3 — Edit back button

Case 2.4 — Deep-link edit + OldRoutes redirect

Offline tests

QA Steps

Test case 1: Open the per-diem Destination step from the workspace selector

Test case 2: Edit the Destination from the per-diem confirmation screen

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 24, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jul 27, 2026

Uh oh!

huult commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

OSBotify commented Jul 29, 2026

Uh oh!

MelvinBot commented Jul 29, 2026

Uh oh!

OSBotify commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

suneox commented Jul 24, 2026 •

edited

Loading

codecov Bot commented Jul 24, 2026 •

edited by github-actions Bot

Loading

huult commented Jul 28, 2026 •

edited

Loading