[No QA] Commit diff in package-lock.json - #96909
Conversation
|
npm has a |
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63dbd14c17
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -42171,15 +42170,6 @@ | |||
| "engines": { | |||
| "bun": "1.3.14" | |||
| } | |||
There was a problem hiding this comment.
Restore the workspace-pinned React lock entry
This deletion leaves @expensify/victory-chart-renderer without the nested react@19.2.0 package even though its workspace manifest still declares the exact dependency "react": "19.2.0"; the root lock entry is react@19.2.3, so npm now resolves the workspace to an invalid version (npm ls react --package-lock-only --workspaces reports react@19.2.3 ... invalid: "19.2.0" from server/victory-chart-renderer). This can make the victory-chart-renderer install/build use the wrong React version or fail dependency validation until either the nested lock entry is restored or the workspace manifest is updated consistently.
Useful? React with 👍 / 👎.
|
🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.44-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.44-6 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Saw this diff in package-lock.json after running
npm ion main w/ Node 26.5.0Fixed Issues
$
Tests
None.
Offline tests
n/a
QA Steps
None.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop