Repository navigation
Pass hasReportActions to openReport (p5) - #96866
luacmartins merged 3 commits into
Conversation
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppscreen-20260726-190205-1785085270818.mp4Android: mWeb ChromeScreen.Recording.2026-07-26.at.18.39.04.moviOS: HybridAppScreen.Recording.2026-07-26.at.18.31.37.moviOS: mWeb SafariScreen.Recording.2026-07-26.at.18.35.25.movMacOS: Chrome / SafariScreen.Recording.2026-07-26.at.18.27.42.mov |
|
@luacmartins this is waiting for your review |
|
Sorry, I was OOO. Approved. |
|
It seems like one check is stuck. @bernhardoj can you merge main please? |
|
@luacmartins done |
|
🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.52-0 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site content under No help site changes are required. This is an internal refactor with no user-facing behavior change:
Join thread / Leave thread continue to work exactly as before — nothing about the feature, its UI labels, tabs, or settings changed. The QA steps in the PR are regression checks, not new functionality. Since no feature names, buttons, or workflows documented on the help site are affected, there's nothing to update and no draft PR was created. If you believe a specific help article should still be revised, let me know which one and I'll take another look. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #73651
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
web.mp4