fix copy icon in validation code field is cropped on iOS App - #96858
Conversation
|
@codex review |
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Reviewer Checklist
Screenshots/Videos |
|
LGTM! |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.45-0 🚀
|
|
🤖 No help site changes required. I reviewed the changes in this PR against the help site articles under This is a purely cosmetic rendering fix: the copy button in Help site articles document product behavior and workflows — not the pixel-level layout of a UI icon — so there's nothing here that any article needs to reflect. No draft docs PR was created. @jakubstec, if you disagree and think an article should be updated, let me know which behavior changed and I'll draft the docs PR. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |





Explanation of Change
The copy button in
CopyableTextFieldwas rendered ininlinemode, meant for icons inside a line of text. On iOS native this caused the button to be clipped by text line-height instead of normal layout, so the icon got cropped at the top. Fixed by rendering the button in normal (non-inline) mode, since it's a standalone button, not text-embedded.Fixed Issues
$ #96847
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Screen.Recording.2026-07-23.at.10.56.54.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-23.at.10.57.43.mov