Skip to content

[No QA] Billing and Subscriptions: Update links and add images to articles - #96843

Merged
VictoriaExpensify merged 30 commits into
mainfrom
helpsite-update-billing-links
Jul 24, 2026
Merged

[No QA] Billing and Subscriptions: Update links and add images to articles #96843
VictoriaExpensify merged 30 commits into
mainfrom
helpsite-update-billing-links

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Explanation of Change

Followup to #95786 - updates linking from articles in other sections, and adds images from https://github.com/Expensify/Expensify/issues/660985.

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 23, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review July 23, 2026 04:23
@stephanieelliott
stephanieelliott requested review from a team as code owners July 23, 2026 04:23
@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team July 23, 2026 04:23
@stephanieelliott
stephanieelliott removed the request for review from a team July 23, 2026 04:23
Comment thread docs/articles/new-expensify/workspaces/Delete-a-Workspace.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Admin-Offboarding-Checklist.md Outdated
Comment thread docs/articles/new-expensify/settings/Close-Your-Expensify-Account.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR is a followup that updates cross-links across the Billing and Subscriptions section, adds published screenshots to several articles, rewrites Close-Your-Expensify-Account.md, refreshes Admin-Offboarding-Checklist.md, and introduces a new Delete-a-Workspace.md article. The direction is strong: it fixes stale links to the new nested paths, improves readability of the account-closure content, and adds genuinely useful orienting screenshots. However, several image/link snippets are malformed and there is inconsistent Workspace/admin terminology that should be cleaned up before merge.

Scores Summary

  • Readability: 8/10 - Rewritten sections (account closure, what-happens-after) are clearer and more scannable with good bulleted outcomes. Minor typos ("committment", "TAccount") and one leftover duplicated sentence detract slightly.
  • AI Readiness: 8/10 - New Delete-a-Workspace.md has complete YAML (title, description, keywords, internalScope, contentType, platform), a single H1, task-based H2 headings, and an exempt FAQ heading. Headings across edited files remain task-based. Slight deduction for a reversed-syntax link that breaks retrievable anchor text.
  • Style Compliance: 6/10 - Several malformed Markdown snippets and inconsistent terminology (Workspace vs workspace, Workspace Admin vs workspace admin vs "workspace Admin") reduce compliance with the exact-terminology and link-formatting rules.

Key Findings
Critical (must fix before merge):

  • Cancel-an-Annual-Subscription.md: image is missing the .png extension so it will not render.
  • Manage-Annual-Subscription-Settings.md: malformed image Markdown — the alt text is missing its closing bracket before the opening parenthesis, merging link and alt text so the image will not render.
  • Delete-a-Workspace.md: reversed link syntax "(When You Can Change Your Subscription)[/articles/...]" — must be text. Also "committment" typo.
  • Admin-Offboarding-Checklist.md: link "articles/new-expensify/.../Add-or-Update-a-Payment-Card..." is missing the leading slash, making it a broken relative link.
  • Fix-a-Billing-Issue.md: alt-text typo "TAccount" should be "Account".

Style/terminology:

  • Close-Your-Expensify-Account.md and Delete-a-Workspace.md mix "Workspace"/"workspace" and "Workspace Admin"/"workspace admin"/"workspace Admin". Per naming conventions, terminology must be exact and consistent.
  • Delete-a-Workspace.md screenshot placeholder Purpose references "Billing Owners" while the article uses "Workspace owner" — align role naming.

Positive:

  • Stale links to legacy paths (Billing-Overview, Plan-types-and-pricing, Add-a-payment-card-and-view-your-subscription) are correctly repointed to the new nested article paths with descriptive anchor text.
  • Added screenshots use descriptive alt text and support (not replace) the surrounding instructions — consistent with the screenshot guidelines.
  • Close-Your-Expensify-Account.md rewrite is a clear improvement: bulleted eligibility criteria and explicit what-happens-after outcomes.
  • New Delete-a-Workspace.md follows the template structure well (metadata, single H1, task-based H2, FAQ).

Recommendations

  • Fix the four malformed image/link snippets and the reversed FAQ link listed above; these are functional breakages.
  • Run a terminology pass to standardize "Workspace" and "Workspace Admin" / "Workspace owner" casing across the edited and new files.
  • Correct the typos: "TAccount", "committment".
  • Align the Delete-a-Workspace.md screenshot Purpose role wording with the article body.

Files Reviewed

  • Learn-About-Billing-Permissions.md - image added, OK.
  • Learn-About-Subscriptions.md - image added, OK (extra blank line).
  • Add-or-Update-a-Payment-Card.md - image added, OK.
  • Find-Your-Expensify-Billing-Receipt.md - image added, OK.
  • Fix-a-Billing-Issue.md - image added; alt-text typo "TAccount".
  • Manage-Personal-Karma-and-Corporate-Karma.md - image added, OK.
  • Request-Tax-Exemption.md - image added; FAQ heading normalized to "tax exemption", OK.
  • Transfer-Workspace-Ownership.md - two images added, OK.
  • Cancel-an-Annual-Subscription.md - image added; missing .png extension.
  • Manage-Annual-Subscription-Settings.md - image added; malformed Markdown.
  • View-Your-Plan-and-Subscription.md - image added, OK.
  • Set-up-a-Commercial-Card-Feed-Connection.md / Set-up-a-Direct-Company-Card-Feed-Connection.md / Share-a-Company-Card-Connection-Across-Workspaces.md - links repointed, OK.
  • Configure-Quickbooks-Online.md - Control-plan link repointed, OK.
  • Close-Your-Expensify-Account.md - substantial rewrite; strong readability; terminology-casing inconsistencies.
  • Admin-Offboarding-Checklist.md - dedupe + link refresh; one link missing leading slash.
  • Delete-a-Workspace.md - NEW; good structure; reversed FAQ link + "committment" typo + role-naming mismatch.

Note: Detailed line-by-line feedback has been provided as inline comments.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://5eabb0a8.helpdot.pages.dev ⚡️

Updated articles:

@VictoriaExpensify
VictoriaExpensify merged commit 2b3f4c0 into main Jul 24, 2026
14 of 15 checks passed
@VictoriaExpensify
VictoriaExpensify deleted the helpsite-update-billing-links branch July 24, 2026 05:49
@melvin-bot melvin-bot Bot added the Emergency label Jul 24, 2026
@melvin-bot

melvin-bot Bot commented Jul 24, 2026

Copy link
Copy Markdown

@VictoriaExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.45-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Emergency HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants