Skip to content

[Payment due @situchan] Refactor Requestor PersonalInfo loader to ActivityIndicator #96837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicolasBonet merged 5 commits into from
Aug 11, 2026
Merged

[Payment due @situchan] Refactor Requestor PersonalInfo loader to ActivityIndicator #96837

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d030a5a
Refactor PersonalInfo loader to ActivityIndicator
MelvinBot Jul 23, 2026
c8c1712
Fix Oxfmt import ordering in PersonalInfo
MelvinBot Jul 23, 2026
e594765
Use styles.fullScreenLoading and remove redundant alignItemsCenter/ju…
MelvinBot Aug 2, 2026
09d96c4
Merge remote-tracking branch 'origin/main' into claude-ra-ai-personal…
MelvinBot Aug 11, 2026
202e8fe
Re-trigger CI: iOS build failed on transient CocoaPods 401 fetching p…
MelvinBot Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/pages/ReimbursementAccount/USD/Requestor/PersonalInfo/PersonalInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import FullScreenLoadingIndicator from '@components/FullscreenLoadingIndicator';
import ActivityIndicator from '@components/ActivityIndicator';
import InteractiveStepWrapper from '@components/InteractiveStepWrapper';

import useLocalize from '@hooks/useLocalize';
import useOnyx from '@hooks/useOnyx';
import useReimbursementAccountSubmitCallback from '@hooks/useReimbursementAccountSubmitCallback';
import useSubPage from '@hooks/useSubPage';
import type {SubPageProps} from '@hooks/useSubPage/types';
import useThemeStyles from '@hooks/useThemeStyles';

import Navigation from '@libs/Navigation/Navigation';
import {getBankAccountIDAsNumber} from '@libs/ReimbursementAccountUtils';
Expand All @@ -21,9 +22,9 @@ import ROUTES from '@src/ROUTES';
import INPUT_IDS from '@src/types/form/ReimbursementAccountForm';

import type {ForwardedRef} from 'react';
import type {View} from 'react-native';

import React, {useCallback, useMemo} from 'react';
import {View} from 'react-native';

import Address from './subSteps/Address';
import Confirmation from './subSteps/Confirmation';
Expand Down Expand Up @@ -59,6 +60,7 @@ const pages = [

function PersonalInfo({onBackButtonPress, onSubmit, ref, backTo}: PersonalInfoProps) {
const {translate} = useLocalize();
const styles = useThemeStyles();

const [reimbursementAccount] = useOnyx(ONYXKEYS.REIMBURSEMENT_ACCOUNT);
const [reimbursementAccountDraft] = useOnyx(ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM_DRAFT);
Expand Down Expand Up @@ -117,7 +119,9 @@ function PersonalInfo({onBackButtonPress, onSubmit, ref, backTo}: PersonalInfoPr
stepNames={CONST.BANK_ACCOUNT.STEP_NAMES}
>
{isRedirecting ? (
<FullScreenLoadingIndicator />
<View style={[styles.flex1, styles.fullScreenLoading]}>
<ActivityIndicator size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} />
</View>
) : (
<CurrentPage
isEditing={isEditing}
Expand Down
Loading