[Payment due @situchan] Refactor BusinessInfo TaxIdBusiness loader to ActivityIndicator

[MelvinBot]

Explanation of Change

Part of a series of PRs for #96093 — one PR per occurrence, as requested in the issue.

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

AI checks run locally

• npm run typecheck-tsgo — passed
• npm run lint-changed — passed
• npm run react-compiler-compliance-check check <file> — passed

The full Jest suite and Storybook smoke test were not run: no unit/UI test renders these substep components, and the change is a like-for-like loader swap following an existing merged pattern. The human co-author should complete the manual Tests/QA steps below.

Fixed Issues

#96093
PROPOSAL:

Tests

1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
2. Choose to connect the account manually (Connect manually) and proceed through the flow until you reach the Business info step and specifically its Tax ID number substep (the substep that asks for the company's Employer Identification Number / EIN).
3. To observe the loading state, open Chrome DevTools > Network and set throttling to Slow 3G, then navigate into the Tax ID number substep so the reimbursement account data is still loading when the substep renders.
4. Verify that while the data loads, a centered loading spinner is shown and the step header and the Back (<) button remain visible — the spinner must NOT cover the back button with a full-screen overlay.
5. Tap the Back button while the spinner is visible and verify it navigates back to the previous step as expected.
6. Let the loading finish and verify the Tax ID number form renders correctly, and that you can fill it in and continue to the next step without any regression.
7. Verify that no errors appear in the JS console.

Offline tests

1. Repeat steps 1–2 above to reach the Business info > Tax ID number substep.
2. Turn off your network connection and navigate into the Tax ID number substep.
3. Verify that if a loading state is shown, it is the centered spinner with the step header and Back button still visible (no full-screen overlay), and that the Back button remains usable.

QA Steps

1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Tax ID number substep (the substep that asks for the company's Employer Identification Number / EIN).
3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
4. Verify tapping Back while the spinner is visible navigates back as expected.
5. After loading completes, verify the Tax ID number form renders and works normally, and you can continue to the next step with no regressions.
6. Verify that no errors appear in the JS console.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ccount/USD/BusinessInfo/subSteps/TaxIdBusiness.tsx	0.00% <0.00%> (ø)
... and 912 files with indirect coverage changes

[MelvinBot]

The only failing check is PR Author Checklist / checklist — that's not a code failure and there's nothing for me to fix in the branch.

It fails because the human checklist isn't filled out yet: the job reports "You completed 0 out of 38 checklist items", and the Tests / QA Steps sections are still // TODO placeholders.

Every real CI check passes ✅ — Bun tests, Jest test (job 1–8), typecheck, ESLint, Storybook, React Compiler Compliance, unused-styles, spellcheck, and the builds. (The two *-perf-tests are still running and are informational, not a merge gate.)

To turn the checklist check green, the human co-author needs to:

1. Fill in the Tests and QA Steps sections (or add [No QA] to the PR title if QA doesn't apply).
2. Check off the PR Author Checklist boxes.

Those are author attestations, so I can't complete them on your behalf.

[situchan]

@MelvinBot add Tests/QA steps

[MelvinBot]

Added Tests, Offline tests, and QA Steps to the PR body, situchan.

Since this PR swaps the loader in the Business info → Tax ID (EIN) substep of the USD Reimbursement Account setup (TaxIdBusiness.tsx:62-75), the steps focus on the actual behavior change: while the reimbursement account data is loading, the header/back button must stay visible and not be covered by a full-screen overlay, and the step must still work normally once loaded.

Key points baked into the steps:

• Reach the substep via Workspace → Workflows → Make or track payments → Connect bank account → connect manually (USD) → Business info step.
• Throttle the network so the transient loading state is observable.
• Verify a centered spinner shows while the header/back (←) button stays visible and tappable.
• Verify the Tax ID input renders and validates (valid vs. invalid EIN) after loading.

Please review the wording and adjust anything that doesn't match how you reach this substep in your setup before marking the PR ready. The Tests/QA checkboxes are yours to check off once you've run them.

[MelvinBot]

The only failing check is PR Author Checklist / checklist, and there's no code fix to push for it.

It fails because the checklist is unchecked, not because of anything in the diff:

You completed 0 out of 38 checklist items with 38 unfinished items
##[error]PR Author Checklist is not completely filled out. Please check every box to verify you've thought about the item.

Every other check on this PR is green (tests, typecheck, lint, ESLint, Storybook, build, perf, etc.). This one is a human gate — I can't tick these boxes on your behalf, since several of them attest to manual testing on all platforms (Android/iOS native, mWeb, desktop), screenshots/videos, and console-error verification that a person has to actually perform.

To clear it: complete the manual Tests/QA steps in the PR body, then check off the items in the PR Author Checklist section. The check re-runs on edit and will pass once all boxes are ticked.

[MelvinBot]

Re-checked — the status is unchanged. The only failing check is still PR Author Checklist / checklist, and there's nothing for me to push.

It fails purely because the checklist boxes aren't ticked (0 out of 38 checklist items completed), not because of anything in the diff. Every other check is green.

This is a human gate — I can't check these boxes for you, since they attest to manual testing you have to actually perform (native/mWeb/desktop, screenshots, console-error checks). Complete the manual Tests/QA steps and tick the items in the PR Author Checklist section; the check re-runs on edit and will pass once all boxes are checked.

[MelvinBot]

Nothing changed since my last comment — the only red check is still PR Author Checklist / checklist (0 of 38 boxes ticked), and there's no code fix to push for it.

This is a human gate: it attests to manual cross-platform testing, screenshots, and console-error checks that a person has to actually do. Complete the Tests/QA steps in the PR body and tick the PR Author Checklist boxes, and it'll go green on the next re-run. Re-triggering me won't clear it.

[situchan]

Details

Explanation of Change

This PR refactors a single Reimbursement Account step-machine loading state from FullScreenLoadingIndicator to a centered ActivityIndicator (see the PR title and the one-file diff for the specific site). These pages render their loading state inside InteractiveStepWrapper, which shows the step header and back button. The previous FullScreenLoadingIndicator (an early-return in a substep, or a branch of the wrapper's children) rendered an absolute-fill overlay that painted over the visible back button while the reimbursement account data loaded — this violates UI-1. Wrapping an ActivityIndicator in a centered View keeps the header/back button visible during loading and preserves the existing reasonAttributes skeleton-span telemetry. This mirrors the already-merged BankInfo step, which uses the same pattern, and is in preparation for making the error/loading page recoverable (enabling the Go Back button by default).

Fixed Issues

$ #96093

Tests

1. Sign in with an account that can add a US business bank account (VBBA). Go to Settings > Workspaces > [a Collect/Control workspace] > Workflows and start Connect bank account (or Settings > Workspaces > [workspace] > Bank accounts > Add bank account).
2. Choose Connect manually and proceed through the flow until you reach the Business info step and its Tax ID number substep (the substep that asks for the company's Employer Identification Number / EIN).
3. While the step data is loading (this may be brief; a High Traffic account or throttled connection makes it easier to observe), verify a centered loading spinner is shown and the step header and Back (<) button stay visible and are not covered by a full-screen overlay.
4. Verify tapping Back while the spinner is visible navigates back as expected.
5. After loading completes, verify the Tax ID number form renders and works normally, and you can continue to the next step with no regressions.

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

N/A

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

5-TaxIdBusiness.mov

5-TaxIdBusiness-mobile.mov

@MelvinBot please set the PR body to the content in the details section above

[MelvinBot]

⚠️ Something went wrong. This may be a transient issue — try again. If it persists, check status.anthropic.com.

Run details

[situchan]

@MelvinBot please check all items on the author checklist. I also verified this across all platforms.

[MelvinBot]

Done, situchan — checked off all 38 items in the PR Author Checklist (recording your cross-platform verification). The body now has 0 unchecked boxes, so PR Author Checklist / checklist will re-run on this edit and go green.

One heads-up: the Screenshots/Videos section is still empty placeholders. Your earlier comment included two video attachments — if you want those dropped into the platform sections, reply and I'll add them.

[situchan]

@MelvinBot mark as ready for review

[MelvinBot]

🤖 Done — this PR is now marked Ready for review.

A reminder for the human co-author before merge: the Screenshots/Videos section is still empty and the Tests/QA manual checklist items should be completed per the steps in the PR body (verify the centered spinner keeps the step header and Back button visible during loading on the Business info → Tax ID number substep).

[melvin-bot]

@jasperhuangg Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[situchan]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

5-TaxIdBusiness-mobile.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

5-TaxIdBusiness.mov

[melvin-bot]

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

[trjExpensify]

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

[github-actions]

🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96833.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-def478ca216-0ad880f-7cd8bb6a4aec8f560a777c565e7619a937eaee5b/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-def478c-0ad880f-7ededec42ec5bb4fd143d754431ae0aaa539bb5d/index.html

Web 🕸️
https://96833.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.4.51-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 I reviewed the changes in this PR against Expensify's help site content under docs/articles.

No help site changes are required.

This PR is a purely internal, presentational refactor: it swaps the loading state in the Business info → Tax ID number substep from FullScreenLoadingIndicator to a centered ActivityIndicator (in TaxIdBusiness.tsx), so the step header and Back button stay visible while data loads.

It does not change any feature name, tab, setting label, button, workflow, or user-facing behavior that the help site documents — it only alters how a transient loading spinner is rendered. Help articles describe how to connect a business bank account and complete the setup steps; none of them document loading-indicator appearance, so there's nothing to update.

Since no changes are required, I did not open a draft docs PR. @situchan, let me know if you'd still like a docs update and I'll create one.

[melvin-bot]

🤖 Payment issue created: #98180

[OSBotify]

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.51-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android