Skip to content

Coalesce OnyxDerived recomputations via microtask scheduling - #96785

Merged
mountiny merged 7 commits into
Expensify:mainfrom
callstack-internal:perf/derived-value-coalescing-fix
Jul 24, 2026
Merged

mountiny merged 7 commits into
Expensify:mainfrom
callstack-internal:perf/derived-value-coalescing-fix

Conversation

@fabioh8010

@fabioh8010 fabioh8010 commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Re-lands the OnyxDerived recompute coalescing (originally #95287, reverted in #95715), with the
derived-value flush moved from a macrotask to a microtask (queueMicrotask, inlined in
src/libs/actions/OnyxDerived/index.ts).

Coalescing batches the multiple dependency changes delivered in one synchronous Onyx broadcast burst
into a single recompute — preserving the startup/send perf win (send latency ~177ms → ~84ms, ~53%
faster; derived recomputes 51 → 20; reportAttributes computes 11 → 5). Flushing on a microtask
(instead of the previously-reverted macrotask) drains the recompute at the end of the current task,
before React's next render/paint, so raw Onyx data and derived data stay consistent within a
render. That closes the stale-frame / stale-read window that caused the five deploy blockers below.

Also merges latest main and reconciles reportAttributes / visibleReportActions with the
coalescing engine's triggeredKeys contract (including main's RECOMPUTE_ALL narrowing and
session/whisper currentUserAccountID targeting).

Fixed Issues

$ #95301
$ #95696
$ #95698
$ #95700
$ #95721
$ #95753
PROPOSAL: N/A

Tests

Deploy Blockers

  1. FAB → Start chat → enter a user's email → select the user → verify the new chat header shows the user's name and no report label flashes in its place ([Due for payment 2026-07-17] Chat - Chat Report appears on user's name when start new chat #95696).
  2. Open a workspace chat, create an empty report, open it, and create an expense inside it → verify no skeleton/loading flash appears ([Due for payment 2026-07-17] Expense - Skeleton loader appears briefly after creating expense in the empty report #95698).
  3. In the same workspace chat and expense, split it → verify the original expense is removed immediately and does not briefly reappear ([Due for payment 2026-07-17] Original expense briefly appears after splitting an expense #95700).
  4. In the same workspace chat, create a new report and manual expense, open it, go offline, open the Report field → Create Report → verify the expense moves to the new report immediately and is removed from the old one; then go back online and verify the state stays correct (Expense - Expense remains on the same report after being moved to new one in offline mode. #95753).
  5. Go to workspace settings and invite a new user which you will use for the next step.
  6. Login with the freshly-invited account, tap scan, photograph a receipt, create the scan expense to the workspace chat, dismiss the "Enjoying New Expensify" popup → verify the expense preview displays normally (not blank until tapped) ([Due for payment 2026-07-17] iOS-Scan-Report preview is blank after dismissing the "Enjoying New Expensify" pop up #95721).

Misc

  1. Pin/Unpin two reports in LHN, assert they were pinned/unpinned and LHN was re-ordered correctly.
  2. Draft a message to two reports in LHN, assert they were marked and LHN was re-ordered correctly.
  3. Mark two reports in LHN as read/unread, assert they were marked/unmarked, the Unread count indicator changed and LHN was re-ordered correctly.
  4. From another user send a expense to this one, mark it as paid, assert it appeared correctly and the To-dos count indicator changed.
  5. Send a message to a user you never sent before, assert it appeared in LHN.
  6. Delete that message, assert the chat disappeared from LHN.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-07-22.at.20.16.42-compressed.mov
Screen.Recording.2026-07-22.at.21.40.40-compressed.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-22.at.17.04.22-compressed.mov
Screen.Recording.2026-07-22.at.17.17.13-compressed.mov

@fabioh8010
fabioh8010 marked this pull request as ready for review July 22, 2026 20:52
@fabioh8010
fabioh8010 requested review from a team as code owners July 22, 2026 20:52
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify, abzokhattab and shubham1206agra and removed request for a team July 22, 2026 20:52
@melvin-bot

melvin-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown

@shubham1206agra @abzokhattab One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...bs/actions/OnyxDerived/configs/reportAttributes.ts 97.76% <100.00%> (-0.37%) ⬇️
...Derived/configs/reportTransactionsAndViolations.ts 100.00% <100.00%> (ø)
...actions/OnyxDerived/configs/sortedReportActions.ts 94.82% <100.00%> (+0.09%) ⬆️
src/libs/actions/OnyxDerived/utils.ts 100.00% <100.00%> (ø)
src/libs/getCollectionDelta.ts 100.00% <100.00%> (ø)
...ctions/OnyxDerived/configs/visibleReportActions.ts 96.55% <94.44%> (+3.10%) ⬆️
src/libs/actions/OnyxDerived/index.ts 97.39% <98.30%> (+0.37%) ⬆️
... and 8 files with indirect coverage changes

@mountiny
mountiny removed the request for review from abzokhattab July 23, 2026 06:44
@shubham1206agra

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-24.at.3.38.37.PM.mp4

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a v2 of the pr and the regressions were addressed, I will move it ahead to avoid conflicts

@mountiny
mountiny merged commit de48e77 into Expensify:main Jul 24, 2026
35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.45-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review — no changes required

I reviewed the changes in this PR and no updates to Expensify's help site files under App/docs/articles are required.

Why: This PR is a purely internal performance optimization — it coalesces OnyxDerived recomputations by scheduling the derived-value flush on a microtask (queueMicrotask). All changed files are internal library code and tests:

  • src/libs/actions/OnyxDerived/* (engine + configs)
  • src/libs/getCollectionDelta.ts
  • tests/** (unit/UI tests)

There are no user-facing changes here — no new or modified features, UI labels, tabs, settings, buttons, or product copy. The help site documents user-facing product behavior, and nothing in that layer changes as a result of this PR (the deploy-blocker fixes restore correct behavior rather than introduce new documented behavior).

Since no help site changes are needed, I did not create a draft docs PR. If you believe a specific user-facing behavior changed and should be documented, let me know which one and I'll draft the update.

@lanitochka17

Copy link
Copy Markdown

Deploy Blocker #97250 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants