You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bump Android module targetSdkVersion and compileSdkVersion to 36 - #96774
Bumps `targetSdkVersion` and `compileSdkVersion` from 35 to 36 in the `gradle.properties` files for the `ExpensifyNitroUtils`, `hybrid-app`, and `background-task` Android modules. Companion to the Mobile-Expensify PR that bumps the main app target SDK to meet Google Play's API 36 requirement.
[No QA] - Build config only. No user-facing behavior changes.
PR Author Checklist
I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
I added steps for local testing in the Tests section
I added steps for the expected offline behavior in the Offline steps section
I added steps for Staging and/or Production testing in the QA steps section
I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified that comments were added to code that is not self explanatory
I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like `Avatar`, I verified the components using `Avatar` are working as expected)
If a new CSS style is added I verified that: [N/A]
If new assets were added or existing ones were modified: [N/A]
If the PR modifies code that runs when editing or sending messages: [N/A]
If the PR modifies a generic component: [N/A]
If the PR modifies a component related to any of the existing Storybook stories: [N/A]
If the PR modifies a component or page that can be accessed by a direct deeplink: [N/A]
If the PR modifies the UI: [N/A]
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow. [N/A - build config]
If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps.
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Bumps `targetSdkVersion` and `compileSdkVersion` from 35 to 36 in the `gradle.properties` files for the `ExpensifyNitroUtils`, `hybrid-app`, and `background-task` Android modules. Companion to the Mobile-Expensify PR that bumps the main app target SDK to meet Google Play's API 36 requirement.
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14025
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/662541
PROPOSAL:
Tests
Offline tests
N/A — no behavior change.
QA Steps
[No QA] - Build config only. No user-facing behavior changes.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionScreenshots/Videos
N/A — no UI changes.