Repository navigation
Bulk PDF export is unavailable when using Select all across reports - #96667
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@lorretheboy this isn't been hold by the BE anymore |
29a35fa to
59e726d
Compare
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 59e726d8c4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2026-09-23.at.01.54.37.mov |
|
@lorretheboy Please resolve conflicts and fix AI comments |
|
@thelullabyy I fixed it, please continue |
NicolasBonet
left a comment
There was a problem hiding this comment.
Waiting on @thelullabyy's review.
|
🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.4.92-0 🚀
|
|
🤖 Yes — help site changes are required. Draft PR: Docs updates for E/A#96667 bulk PDF download with Select all ( Why: this PR makes Download reports appear in the Selected menu when you use Select all across matching reports, not just Select all on this page. The help site never documented that distinction for PDF downloads — it only said "use the top checkbox to select all," so a reader couldn't tell which reports a bulk PDF download would include. What changed in the docs:
How I verified the labels and behaviorBrowser verification wasn't available in this run (the web dev environment failed to come up), so every UI label was verified against
I wrote to One thing I couldn't do: GitHub rejected assigning you to @lorretheboy, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
This PR failing because of the issue #102084 |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |
|
@jponikarchuk I think it is not a bug, it is intentional |
Explanation of Change
Fixed Issues
$ #96221
PROPOSAL: #96221 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-09-15.at.01.59.13.mov
Android: mWeb Chrome
Screen.Recording.2026-09-15.at.02.02.01.mov
iOS: Native
Screen.Recording.2026-09-15.at.01.53.13.mov
iOS: mWeb Safari
Screen.Recording.2026-09-15.at.01.50.14.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-15.at.01.45.52.mov