Skip to content

Bulk PDF export is unavailable when using Select all across reports - #96667

Merged
NicolasBonet merged 4 commits into
Expensify:mainfrom
lorretheboy:fix/96221
Sep 22, 2026
Merged

NicolasBonet merged 4 commits into
Expensify:mainfrom
lorretheboy:fix/96221

Conversation

@lorretheboy

@lorretheboy lorretheboy commented Jul 21, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #96221
PROPOSAL: #96221 (comment)

Tests

  1. Log in to New Expensify as a workspace admin.
  2. Navigate to Spend > Reports.
  3. Bulk select reports
  4. Click Select all to select all matching reports (not just the current page).
  5. Click Selected > Export.
  6. Observe the available export options.
  7. Verify that Download PDF should be available when using Select all
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Log in to New Expensify as a workspace admin.
  2. Navigate to Spend > Reports.
  3. Bulk select reports
  4. Click Select all to select all matching reports (not just the current page).
  5. Click Selected > Export.
  6. Observe the available export options.
  7. Verify that Download PDF should be available when using Select all
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-09-15.at.01.59.13.mov
Android: mWeb Chrome
Screen.Recording.2026-09-15.at.02.02.01.mov
iOS: Native
Screen.Recording.2026-09-15.at.01.53.13.mov
iOS: mWeb Safari
Screen.Recording.2026-09-15.at.01.50.14.mov
MacOS: Chrome / Safari image
Screen.Recording.2026-09-15.at.01.45.52.mov

@lorretheboy lorretheboy changed the title fix: bulk pdf export Bulk PDF export is unavailable when using Select all across reports Jul 21, 2026
@lorretheboy lorretheboy changed the title Bulk PDF export is unavailable when using Select all across reports [Hold - Waiting BE]Bulk PDF export is unavailable when using Select all across reports Jul 21, 2026
@lorretheboy lorretheboy changed the title [Hold - Waiting BE]Bulk PDF export is unavailable when using Select all across reports [Hold - Waiting BE] Bulk PDF export is unavailable when using Select all across reports Jul 21, 2026
@codecov

codecov Bot commented Jul 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/actions/Export.ts 75.00% <100.00%> (ø)
src/hooks/useSearchBulkActions.ts 76.12% <96.42%> (+0.18%) ⬆️
... and 42 files with indirect coverage changes

@NicolasBonet

Copy link
Copy Markdown
Contributor

@lorretheboy this isn't been hold by the BE anymore

@lorretheboy lorretheboy changed the title [Hold - Waiting BE] Bulk PDF export is unavailable when using Select all across reports Bulk PDF export is unavailable when using Select all across reports Sep 14, 2026
@lorretheboy
lorretheboy marked this pull request as ready for review September 14, 2026 18:02
@lorretheboy
lorretheboy requested review from a team as code owners September 14, 2026 18:02
@melvin-bot
melvin-bot Bot requested review from flaviadefaria and thelullabyy and removed request for a team September 14, 2026 18:02
@melvin-bot

melvin-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 14, 2026 18:02

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 59e726d8c4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/hooks/useSearchBulkActions.ts Outdated
@thelullabyy

thelullabyy commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-23.at.01.54.37.mov

@thelullabyy

Copy link
Copy Markdown
Contributor

@lorretheboy Please resolve conflicts and fix AI comments

@lorretheboy

Copy link
Copy Markdown
Contributor Author

@thelullabyy I fixed it, please continue

@NicolasBonet
NicolasBonet self-requested a review September 21, 2026 17:28

@NicolasBonet NicolasBonet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on @thelullabyy's review.

@melvin-bot
melvin-bot Bot requested a review from NicolasBonet September 22, 2026 17:56
@NicolasBonet
NicolasBonet merged commit 9129da6 into Expensify:main Sep 22, 2026
35 of 39 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.4.92-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Yes — help site changes are required. Draft PR: Docs updates for E/A#96667 bulk PDF download with Select all (Expensify/App#101980)

Why: this PR makes Download reports appear in the Selected menu when you use Select all across matching reports, not just Select all on this page. The help site never documented that distinction for PDF downloads — it only said "use the top checkbox to select all," so a reader couldn't tell which reports a bulk PDF download would include.

What changed in the docs:

File Change
docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md "How to download multiple reports as PDFs" now names Select all on this page and Select all and says what each downloads; new FAQ "How do I download every report matching my search as a PDF?"; refresh FAQ now covers Select all downloads; keywords updated
docs/articles/new-expensify/reports-and-expenses/Search-and-Download-Expenses.md Same Select all on this page / Select all distinction in "Download multiple reports", so the two articles don't contradict each other
How I verified the labels and behavior

Browser verification wasn't available in this run (the web dev environment failed to come up), so every UI label was verified against main in code rather than the live UI:

  • Select all on this page and Select all — the two options in the top-checkbox menu, at src/components/Search/SearchList/SearchSelectAllMenu.tsx:56-57, resolving to search.exportAll.selectAllOnThisPage and workspace.people.selectAll.
  • The menu only opens when the search has more results than the current page (SearchSelectAllMenu.tsx:40) — that's why the doc says "When your search has more reports than fit on one page."
  • Download reports / Download report — common.downloadReport at src/languages/en.ts:470-473.
  • Download file, Send me the file when it's ready, Your file is ready!, Dismiss — src/languages/en.ts:11404-11416.
  • In Select all mode this PR always takes the bulk background path (exportReportsToPDF([], serializedQuery)) and skips the single-report modal, and it clears the selection after starting — so the status window appears even when only one report matches. That's now stated in the new FAQ and in the refresh FAQ's exclusion list.

I wrote to docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md: bolded UI labels in sentence case with no quotes, task-based ## headings only, no ###, unified web/mobile navigation phrasing, and no new # headings. npm run spell-changed passes on both files with 0 issues.

One thing I couldn't do: GitHub rejected assigning you to Expensify/App#101980 because lorretheboy has read permission on Expensify/App, and GitHub only accepts assignees with push access. The HelpDot label is applied and PullerBear is requested as reviewer. Please self-assign from the PR page.

@lorretheboy, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@jponikarchuk

Copy link
Copy Markdown

This PR failing because of the issue #102084
This issue is reproducible in: All platforms

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@lorretheboy

Copy link
Copy Markdown
Contributor Author

@jponikarchuk I think it is not a bug, it is intentional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants