Replace getDisplayNameOrDefault with temporaryGetDisplayNameOrDefault - batch 14 - #96606
Conversation
…arameter for improved localization support across various components.
|
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
…e resolution in getReportOption
|
No product review needed |
|
@cretadn22 Add tests and recording please |
|
@shubham1206agra Done! Added the test steps and recording |
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-23.at.3.52.47.PM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.45-0 🚀
|
Help site review — no changes requiredI reviewed the changes in this PR and no updates to Expensify's help site files ( Why: This is an internal code refactor (batch 14 of the Help site articles document user-facing product features and workflows, not internal utility functions or localization plumbing, so there is nothing to document here. No draft docs PR was created. @cretadn22, if you believe a user-facing behavior did change and warrants a docs update, let me know what it is and I'll create the draft PR. |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #66392
PROPOSAL: #66392
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-23.at.13.57.52.mov