Repository navigation
remove unneccesary custom types from translations batch15 - #96605
Conversation
…ccesary-custom-types-from-translations-batch15_at2
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
please don't review yet, pr was created automatically being open and it has triggered the review, sorry! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78e7d53c9f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
| description: "Choose a plan that's right for you.", | ||
| subscriptionLink: 'Learn more', | ||
| lockedPlanDescription: ({count, annualSubscriptionEndDate}: WorkspaceLockedPlanTypeParams) => ({ | ||
| lockedPlanDescription: ({count}: {count: number}, annualSubscriptionEndDate: string) => ({ |
There was a problem hiding this comment.
object type left here on purpose, lockedPlanDescription returns PluralForm which requires an object with count as first param.
|
I left a few NAB, but overall it looks good to me. LGTM 🚀 |
|
opened for review. previous batches were reviewed by @QichenZhu, so I think we could reassign him here! 😁 |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
done! @QichenZhu |
| const oldDisplayNameHtml = `<strong>${oldDisplayName}</strong>`; | ||
| const policyNameHtml = `<strong>${policyName}</strong>`; | ||
| const shouldUseYou = actorPersonalDetails?.accountID === currentUserAccountID; | ||
| switch (archiveReason) { |
There was a problem hiding this comment.
I see this one and another above that we are replacing the single line version with a switch, which is more verbose and less flexible (as we need to add a case for every new version).
Could we keep the non switch version if we made the params be an object (that does not require a type, but instead we document each type separately using string, number, etc)?
There was a problem hiding this comment.
yeah, we can make an exception for that, look's much simpler. Then I'll refactor other cases of translations like this (probably just a few)
There was a problem hiding this comment.
done, @QichenZhu could you take a look at 45e285b? Thanks!
|
@jakubstec there is a new Greek translation now, so we need to merge our changes or regenerate it. |
|
CI failed @jakubstec |
…neccesary-custom-types-from-translations-batch15_at2
…main) The previous merge from upstream/main kept the stale Mobile-Expensify pointer (3d7ad2f66b) instead of upstream's newer commit (bf3a9782bd).
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
ready! cc @iwiznia |
|
GH actions are stuck and I manually checked that the reviewer checklist is done and that I reviewed the code and did not push to this branch (not an emergency in case the bot asks) |
|
@iwiznia looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.4.52-0 🚀
|
Help site review — no changes required 🟢I reviewed the changes in this PR against Expensify's help site content under Why: This PR is a purely internal TypeScript refactor — the last batch of "remove unnecessary custom types from translations." It changes how translation helpers receive their arguments (from object params like Scope check:
Since the help site documents user-facing product behavior — not internal translation types — there's nothing to add or update, so I have not created a draft docs PR. @jakubstec, since this refactor introduces no user-facing behavior change, there's no linked help site PR to review — no documentation update is warranted here. If you believe a specific article is affected, reply with the article and what changed and I'll take another look. |
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀
Bundle Size Analysis (Sentry): |
8 participants
Explanation of Change
Continue the work of removing unnecessary custom types from translations. Last PR:
#84399.
This is the last batch.
Fixed Issues
$ #76429
PROPOSAL: #76429 (comment)
Tests
Testing every modified component is not necessary since the changes are all related to types only, and TypeScript already checks types and enforces correct parameter usage.
Below is an example place where the changes can be observed in the UI.
1.3.1 Upload small resolution photo (below 80x80) and verify that error message is visible correctly.
3.2 Upload wrong format image (e.g webp) and verify that error message is visible correctly.
2.Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
Screen.Recording.2026-07-21.at.12.46.11.mov
Screen.Recording.2026-07-21.at.12.54.30.mov