[Part 1.2] Remove Onyx.connect(ONYXKEYS.SESSION) in ReportActionsUtils: thread currentUserAccountID through getReimbursedMessage by truph01 · Pull Request #96590 · Expensify/App

truph01 · 2026-07-21T07:21:54Z

Explanation of Change

This PR is part of removing Onyx.connect(ONYXKEYS.SESSION) in ReportActionsUtils.ts by making utility functions pure — passing currentUserAccountID as a parameter instead of reading the module-level variable.

It threads currentUserAccountID through the getReimbursedMessage call chains:

- getReimbursedMessage -> getLastMessageTextForReport -> getAlternateText -> createOption -> getReportDisplayOption (OptionsListUtils) (ShareDetailsPage.tsx)

- getReimbursedMessage -> getLastMessageTextForReport -> getAlternateText -> createOption -> getPolicyExpenseReportOption -> formatSectionsFromSearchTerm (MoneyRequestAttendeeSelector.tsx, ParticipantSearchResults.tsx)

- getReimbursedMessage -> getLastMessageTextForReport -> getAlternateText -> createOption -> getPolicyExpenseReportOption (DynamicSplitBillDetailsPage.tsx, ParticipantSearchResults.tsx, MoneyRequestAttendeeSelector.tsx)

Fixed Issues

$ #66408
PROPOSAL:

Tests

Create workspace with Attendee tracking is enabled.
Create money request to workspace in step 1.
Open the create money request > Click on Attendee row.
Verify the user options in the attendee selector list display correctly.

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-21.at.14.28.19.mov

…ption

melvin-bot · 2026-07-21T07:22:01Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-07-21T07:22:05Z

@danieldoglas Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-21T07:26:31Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/iou/request/ParticipantSearchResults.tsx	`0.65% <ø> (ø)`
src/libs/OptionsListUtils/index.ts	`86.92% <92.30%> (+0.08%)`	⬆️
src/pages/iou/DynamicSplitBillDetailsPage.tsx	`0.00% <0.00%> (ø)`
src/pages/Share/ShareDetailsPage.tsx	`0.00% <0.00%> (ø)`
... and 35 files with indirect coverage changes

truph01 · 2026-07-21T07:29:53Z

@codex review

chatgpt-codex-connector · 2026-07-21T07:34:54Z

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: f8881b0236

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

JmillsExpensify

No product review required.

truph01 · 2026-07-28T10:16:44Z

@DylanDylann Could you review it?

DylanDylann · 2026-07-29T10:29:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-29.at.17.19.31.mov

DylanDylann · 2026-07-29T10:30:09Z

@codex review

chatgpt-codex-connector · 2026-07-29T10:35:39Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 3eb8c5b93b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

github-actions · 2026-07-29T19:06:41Z

🚧 danieldoglas has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-29T19:12:52Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #96590.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-07bda0610fc-0814dff-458fbdbd9a07d066400db96ca2ddd10d8813df4c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-07bda06-0814dff-b274f521dd54fec87a3e1b1fb365e7cefc818547/index.html

Web 🕸️
https://96590.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-29T21:19:04Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.4.46-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-29T21:21:18Z

🤖 No help site changes required.

This PR is a pure internal refactor — it removes Onyx.connect(ONYXKEYS.SESSION) from ReportActionsUtils by threading currentUserAccountID as a parameter through getReimbursedMessage → getLastMessageTextForReport → getAlternateText → createOption → getReportDisplayOption/getPolicyExpenseReportOption.

The changes are limited to function signatures, their call sites, and unit tests. There is no change to any user-facing feature, flow, label, setting, or button, so nothing in App/docs/articles needs to be added or updated. No draft docs PR was created.

OSBotify · 2026-07-31T07:34:44Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.46-10 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

[Part 1.3] Remove Onyx.connect(ONYXKEYS.SESSION) in ReportActionsUtils: thread currentUserAccountID through getReimbursedMessage- #96590

[Part 1.4] Remove Onyx.connect(ONYXKEYS.SESSION) in ReportActionsUtils: thread currentUserAccountID through getReimbursedMessage- #96590

truph01 added 4 commits July 21, 2026 13:58

refactor: thread currentUserAccountID through getReportDisplayOption

09760a8

refactor: thread currentUserAccountID through getPolicyExpenseReportO…

ded096e

…ption

add test

f8881b0

fix: revert redundant change

11ee56f

truph01 requested review from a team as code owners July 21, 2026 07:21

melvin-bot Bot assigned truph01 Jul 21, 2026

melvin-bot Bot requested review from DylanDylann and JmillsExpensify and removed request for a team July 21, 2026 07:21

melvin-bot Bot requested review from a team and danieldoglas and removed request for a team July 21, 2026 07:22

melvin-bot Bot removed the request for review from a team July 21, 2026 07:22

JmillsExpensify reviewed Jul 25, 2026

View reviewed changes

truph01 added 3 commits July 28, 2026 15:01

fix: conflicts

3fdcc49

fix: conflicts

9a27419

fix: lint

3eb8c5b

DylanDylann approved these changes Jul 29, 2026

View reviewed changes

danieldoglas approved these changes Jul 29, 2026

View reviewed changes

danieldoglas merged commit 07bda06 into Expensify:main Jul 29, 2026
34 checks passed

OSBotify mentioned this pull request Jul 29, 2026

Deploy Checklist: New Expensify 2026-07-29 #97375

Closed

melvin-bot Bot mentioned this pull request Jul 31, 2026

Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/ReportActionsUtils.ts #66408

Open

danieldoglas added a commit that referenced this pull request Aug 12, 2026

Merge pull request #97652 from truph01/fix/66408-part-1.3

58b11d8

[Part 1.3] Remove Onyx.connect(ONYXKEYS.SESSION) in ReportActionsUtils: thread currentUserAccountID through getReimbursedMessage- #96590

danieldoglas added a commit that referenced this pull request Sep 22, 2026

Merge pull request #99813 from truph01/fix/66408-part-1.4

032440c

[Part 1.4] Remove Onyx.connect(ONYXKEYS.SESSION) in ReportActionsUtils: thread currentUserAccountID through getReimbursedMessage- #96590

Conversation

truph01 commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 21, 2026

Uh oh!

melvin-bot Bot commented Jul 21, 2026

Uh oh!

codecov Bot commented Jul 21, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

truph01 commented Jul 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 21, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Jul 28, 2026

Uh oh!

DylanDylann commented Jul 29, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Jul 29, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 29, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

OSBotify commented Jul 29, 2026

Uh oh!

MelvinBot commented Jul 29, 2026

Uh oh!

OSBotify commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

truph01 commented Jul 21, 2026 •

edited

Loading

codecov Bot commented Jul 21, 2026 •

edited by github-actions Bot

Loading