Docs updates for E/A#94093 add Default supplier to Xero export settings - #96538
Conversation
Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fde7832591
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
HelpDot Documentation ReviewOverall AssessmentThis PR adds a single bullet to the "Step 2: Set Up Export Settings" list in the New Expensify Xero configuration article, documenting a new Default supplier export control. The change is small, well-scoped, and consistent with the existing list of export-setting bullets. This review evaluates only the added line. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
Holding on this as I think it's behind a beta |
|
@stephanieelliott @Beamanator NO QA steps, OK to checkoff this one? |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀
|
|
@m-natarajan yep for sure 👍 |
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀
Bundle Size Analysis (Sentry): |
Docs updates for #94093
Adds a Default supplier row to the Xero Set Up Export Settings section of the New Expensify Xero configuration article, documenting the new default-supplier control introduced by #94093 (Vendor matching CC – R4: App, Xero extension).
What changed
This mirrors how the peer accounting integrations already document their equivalent control (QuickBooks Online, Sage Intacct, QuickBooks Desktop, and NetSuite all document a "default vendor" in their export settings). Xero labels this control Default supplier in the UI, matching Xero's "Supplier" terminology, so the label is used verbatim per
HELPSITE_NAMING_CONVENTIONS.md.Scope decision
en.tsstring (workspace.xero.defaultSupplier/defaultSupplierDescription).The R4 feature is gated behind the
vendorMatchingbeta and, per the source PR, is off for every Xero workspace today. Customers cannot see the Default supplier row yet. This article change describes GA behavior with no beta caveat, so it should stay in draft until thevendorMatchingbeta reaches general availability for Xero (the same GA cutover the source PR defers its Java exporter switch to). Please confirm the timing before merging.@Beamanator, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.