Skip to content

Docs updates for E/A#94093 add Default supplier to Xero export settings - #96538

Merged
stephanieelliott merged 1 commit into
mainfrom
claude-xeroDefaultSupplierDocs
Sep 4, 2026
Merged

stephanieelliott merged 1 commit into
mainfrom
claude-xeroDefaultSupplierDocs

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Docs updates for #94093

Adds a Default supplier row to the Xero Set Up Export Settings section of the New Expensify Xero configuration article, documenting the new default-supplier control introduced by #94093 (Vendor matching CC – R4: App, Xero extension).

What changed

  • Added one bullet after Xero bank account under Step 2: Set Up Export Settings:
    • Default supplier – Select a supplier to apply to all company card (non-reimbursable) transactions on export to Xero.

This mirrors how the peer accounting integrations already document their equivalent control (QuickBooks Online, Sage Intacct, QuickBooks Desktop, and NetSuite all document a "default vendor" in their export settings). Xero labels this control Default supplier in the UI, matching Xero's "Supplier" terminology, so the label is used verbatim per HELPSITE_NAMING_CONVENTIONS.md.

Scope decision

  • The label text (Default supplier) and description are taken from the PR's en.ts string (workspace.xero.defaultSupplier / defaultSupplierDescription).
  • I intentionally kept this scoped to the Default supplier export-config row only. The PR also flips the per-expense Vendor → Supplier field label and adds a Supplier picker, but the peer integration articles don't document the per-expense vendor field either, so there's no existing pattern to extend and no natural home for it in this connection-settings article.

⚠️ Important: hold until GA

The R4 feature is gated behind the vendorMatching beta and, per the source PR, is off for every Xero workspace today. Customers cannot see the Default supplier row yet. This article change describes GA behavior with no beta caveat, so it should stay in draft until the vendorMatching beta reaches general availability for Xero (the same GA cutover the source PR defers its Java exporter switch to). Please confirm the timing before merging.


@Beamanator, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 21, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review July 24, 2026 00:59
@stephanieelliott
stephanieelliott self-requested a review as a code owner July 24, 2026 00:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fde7832591

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread docs/articles/new-expensify/connections/xero/Configure-Xero.md
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single bullet to the "Step 2: Set Up Export Settings" list in the New Expensify Xero configuration article, documenting a new Default supplier export control. The change is small, well-scoped, and consistent with the existing list of export-setting bullets. This review evaluates only the added line.

Scores Summary

  • Readability: 9/10 - The new bullet is clear, concise, and action-oriented. It follows the exact pattern of the surrounding bullets (bold label, en-dash, single-sentence description) and reads cleanly.
  • AI Readiness: 8/10 - Uses the full UI label verbatim and terminology matching Xero (Supplier), which aids retrieval. It sits under a non-compliant existing top-level heading (Step 2: Set Up Export Settings), but that heading is pre-existing and not part of this diff, so it is not scored against this change.
  • Style Compliance: 9/10 - Correct bold formatting on the UI label, sentence case, no quotation marks, no vague/prohibited navigation language. Matches HELPSITE_NAMING_CONVENTIONS.md button/label rules. The parenthetical "(non-reimbursable)" is a helpful clarification consistent with the neighboring "Xero bank account" bullet.

Key Findings

  • The added bullet correctly uses the exact UI label Default supplier in bold, per the Core UI Referencing and Button Naming standards.
  • Description is deterministic and specific: what it does (apply a supplier), what it applies to (all company card / non-reimbursable transactions), and when (on export to Xero).
  • Consistent with peer integration articles (QuickBooks Online, Sage Intacct, NetSuite) that document an equivalent default-vendor control.
  • Note (not a defect in this diff): the article uses multiple top-level headings and generic "Step 1/Step 2/Step 3" heading names, which violate the single-title and task-based heading rules in HELP_AUTHORING_GUIDELINES.md. These are pre-existing and outside the scope of this one-line change.
  • Non-doc consideration flagged by the author: the feature is gated behind the vendorMatching beta and is off for all Xero workspaces today. The bullet describes GA behavior with no caveat, so timing/draft status should be confirmed before publishing.

Recommendations

  • No changes required to the added line for governance compliance. It is ready as written.
  • Confirm the beta/GA timing before merging so the documented control is actually visible to customers, or add a brief availability note if published early.
  • Optional future cleanup (separate PR): bring the article headings into compliance (single title heading, task-based section headings instead of "Step N").

Files Reviewed

  • docs/articles/new-expensify/connections/xero/Configure-Xero.md - One bullet added under Step 2; compliant with naming and formatting standards.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott

Copy link
Copy Markdown
Contributor

Holding on this as I think it's behind a beta

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#94093 add Default supplier to Xero export settings [Hold for feature] [No QA] Docs updates for E/A#94093 add Default supplier to Xero export settings Jul 25, 2026
@stephanieelliott stephanieelliott changed the title [Hold for feature] [No QA] Docs updates for E/A#94093 add Default supplier to Xero export settings [Hold for Xero vendor mapping] [No QA] Docs updates for E/A#94093 add Default supplier to Xero export settings Jul 31, 2026
@stephanieelliott
stephanieelliott merged commit 48c22db into main Sep 4, 2026
25 checks passed
@stephanieelliott
stephanieelliott deleted the claude-xeroDefaultSupplierDocs branch September 4, 2026 04:54
@stephanieelliott stephanieelliott changed the title [Hold for Xero vendor mapping] [No QA] Docs updates for E/A#94093 add Default supplier to Xero export settings Docs updates for E/A#94093 add Default supplier to Xero export settings Sep 4, 2026
@m-natarajan

Copy link
Copy Markdown

@stephanieelliott @Beamanator NO QA steps, OK to checkoff this one?

@OSBotify

OSBotify commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.73-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@Beamanator

Copy link
Copy Markdown
Contributor

@m-natarajan yep for sure 👍

@OSBotify

OSBotify commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.73-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants