Skip to content

[Payment due @eVoloshchak] Pass managed card context when creating reports - #96503

Merged
mountiny merged 2 commits into
Expensify:mainfrom
ShridharGoel:fix/managed-card-report-domain
Jul 24, 2026
Merged

[Payment due @eVoloshchak] Pass managed card context when creating reports#96503
mountiny merged 2 commits into
Expensify:mainfrom
ShridharGoel:fix/managed-card-report-domain

Conversation

@ShridharGoel

@ShridharGoel ShridharGoel commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Pass the source managed-card transaction ID when an admin creates a report for another member's unreported card expense. This gives the backend trusted context to derive the card's workspace domain instead of using the member's email domain.

Also replace the final positional createNewReport argument with an options object, keeping report names and managed-card context explicit.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/658595
PROPOSAL:

Tests

Automated: tests/actions/ReportTest.ts verifies managedCardTransactionID is included in the CreateAppReport request.

  1. Sign in as a workspace admin whose member has a different email domain from the managed-card workspace domain.
  2. Open the member's unreported managed-card expense.
  3. Move the expense to a new report.
  4. Verify the report is created and the expense remains on it without an error.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline.
  2. Move an unreported managed-card expense to a new report.
  3. Verify the optimistic report and expense move appear.
  4. Reconnect.
  5. Verify the report is created and the expense remains on it.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari
Screen.Recording.2026-07-20.at.11.24.54.PM.mov

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/actions/IOU/Duplicate.ts 91.64% <100.00%> (ø)
src/libs/actions/Report/index.ts 72.09% <100.00%> (+0.52%) ⬆️
...rc/pages/iou/request/step/IOURequestStepReport.tsx 74.68% <0.00%> (-0.96%) ⬇️
...rc/pages/Search/SearchTransactionsChangeReport.tsx 0.00% <0.00%> (ø)
...rc/pages/iou/request/step/IOURequestEditReport.tsx 0.00% <0.00%> (ø)
... and 8 files with indirect coverage changes

@ShridharGoel
ShridharGoel marked this pull request as ready for review July 21, 2026 14:01
@ShridharGoel
ShridharGoel requested review from a team as code owners July 21, 2026 14:01
@melvin-bot
melvin-bot Bot requested review from eVoloshchak and heyjennahay and removed request for a team and heyjennahay July 21, 2026 14:01
@melvin-bot

melvin-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 21, 2026 14:01
@eVoloshchak

eVoloshchak commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
screen-20260723-233412-1784842394248.mp4
Android: mWeb Chrome
Screen.Recording.2026-07-23.at.23.24.59.mov
iOS: HybridApp
Screen.Recording.2026-07-23.at.23.22.54.mov
iOS: mWeb Safari
Screen.Recording.2026-07-23.at.23.16.30.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-23.at.23.12.32.mov

@eVoloshchak eVoloshchak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot melvin-bot Bot changed the title Pass managed card context when creating reports [Payment due @eVoloshchak] Pass managed card context when creating reports Jul 23, 2026
@melvin-bot

melvin-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

🎯 @eVoloshchak, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/658595.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

@mountiny
mountiny merged commit c5745c0 into Expensify:main Jul 24, 2026
43 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.45-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

Help site review: no docs changes required

I reviewed the changes in this PR and no updates are needed to the help site files under App/docs/articles.

Why: This is an internal/backend plumbing change with no user-facing impact:

  • Adds an optional managedCardTransactionID parameter to the CreateAppReport request so the backend can derive the managed card's workspace domain from trusted context (instead of the member's email domain).
  • Refactors createNewReport's final positional argument into an options object ({managedCardTransactionID, reportName}).

The end-user flow is unchanged — an admin moving a member's unreported managed-card expense to a new report behaves exactly as before from the UI. There are no new features, buttons, tabs, settings labels, or workflow changes that a help article would document. The help site does not describe this internal domain-derivation logic, so there is nothing to add or correct.

Since no documentation changes are required, I did not open a draft docs PR — there is nothing to link or mark Ready for review.


ShridharGoel, if you believe a specific article should still be updated, reply with the article and what behavior it should describe, and I'll draft the docs PR.

@IuliiaHerets

Copy link
Copy Markdown

Hi @ShridharGoel. Could you please explain how to set up a workspace where the workspace admin has a different email domain than the managed-card workspace domain?

@mountiny @luacmartins

@ShridharGoel

Copy link
Copy Markdown
Contributor Author

Suppose your workspace belongs to domain expensifail.com, then it should have a member whose domain is something else (like example.com). Perform actions as the workspace admin, for the member's unreported card expense.

@IuliiaHerets

Copy link
Copy Markdown

Hi @ShridharGoel. QA team failed this PR due to an original issue, as the error still appears in the console.
As we need to create a new issue, please let us know

1785190775695.96503-Web.mp4

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.4.45-14 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@melvin-bot

melvin-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

🤖 Payment issue created: #97376

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants